Title: [94774] trunk/Source/_javascript_Core
- Revision
- 94774
- Author
- [email protected]
- Date
- 2011-09-08 11:41:55 -0700 (Thu, 08 Sep 2011)
Log Message
Remove getUInt32 from JSCell
https://bugs.webkit.org/show_bug.cgi?id=67691
Patch by Mark Hahnenberg <[email protected]> on 2011-09-08
Reviewed by Oliver Hunt.
We don't use JSCell::getUInt32 anymore, so it has been removed.
* _javascript_Core.exp:
* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (94773 => 94774)
--- trunk/Source/_javascript_Core/ChangeLog 2011-09-08 18:38:13 UTC (rev 94773)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-09-08 18:41:55 UTC (rev 94774)
@@ -1,3 +1,17 @@
+2011-09-08 Mark Hahnenberg <[email protected]>
+
+ Remove getUInt32 from JSCell
+ https://bugs.webkit.org/show_bug.cgi?id=67691
+
+ Reviewed by Oliver Hunt.
+
+ We don't use JSCell::getUInt32 anymore, so it has been removed.
+
+ * _javascript_Core.exp:
+ * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
+ * runtime/JSCell.cpp:
+ * runtime/JSCell.h:
+
2011-09-07 Filip Pizlo <[email protected]>
PPC build fix.
Modified: trunk/Source/_javascript_Core/_javascript_Core.exp (94773 => 94774)
--- trunk/Source/_javascript_Core/_javascript_Core.exp 2011-09-08 18:38:13 UTC (rev 94773)
+++ trunk/Source/_javascript_Core/_javascript_Core.exp 2011-09-08 18:41:55 UTC (rev 94774)
@@ -547,7 +547,6 @@
__ZNK3JSC6JSCell8toStringEPNS_9ExecStateE
__ZNK3JSC6JSCell9getStringEPNS_9ExecStateE
__ZNK3JSC6JSCell9getStringEPNS_9ExecStateERNS_7UStringE
-__ZNK3JSC6JSCell9getUInt32ERj
__ZNK3JSC6JSCell9toBooleanEPNS_9ExecStateE
__ZNK3JSC7ArgList8getSliceEiRS0_
__ZNK3JSC7JSArray12subclassDataEv
Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def (94773 => 94774)
--- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-09-08 18:38:13 UTC (rev 94773)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-09-08 18:41:55 UTC (rev 94774)
@@ -212,7 +212,6 @@
?getSlice@ArgList@JSC@@QBEXHAAV12@@Z
?getString@JSCell@JSC@@QBE?AVUString@2@PAVExecState@2@@Z
?getString@JSCell@JSC@@QBE_NPAVExecState@2@AAVUString@2@@Z
- ?getUInt32@JSCell@JSC@@UBE_NAAI@Z
?getter@PropertyDescriptor@JSC@@QBE?AVJSValue@2@XZ
?globalExec@JSGlobalObject@JSC@@QAEPAVExecState@2@XZ
?globalObjectCount@Heap@JSC@@QAEIXZ
Modified: trunk/Source/_javascript_Core/runtime/JSCell.cpp (94773 => 94774)
--- trunk/Source/_javascript_Core/runtime/JSCell.cpp 2011-09-08 18:38:13 UTC (rev 94773)
+++ trunk/Source/_javascript_Core/runtime/JSCell.cpp 2011-09-08 18:41:55 UTC (rev 94774)
@@ -30,11 +30,6 @@
namespace JSC {
-bool JSCell::getUInt32(uint32_t&) const
-{
- return false;
-}
-
bool JSCell::getString(ExecState* exec, UString&stringValue) const
{
if (!isString())
Modified: trunk/Source/_javascript_Core/runtime/JSCell.h (94773 => 94774)
--- trunk/Source/_javascript_Core/runtime/JSCell.h 2011-09-08 18:38:13 UTC (rev 94773)
+++ trunk/Source/_javascript_Core/runtime/JSCell.h 2011-09-08 18:41:55 UTC (rev 94774)
@@ -103,10 +103,6 @@
virtual CallType getCallData(CallData&);
virtual ConstructType getConstructData(ConstructData&);
- // Extracting integer values.
- // FIXME: remove these methods, can check isNumberCell in JSValue && then call asNumberCell::*.
- virtual bool getUInt32(uint32_t&) const;
-
// Basic conversions.
virtual JSValue toPrimitive(ExecState*, PreferredPrimitiveType) const;
virtual bool getPrimitiveNumber(ExecState*, double& number, JSValue&);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
