Title: [94804] trunk/Source/WebKit2
- Revision
- 94804
- Author
- [email protected]
- Date
- 2011-09-08 14:51:58 -0700 (Thu, 08 Sep 2011)
Log Message
Don't release the modal placeholder window if it's closed
https://bugs.webkit.org/show_bug.cgi?id=67801
<rdar://problem/10088059>
Reviewed by Adam Roben.
This is a speculative fix - nothing should really be able to close the modal placeholder window.
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::beginModal):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (94803 => 94804)
--- trunk/Source/WebKit2/ChangeLog 2011-09-08 21:50:48 UTC (rev 94803)
+++ trunk/Source/WebKit2/ChangeLog 2011-09-08 21:51:58 UTC (rev 94804)
@@ -1,3 +1,16 @@
+2011-09-08 Anders Carlsson <[email protected]>
+
+ Don't release the modal placeholder window if it's closed
+ https://bugs.webkit.org/show_bug.cgi?id=67801
+ <rdar://problem/10088059>
+
+ Reviewed by Adam Roben.
+
+ This is a speculative fix - nothing should really be able to close the modal placeholder window.
+
+ * UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
+ (WebKit::PluginProcessProxy::beginModal):
+
2011-09-07 Alexei Svitkine <[email protected]>
Add test infrastructure to test rubber-banding overhang drawing along with layout tests for existing Chromium Mac overhang drawing in the non-gpu path.
Modified: trunk/Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm (94803 => 94804)
--- trunk/Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm 2011-09-08 21:50:48 UTC (rev 94803)
+++ trunk/Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm 2011-09-08 21:51:58 UTC (rev 94804)
@@ -210,6 +210,7 @@
ASSERT(!m_activationObserver);
m_placeholderWindow.adoptNS([[WKPlaceholderModalWindow alloc] initWithContentRect:NSMakeRect(0, 0, 1, 1) styleMask:NSBorderlessWindowMask backing:NSBackingStoreBuffered defer:YES]);
+ [m_placeholderWindow.get() setReleasedWhenClosed:NO];
m_activationObserver = [[NSNotificationCenter defaultCenter] addObserverForName:NSApplicationWillBecomeActiveNotification object:NSApp queue:nil
usingBlock:^(NSNotification *){ applicationDidBecomeActive(); }];
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
