Title: [94909] trunk/Tools
Revision
94909
Author
commit-qu...@webkit.org
Date
2011-09-10 10:52:15 -0700 (Sat, 10 Sep 2011)

Log Message

Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=59328

Patch by Andreas Kling <kl...@webkit.org> on 2011-09-10
Reviewed by Kenneth Rohde Christiansen.

* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (94908 => 94909)


--- trunk/Tools/ChangeLog	2011-09-10 14:21:01 UTC (rev 94908)
+++ trunk/Tools/ChangeLog	2011-09-10 17:52:15 UTC (rev 94909)
@@ -1,3 +1,13 @@
+2011-09-10  Andreas Kling  <kl...@webkit.org>
+
+        Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
+        https://bugs.webkit.org/show_bug.cgi?id=59328
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        * MiniBrowser/mac/BrowserWindowController.m:
+        (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
+
 2011-09-10  Adam Barth  <aba...@webkit.org>
 
         Build fix for Android.  DumpRenderTree is a client of the WebKit API

Modified: trunk/Tools/MiniBrowser/mac/BrowserWindowController.m (94908 => 94909)


--- trunk/Tools/MiniBrowser/mac/BrowserWindowController.m	2011-09-10 14:21:01 UTC (rev 94908)
+++ trunk/Tools/MiniBrowser/mac/BrowserWindowController.m	2011-09-10 17:52:15 UTC (rev 94909)
@@ -684,6 +684,10 @@
         emptyURL = WKURLCreateWithUTF8CString("");
 
     WKURLRef url = ""
+
+    if (!url)
+        return;
+
     if (WKURLIsEqual(url, emptyURL)) {
         WKRelease(url);
         return;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to