Title: [95045] trunk/Source/WebKit/chromium
- Revision
- 95045
- Author
- [email protected]
- Date
- 2011-09-13 14:43:13 -0700 (Tue, 13 Sep 2011)
Log Message
[Chromium] The checked state of WebPopupMenuItem isn't initialized
https://bugs.webkit.org/show_bug.cgi?id=67889
Reviewed by Darin Fisher.
It seems we're failing to initialize the checked state of
WebPopupMenuItems, potentially because Android is the first platform to
use popup menus for <select> elements.
* src/ExternalPopupMenu.cpp:
(WebKit::ExternalPopupMenu::getPopupMenuInfo):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (95044 => 95045)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-09-13 21:08:54 UTC (rev 95044)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-09-13 21:43:13 UTC (rev 95045)
@@ -1,3 +1,17 @@
+2011-09-13 Adam Barth <[email protected]>
+
+ [Chromium] The checked state of WebPopupMenuItem isn't initialized
+ https://bugs.webkit.org/show_bug.cgi?id=67889
+
+ Reviewed by Darin Fisher.
+
+ It seems we're failing to initialize the checked state of
+ WebPopupMenuItems, potentially because Android is the first platform to
+ use popup menus for <select> elements.
+
+ * src/ExternalPopupMenu.cpp:
+ (WebKit::ExternalPopupMenu::getPopupMenuInfo):
+
2011-09-13 Eric Seidel <[email protected]>
Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
Modified: trunk/Source/WebKit/chromium/src/ExternalPopupMenu.cpp (95044 => 95045)
--- trunk/Source/WebKit/chromium/src/ExternalPopupMenu.cpp 2011-09-13 21:08:54 UTC (rev 95044)
+++ trunk/Source/WebKit/chromium/src/ExternalPopupMenu.cpp 2011-09-13 21:43:13 UTC (rev 95045)
@@ -173,6 +173,7 @@
else
popupItem.type = WebMenuItemInfo::Option;
popupItem.enabled = m_popupMenuClient->itemIsEnabled(i);
+ popupItem.checked = m_popupMenuClient->itemIsSelected(i);
PopupMenuStyle style = m_popupMenuClient->itemStyle(i);
if (style.textDirection() == WebCore::RTL)
popupItem.textDirection = WebTextDirectionRightToLeft;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
