Title: [95063] trunk
- Revision
- 95063
- Author
- hara...@google.com
- Date
- 2011-09-13 18:05:27 -0700 (Tue, 13 Sep 2011)
Log Message
Implement a HashChangeEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=67969
Reviewed by Nate Chapin.
Source/WebCore:
Test: fast/events/constructors/hash-change-event-constructor.html
* bindings/v8/custom/V8EventConstructors.cpp: Added the HashChangeEvent constructor.
* dom/HashChangeEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled hash-change-event-constructor.html, since now V8 has a HashChangeEvent constructor.
* platform/chromium/test_expectations.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (95062 => 95063)
--- trunk/LayoutTests/ChangeLog 2011-09-14 01:03:47 UTC (rev 95062)
+++ trunk/LayoutTests/ChangeLog 2011-09-14 01:05:27 UTC (rev 95063)
@@ -1,3 +1,14 @@
+2011-09-13 Kentaro Hara <hara...@google.com>
+
+ Implement a HashChangeEvent constructor for V8
+ https://bugs.webkit.org/show_bug.cgi?id=67969
+
+ Reviewed by Nate Chapin.
+
+ Enabled hash-change-event-constructor.html, since now V8 has a HashChangeEvent constructor.
+
+ * platform/chromium/test_expectations.txt:
+
2011-09-13 Jeremy Apthorp <jere...@google.com>
Removing an iframe from the document during a transition to fullscreen
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (95062 => 95063)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-14 01:03:47 UTC (rev 95062)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-14 01:05:27 UTC (rev 95063)
@@ -83,9 +83,6 @@
BUGCR10395 SKIP : svg/custom/image-with-prefix-in-webarchive.svg = PASS FAIL
BUGCR10395 SKIP : http/tests/webarchive = PASS FAIL
-// This will soon be fixed after implementing a HashChangeEvent constructor for V8.
-BUGWK67924 : fast/events/constructors/hash-change-event-constructor.html = FAIL
-
// According to the Chromium bug, we need to write some sort of workaround for
// how clipboards on Windows work, or something? That doesn't explain why this
// fails for other platforms...
Modified: trunk/Source/WebCore/ChangeLog (95062 => 95063)
--- trunk/Source/WebCore/ChangeLog 2011-09-14 01:03:47 UTC (rev 95062)
+++ trunk/Source/WebCore/ChangeLog 2011-09-14 01:05:27 UTC (rev 95063)
@@ -1,3 +1,15 @@
+2011-09-13 Kentaro Hara <hara...@google.com>
+
+ Implement a HashChangeEvent constructor for V8
+ https://bugs.webkit.org/show_bug.cgi?id=67969
+
+ Reviewed by Nate Chapin.
+
+ Test: fast/events/constructors/hash-change-event-constructor.html
+
+ * bindings/v8/custom/V8EventConstructors.cpp: Added the HashChangeEvent constructor.
+ * dom/HashChangeEvent.idl: Added a 'V8CustomConstructor' attribute.
+
2011-09-13 Jeremy Apthorp <jere...@google.com>
Fix crash when an iframe element is removed during a transition to
Modified: trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp (95062 => 95063)
--- trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-09-14 01:03:47 UTC (rev 95062)
+++ trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-09-14 01:05:27 UTC (rev 95063)
@@ -34,6 +34,7 @@
#include "CustomEvent.h"
#include "Document.h"
#include "DocumentFragment.h"
+#include "HashChangeEvent.h"
#include "Node.h"
#include "ProgressEvent.h"
#include "WebKitAnimationEvent.h"
@@ -44,6 +45,7 @@
#include "V8CustomEvent.h"
#include "V8Document.h"
#include "V8Event.h"
+#include "V8HashChangeEvent.h"
#include "V8Node.h"
#include "V8ProgressEvent.h"
#include "V8Proxy.h"
@@ -105,6 +107,7 @@
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_CUSTOM_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_PROGRESS_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_WEBKIT_ANIMATION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
+INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_HASH_CHANGE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
} // namespace WebCore
Modified: trunk/Source/WebCore/dom/HashChangeEvent.idl (95062 => 95063)
--- trunk/Source/WebCore/dom/HashChangeEvent.idl 2011-09-14 01:03:47 UTC (rev 95062)
+++ trunk/Source/WebCore/dom/HashChangeEvent.idl 2011-09-14 01:05:27 UTC (rev 95063)
@@ -22,7 +22,8 @@
// Introduced in http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#event-hashchange
interface [
CanBeConstructed,
- CustomConstructFunction
+ CustomConstructFunction,
+ V8CustomConstructor
] HashChangeEvent : Event {
void initHashChangeEvent(in [Optional=CallWithDefaultValue] DOMString type,
in [Optional=CallWithDefaultValue] boolean canBubble,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
