Title: [95247] trunk/Tools
- Revision
- 95247
- Author
- commit-qu...@webkit.org
- Date
- 2011-09-15 17:39:34 -0700 (Thu, 15 Sep 2011)
Log Message
Python version check is confusing in test-webkitpy
https://bugs.webkit.org/show_bug.cgi?id=68004
Patch by Tom Zakrajsek <t...@codeaurora.org> on 2011-09-15
Reviewed by Adam Barth.
* Scripts/test-webkitpy:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (95246 => 95247)
--- trunk/Tools/ChangeLog 2011-09-16 00:33:34 UTC (rev 95246)
+++ trunk/Tools/ChangeLog 2011-09-16 00:39:34 UTC (rev 95247)
@@ -1,3 +1,12 @@
+2011-09-15 Tom Zakrajsek <t...@codeaurora.org>
+
+ Python version check is confusing in test-webkitpy
+ https://bugs.webkit.org/show_bug.cgi?id=68004
+
+ Reviewed by Adam Barth.
+
+ * Scripts/test-webkitpy:
+
2011-09-15 Eric Seidel <e...@webkit.org>
Reviewed by Adam Barth.
Modified: trunk/Tools/Scripts/test-webkitpy (95246 => 95247)
--- trunk/Tools/Scripts/test-webkitpy 2011-09-16 00:33:34 UTC (rev 95246)
+++ trunk/Tools/Scripts/test-webkitpy 2011-09-16 00:39:34 UTC (rev 95247)
@@ -216,17 +216,16 @@
versioning.check_version(log=_log)
- (comparison, current_version, minimum_version) = \
+ (comparison, current_version, expected_version) = \
versioning.compare_version()
- if comparison > 0:
- # Then the current version is later than the minimum version.
- message = ("You are testing webkitpy with a Python version (%s) "
- "higher than the minimum version (%s) it was meant "
- "to support." % (current_version, minimum_version))
+ if comparison != 0:
+ # Then the current version is not what we expect.
+ message = ("You are testing webkitpy with Python version (%s) "
+ "instead of version (%s) which we support. Please verify "
+ "changes against version (%s)" % (current_version, expected_version, expected_version))
_log.warn(message)
-
def _path_from_webkit_root(*components):
webkit_root = os.path.dirname(os.path.dirname(os.path.dirname(__file__)))
return os.path.join(webkit_root, *components)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
