Log Message
Web Inspector: rename Console.clearConsoleMessages to Console.clearMessages, brush up console domain doc. https://bugs.webkit.org/show_bug.cgi?id=68165
Reviewed by Yury Semikhatsky. Source/WebCore: * inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::clearConsoleMessages): * inspector/Inspector.json: * inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::clearMessages): * inspector/InspectorConsoleAgent.h: * inspector/front-end/ConsoleModel.js: (WebInspector.ConsoleModel.prototype.requestClearMessages): LayoutTests: * inspector/protocol/console-agent-expected.txt: * inspector/protocol/console-agent.html:
Modified Paths
- trunk/LayoutTests/ChangeLog
- trunk/LayoutTests/inspector/protocol/console-agent-expected.txt
- trunk/LayoutTests/inspector/protocol/console-agent.html
- trunk/Source/WebCore/ChangeLog
- trunk/Source/WebCore/inspector/InjectedScriptHost.cpp
- trunk/Source/WebCore/inspector/Inspector.json
- trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp
- trunk/Source/WebCore/inspector/InspectorConsoleAgent.h
- trunk/Source/WebCore/inspector/front-end/ConsoleModel.js
Diff
Modified: trunk/LayoutTests/ChangeLog (95281 => 95282)
--- trunk/LayoutTests/ChangeLog 2011-09-16 09:13:34 UTC (rev 95281)
+++ trunk/LayoutTests/ChangeLog 2011-09-16 09:29:14 UTC (rev 95282)
@@ -1,3 +1,13 @@
+2011-09-15 Pavel Feldman <[email protected]>
+
+ Web Inspector: rename Console.clearConsoleMessages to Console.clearMessages, brush up console domain doc.
+ https://bugs.webkit.org/show_bug.cgi?id=68165
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/protocol/console-agent-expected.txt:
+ * inspector/protocol/console-agent.html:
+
2011-09-16 Keishi Hattori <[email protected]>
[chromium] Rebaselines due to r95203 and r95207.
Modified: trunk/LayoutTests/inspector/protocol/console-agent-expected.txt (95281 => 95282)
--- trunk/LayoutTests/inspector/protocol/console-agent-expected.txt 2011-09-16 09:13:34 UTC (rev 95281)
+++ trunk/LayoutTests/inspector/protocol/console-agent-expected.txt 2011-09-16 09:29:14 UTC (rev 95282)
@@ -91,11 +91,11 @@
}
-----------------------------------------------------------
-ConsoleAgent.clearConsoleMessages()
+ConsoleAgent.clearMessages()
request:
{
- method : "Console.clearConsoleMessages"
+ method : "Console.clearMessages"
id : <number>
}
@@ -173,7 +173,7 @@
{
enable : "checked"
disable : "checked"
- clearConsoleMessages : "checked"
+ clearMessages : "checked"
setMonitoringXHREnabled : "checked"
addInspectedNode : "checked"
messageAdded : "checked"
Modified: trunk/LayoutTests/inspector/protocol/console-agent.html (95281 => 95282)
--- trunk/LayoutTests/inspector/protocol/console-agent.html 2011-09-16 09:13:34 UTC (rev 95281)
+++ trunk/LayoutTests/inspector/protocol/console-agent.html 2011-09-16 09:29:14 UTC (rev 95282)
@@ -10,7 +10,7 @@
["ConsoleAgent", "disable"],
["ConsoleAgent", "enable"],
["RuntimeAgent", "evaluate", "console.info('test'); console.info('test')", "test-group", false],
- ["ConsoleAgent", "clearConsoleMessages"],
+ ["ConsoleAgent", "clearMessages"],
["ConsoleAgent", "setMonitoringXHREnabled", true],
["ConsoleAgent", "setMonitoringXHREnabled", false],
["ConsoleAgent", "addInspectedNode", 1]
Modified: trunk/Source/WebCore/ChangeLog (95281 => 95282)
--- trunk/Source/WebCore/ChangeLog 2011-09-16 09:13:34 UTC (rev 95281)
+++ trunk/Source/WebCore/ChangeLog 2011-09-16 09:29:14 UTC (rev 95282)
@@ -1,3 +1,19 @@
+2011-09-15 Pavel Feldman <[email protected]>
+
+ Web Inspector: rename Console.clearConsoleMessages to Console.clearMessages, brush up console domain doc.
+ https://bugs.webkit.org/show_bug.cgi?id=68165
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/InjectedScriptHost.cpp:
+ (WebCore::InjectedScriptHost::clearConsoleMessages):
+ * inspector/Inspector.json:
+ * inspector/InspectorConsoleAgent.cpp:
+ (WebCore::InspectorConsoleAgent::clearMessages):
+ * inspector/InspectorConsoleAgent.h:
+ * inspector/front-end/ConsoleModel.js:
+ (WebInspector.ConsoleModel.prototype.requestClearMessages):
+
2011-09-16 Alejandro G. Castro <[email protected]>
Fix GTK build after r95245.
Modified: trunk/Source/WebCore/inspector/InjectedScriptHost.cpp (95281 => 95282)
--- trunk/Source/WebCore/inspector/InjectedScriptHost.cpp 2011-09-16 09:13:34 UTC (rev 95281)
+++ trunk/Source/WebCore/inspector/InjectedScriptHost.cpp 2011-09-16 09:29:14 UTC (rev 95282)
@@ -122,7 +122,7 @@
{
if (m_consoleAgent) {
ErrorString error;
- m_consoleAgent->clearConsoleMessages(&error);
+ m_consoleAgent->clearMessages(&error);
}
}
Modified: trunk/Source/WebCore/inspector/Inspector.json (95281 => 95282)
--- trunk/Source/WebCore/inspector/Inspector.json 2011-09-16 09:13:34 UTC (rev 95281)
+++ trunk/Source/WebCore/inspector/Inspector.json 2011-09-16 09:29:14 UTC (rev 95282)
@@ -128,7 +128,7 @@
{
"name": "reload",
"parameters": [
- { "name": "ignoreCache", "type": "boolean", "optional": true }
+ { "name": "ignoreCache", "type": "boolean", "optional": true, "description": "If true, browser cache is ignored (as if the user pressed Shift+refresh)." }
],
"description": "Reloads given page optionally ignoring the cache."
},
@@ -332,7 +332,7 @@
},
{
"domain": "Console",
- "description": "Console domain defines methods and events for interaction with the _javascript_ console. One needs to enable this domain using <code>enable</code> function in order to start receiving the console messages.",
+ "description": "Console domain defines methods and events for interaction with the _javascript_ console. Console collects messages created by means of the <a href=''>_javascript_ Console API</a>. One needs to enable this domain using <code>enable</code> function in order to start receiving the console messages. Browser will collect messages issued while console domain is not enabled and will report them using <code>messageAdded</code> notification upon enabling.",
"types": [
{
"id": "ConsoleMessage",
@@ -342,13 +342,13 @@
{ "name": "source", "type": "string", "enum": ["html", "wml", "xml", "_javascript_", "css", "other"], "description": "Message source." },
{ "name": "type", "type": "string", "enum": ["log", "other", "trace", "startGroup", "startGroupCollapsed", "endGroup", "assert", "uncaughtException", "networkError", "result"], "description": "Message type." },
{ "name": "level", "type": "string", "enum": ["tip", "log", "warning", "error", "debug"], "description": "Message severity." },
- { "name": "line", "type": "integer", "description": "_javascript_ source line that created console message." },
- { "name": "url", "type": "string", "description": "_javascript_ source url that created console message." },
- { "name": "repeatCount", "type": "integer", "optional": true, "description": "Repeat count for repeated messages." },
+ { "name": "line", "type": "integer", "description": "Line number in the message origin resource." },
+ { "name": "url", "type": "string", "description": "URL of the message origin." },
+ { "name": "repeatCount", "type": "integer", "description": "Repeat count for repeated messages." },
{ "name": "text", "type": "string", "description": "Message text." },
- { "name": "networkRequestId", "$ref": "Network.RequestId", "optional": true, "description": "Identifier of the network request associated with the console message." },
+ { "name": "networkRequestId", "$ref": "Network.RequestId", "optional": true, "description": "Identifier of the network request associated with this message." },
{ "name": "parameters", "type": "array", "items": { "$ref": "Runtime.RemoteObject" }, "description": "Message parameters in case of the formatted message." },
- { "name": "stackTrace", "$ref": "StackTrace", "description": "Stack trace for assert and error messages." }
+ { "name": "stackTrace", "$ref": "StackTrace", "description": "_javascript_ stack trace for assertions and error messages." }
]
},
{
@@ -357,40 +357,41 @@
"description": "Stack entry for console errors and assertions.",
"properties": [
{ "name": "functionName", "type": "string", "description": "_javascript_ function name." },
- { "name": "url", "type": "string", "description": "_javascript_ source name / url." },
- { "name": "lineNumber", "type": "string", "description": "_javascript_ source line number." },
- { "name": "columnNumber", "type": "string", "description": "_javascript_ source column number." }
+ { "name": "url", "type": "string", "description": "_javascript_ script name or url." },
+ { "name": "lineNumber", "type": "string", "description": "_javascript_ script line number." },
+ { "name": "columnNumber", "type": "string", "description": "_javascript_ script column number." }
]
},
{
"id": "StackTrace",
"type": "array",
"items": { "$ref": "CallFrame" },
- "description": "Call frames for assert and error messages."
+ "description": "Call frames for assertions or error messages."
}
],
"commands": [
{
"name": "enable",
"returns": [
- { "name": "expiredMessagesCount", "type": "integer", "description": "Number of messages cleared due to message threashold overflow." }
+ { "name": "expiredMessagesCount", "type": "integer", "description": "Number of messages collected due to message threashold overflow." }
],
- "description": "Enables console domain, sends all the messages collected so far to the client."
+ "description": "Enables console domain, sends the messages collected so far to the client by means of the <code>messageAdded</code> notification."
},
{
"name": "disable",
"description": "Disables console domain, prevents further console messages from being sent to the client."
},
{
- "name": "clearConsoleMessages",
- "description": "Clears collected console messages."
+ "name": "clearMessages",
+ "description": "Clears console messages collected in the browser."
},
{
"name": "setMonitoringXHREnabled",
"parameters": [
{ "name": "enabled", "type": "boolean", "description": "Monitoring enabled state." }
],
- "description": "Toggles monitoring of XMLHttpRequest. If <code>true</code>, console will receive messages upon each XHR issued."
+ "description": "Toggles monitoring of XMLHttpRequest. If <code>true</code>, console will receive messages upon each XHR issued.",
+ "hidden": true
},
{
"name": "addInspectedNode",
@@ -407,14 +408,14 @@
"parameters": [
{ "name": "messageObj", "$ref": "ConsoleMessage", "description": "Console message that has been added." }
],
- "description": "Issued for each console message added."
+ "description": "Issued when new console message is added."
},
{
"name": "messageRepeatCountUpdated",
"parameters": [
{ "name": "count", "type": "integer", "description": "New repeat count value." }
],
- "description": "In case of subsequent message being equal to the previous one, only repeat count is being updated."
+ "description": "Issued when subsequent message(s) are equal to the previous one."
},
{
"name": "messagesCleared",
Modified: trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp (95281 => 95282)
--- trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp 2011-09-16 09:13:34 UTC (rev 95281)
+++ trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp 2011-09-16 09:29:14 UTC (rev 95282)
@@ -97,7 +97,7 @@
m_inspectorState->setBoolean(ConsoleAgentState::consoleMessagesEnabled, false);
}
-void InspectorConsoleAgent::clearConsoleMessages(ErrorString*)
+void InspectorConsoleAgent::clearMessages(ErrorString*)
{
m_consoleMessages.clear();
m_expiredConsoleMessageCount = 0;
@@ -111,7 +111,7 @@
void InspectorConsoleAgent::reset()
{
ErrorString error;
- clearConsoleMessages(&error);
+ clearMessages(&error);
m_times.clear();
m_counts.clear();
}
Modified: trunk/Source/WebCore/inspector/InspectorConsoleAgent.h (95281 => 95282)
--- trunk/Source/WebCore/inspector/InspectorConsoleAgent.h 2011-09-16 09:13:34 UTC (rev 95281)
+++ trunk/Source/WebCore/inspector/InspectorConsoleAgent.h 2011-09-16 09:29:14 UTC (rev 95282)
@@ -61,7 +61,7 @@
void enable(ErrorString*, int* consoleMessageExpireCount);
void disable(ErrorString*);
- void clearConsoleMessages(ErrorString* error);
+ void clearMessages(ErrorString*);
void reset();
void restore();
void setFrontend(InspectorFrontend*);
Modified: trunk/Source/WebCore/inspector/front-end/ConsoleModel.js (95281 => 95282)
--- trunk/Source/WebCore/inspector/front-end/ConsoleModel.js 2011-09-16 09:13:34 UTC (rev 95281)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleModel.js 2011-09-16 09:29:14 UTC (rev 95282)
@@ -88,7 +88,7 @@
requestClearMessages: function()
{
- ConsoleAgent.clearConsoleMessages();
+ ConsoleAgent.clearMessages();
this.clearMessages();
},
_______________________________________________ webkit-changes mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
