Title: [95356] trunk/Source/WebCore
Revision
95356
Author
commit-qu...@webkit.org
Date
2011-09-16 19:42:16 -0700 (Fri, 16 Sep 2011)

Log Message

Depend on harfbuzz for OS=Android as well
https://bugs.webkit.org/show_bug.cgi?id=68239

Like GTK, Android depends on harfbuzz as well, so reflect that in
the project file. Furthermore, fix a compile error in PopupListBox.cpp
by explicitly including ctype.h, as isspace otherwise won't be declared.

Patch by Peter Beverloo <pe...@chromium.org> on 2011-09-16
Reviewed by Steve Block.

* WebCore.gyp/WebCore.gyp:
* platform/chromium/PopupListBox.cpp:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (95355 => 95356)


--- trunk/Source/WebCore/ChangeLog	2011-09-17 02:40:27 UTC (rev 95355)
+++ trunk/Source/WebCore/ChangeLog	2011-09-17 02:42:16 UTC (rev 95356)
@@ -1,3 +1,17 @@
+2011-09-16  Peter Beverloo  <pe...@chromium.org>
+
+        Depend on harfbuzz for OS=Android as well
+        https://bugs.webkit.org/show_bug.cgi?id=68239
+
+        Like GTK, Android depends on harfbuzz as well, so reflect that in
+        the project file. Furthermore, fix a compile error in PopupListBox.cpp
+        by explicitly including ctype.h, as isspace otherwise won't be declared.
+
+        Reviewed by Steve Block.
+
+        * WebCore.gyp/WebCore.gyp:
+        * platform/chromium/PopupListBox.cpp:
+
 2011-09-16  Tony Chang  <t...@chromium.org>
 
         Rename flex-align values to match the spec

Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (95355 => 95356)


--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2011-09-17 02:40:27 UTC (rev 95355)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2011-09-17 02:42:16 UTC (rev 95356)
@@ -1376,6 +1376,8 @@
             ['include', 'platform/graphics/chromium/FontPlatformDataLinux\\.cpp$'],
             ['include', 'platform/graphics/chromium/SimpleFontDataLinux\\.cpp$'],
           ],
+        }],
+        ['toolkit_uses_gtk==1 or OS=="android"', {
           'dependencies': [
             '<(chromium_src_dir)/third_party/harfbuzz/harfbuzz.gyp:harfbuzz',
           ],

Modified: trunk/Source/WebCore/platform/chromium/PopupListBox.cpp (95355 => 95356)


--- trunk/Source/WebCore/platform/chromium/PopupListBox.cpp	2011-09-17 02:40:27 UTC (rev 95355)
+++ trunk/Source/WebCore/platform/chromium/PopupListBox.cpp	2011-09-17 02:42:16 UTC (rev 95356)
@@ -47,6 +47,7 @@
 #include "ScrollbarTheme.h"
 #include "StringTruncator.h"
 #include "TextRun.h"
+#include <ctype.h>
 #include <limits>
 #include <wtf/CurrentTime.h>
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to