Title: [95486] trunk/Source/WebCore
Revision
95486
Author
[email protected]
Date
2011-09-19 15:53:04 -0700 (Mon, 19 Sep 2011)

Log Message

Remove APPLICATION_CACHE_DYNAMIC_ENTRIES and associated code
https://bugs.webkit.org/show_bug.cgi?id=68407

Reviewed by Eric Seidel.

As discussed on webkit-dev, no one appears to be using this code.

* GNUmakefile.list.am:
* UseJSC.cmake:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDOMApplicationCacheCustom.cpp: Removed.

Modified Paths

Removed Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (95485 => 95486)


--- trunk/Source/WebCore/ChangeLog	2011-09-19 22:32:20 UTC (rev 95485)
+++ trunk/Source/WebCore/ChangeLog	2011-09-19 22:53:04 UTC (rev 95486)
@@ -1,3 +1,21 @@
+2011-09-19  Adam Barth  <[email protected]>
+
+        Remove APPLICATION_CACHE_DYNAMIC_ENTRIES and associated code
+        https://bugs.webkit.org/show_bug.cgi?id=68407
+
+        Reviewed by Eric Seidel.
+
+        As discussed on webkit-dev, no one appears to be using this code.
+
+        * GNUmakefile.list.am:
+        * UseJSC.cmake:
+        * WebCore.gypi:
+        * WebCore.pro:
+        * WebCore.vcproj/WebCore.vcproj:
+        * WebCore.xcodeproj/project.pbxproj:
+        * bindings/js/JSBindingsAllInOne.cpp:
+        * bindings/js/JSDOMApplicationCacheCustom.cpp: Removed.
+
 2011-09-19  Sheriff Bot  <[email protected]>
 
         Unreviewed, rolling out r95385 and r95457.

Modified: trunk/Source/WebCore/GNUmakefile.list.am (95485 => 95486)


--- trunk/Source/WebCore/GNUmakefile.list.am	2011-09-19 22:32:20 UTC (rev 95485)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2011-09-19 22:53:04 UTC (rev 95486)
@@ -685,7 +685,6 @@
 	Source/WebCore/bindings/js/JSCustomXPathNSResolver.h \
 	Source/WebCore/bindings/js/JSDictionary.cpp \
 	Source/WebCore/bindings/js/JSDictionary.h \
-	Source/WebCore/bindings/js/JSDOMApplicationCacheCustom.cpp \
 	Source/WebCore/bindings/js/JSDOMBinding.cpp \
 	Source/WebCore/bindings/js/JSDOMBinding.h \
 	Source/WebCore/bindings/js/JSDOMFormDataCustom.cpp \

Modified: trunk/Source/WebCore/UseJSC.cmake (95485 => 95486)


--- trunk/Source/WebCore/UseJSC.cmake	2011-09-19 22:32:20 UTC (rev 95485)
+++ trunk/Source/WebCore/UseJSC.cmake	2011-09-19 22:53:04 UTC (rev 95486)
@@ -211,12 +211,6 @@
     )
 ENDIF ()
 
-IF (ENABLE_OFFLINE_WEB_APPLICATIONS)
-    LIST(APPEND WebCore_SOURCES
-        bindings/js/JSDOMApplicationCacheCustom.cpp
-    )
-ENDIF ()
-
 IF (ENABLE_XPATH)
     LIST(APPEND WebCore_SOURCES
         bindings/js/JSCustomXPathNSResolver.cpp

Modified: trunk/Source/WebCore/WebCore.gypi (95485 => 95486)


--- trunk/Source/WebCore/WebCore.gypi	2011-09-19 22:32:20 UTC (rev 95485)
+++ trunk/Source/WebCore/WebCore.gypi	2011-09-19 22:53:04 UTC (rev 95486)
@@ -1794,7 +1794,6 @@
             'bindings/js/JSCustomXPathNSResolver.cpp',
             'bindings/js/JSCustomXPathNSResolver.h',
             'bindings/js/JSDictionary.cpp',
-            'bindings/js/JSDOMApplicationCacheCustom.cpp',
             'bindings/js/JSDOMBinding.cpp',
             'bindings/js/JSDOMFormDataCustom.cpp',
             'bindings/js/JSDOMGlobalObject.cpp',

Modified: trunk/Source/WebCore/WebCore.pro (95485 => 95486)


--- trunk/Source/WebCore/WebCore.pro	2011-09-19 22:32:20 UTC (rev 95485)
+++ trunk/Source/WebCore/WebCore.pro	2011-09-19 22:53:04 UTC (rev 95486)
@@ -3563,11 +3563,6 @@
     loader/appcache/ApplicationCacheResource.cpp \
     loader/appcache/DOMApplicationCache.cpp \
     loader/appcache/ManifestParser.cpp
-
-    !v8 {
-        SOURCES += \
-            bindings/js/JSDOMApplicationCacheCustom.cpp
-    }
 }
 
 contains(DEFINES, ENABLE_WEB_SOCKETS=1) {

Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (95485 => 95486)


--- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-09-19 22:32:20 UTC (rev 95485)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-09-19 22:53:04 UTC (rev 95486)
@@ -60201,58 +60201,6 @@
 					</FileConfiguration>
 				</File>
 				<File
-					RelativePath="..\bindings\js\JSDOMApplicationCacheCustom.cpp"
-					>
-					<FileConfiguration
-						Name="Debug|Win32"
-						ExcludedFromBuild="true"
-						>
-						<Tool
-							Name="VCCLCompilerTool"
-						/>
-					</FileConfiguration>
-					<FileConfiguration
-						Name="Release|Win32"
-						ExcludedFromBuild="true"
-						>
-						<Tool
-							Name="VCCLCompilerTool"
-						/>
-					</FileConfiguration>
-					<FileConfiguration
-						Name="Debug_Cairo_CFLite|Win32"
-						ExcludedFromBuild="true"
-						>
-						<Tool
-							Name="VCCLCompilerTool"
-						/>
-					</FileConfiguration>
-					<FileConfiguration
-						Name="Release_Cairo_CFLite|Win32"
-						ExcludedFromBuild="true"
-						>
-						<Tool
-							Name="VCCLCompilerTool"
-						/>
-					</FileConfiguration>
-					<FileConfiguration
-						Name="Debug_All|Win32"
-						ExcludedFromBuild="true"
-						>
-						<Tool
-							Name="VCCLCompilerTool"
-						/>
-					</FileConfiguration>
-					<FileConfiguration
-						Name="Production|Win32"
-						ExcludedFromBuild="true"
-						>
-						<Tool
-							Name="VCCLCompilerTool"
-						/>
-					</FileConfiguration>
-				</File>
-				<File
 					RelativePath="..\bindings\js\JSDOMBinding.cpp"
 					>
 					<FileConfiguration

Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (95485 => 95486)


--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2011-09-19 22:32:20 UTC (rev 95485)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2011-09-19 22:53:04 UTC (rev 95486)
@@ -479,7 +479,6 @@
 		1ABFE7530CD968D000FE4834 /* SQLTransaction.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1ABFE7520CD968D000FE4834 /* SQLTransaction.cpp */; };
 		1AC2260C0DB69F190089B669 /* JSDOMApplicationCache.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1AC2260A0DB69F190089B669 /* JSDOMApplicationCache.cpp */; };
 		1AC2260D0DB69F190089B669 /* JSDOMApplicationCache.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AC2260B0DB69F190089B669 /* JSDOMApplicationCache.h */; };
-		1AC226170DB69F740089B669 /* JSDOMApplicationCacheCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1AC226160DB69F740089B669 /* JSDOMApplicationCacheCustom.cpp */; };
 		1ACD1B630B029739007E5016 /* DOMCSSStyleDeclarationInternal.h in Copy Generated Headers */ = {isa = PBXBuildFile; fileRef = 85E711440AC5D5340053270F /* DOMCSSStyleDeclarationInternal.h */; };
 		1ACE53DF0A8D18810022947D /* JSDOMParser.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1ACE53DD0A8D18810022947D /* JSDOMParser.cpp */; };
 		1ACE53E00A8D18810022947D /* JSDOMParser.h in Headers */ = {isa = PBXBuildFile; fileRef = 1ACE53DE0A8D18810022947D /* JSDOMParser.h */; };
@@ -7009,7 +7008,6 @@
 		1ABFE7520CD968D000FE4834 /* SQLTransaction.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SQLTransaction.cpp; sourceTree = "<group>"; };
 		1AC2260A0DB69F190089B669 /* JSDOMApplicationCache.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSDOMApplicationCache.cpp; sourceTree = "<group>"; };
 		1AC2260B0DB69F190089B669 /* JSDOMApplicationCache.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSDOMApplicationCache.h; sourceTree = "<group>"; };
-		1AC226160DB69F740089B669 /* JSDOMApplicationCacheCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSDOMApplicationCacheCustom.cpp; sourceTree = "<group>"; };
 		1ACE53DD0A8D18810022947D /* JSDOMParser.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = JSDOMParser.cpp; sourceTree = "<group>"; };
 		1ACE53DE0A8D18810022947D /* JSDOMParser.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = JSDOMParser.h; sourceTree = "<group>"; };
 		1ACE53E10A8D18E70022947D /* DOMParser.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = DOMParser.cpp; sourceTree = "<group>"; };
@@ -18732,7 +18730,6 @@
 				893C47DE123EF4A9002B3D86 /* JSDirectoryEntryCustom.cpp */,
 				893C48201249535B002B3D86 /* JSDirectoryEntrySyncCustom.cpp */,
 				49C7BA8C1042F5B10009D447 /* JSDocumentCustom.cpp */,
-				1AC226160DB69F740089B669 /* JSDOMApplicationCacheCustom.cpp */,
 				2E0888E5114884E200AF4265 /* JSDOMFormDataCustom.cpp */,
 				22885E631301AE4C00526E68 /* JSDOMImplementationCustom.cpp */,
 				A9C6E6460D7465CA006442E9 /* JSDOMMimeTypeArrayCustom.cpp */,
@@ -24920,7 +24917,6 @@
 				1A494EDE0A123F4C00FDAFC1 /* JSDocumentFragment.cpp in Sources */,
 				65DF31F509D1CC60000BE325 /* JSDocumentType.cpp in Sources */,
 				1AC2260C0DB69F190089B669 /* JSDOMApplicationCache.cpp in Sources */,
-				1AC226170DB69F740089B669 /* JSDOMApplicationCacheCustom.cpp in Sources */,
 				93B70D6309EB0C7C009D8468 /* JSDOMBinding.cpp in Sources */,
 				BC60D7C00D29A46300B9918F /* JSDOMCoreException.cpp in Sources */,
 				898785A4122CA2A7003AABDA /* JSDOMFileSystem.cpp in Sources */,

Modified: trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp (95485 => 95486)


--- trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp	2011-09-19 22:32:20 UTC (rev 95485)
+++ trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp	2011-09-19 22:53:04 UTC (rev 95486)
@@ -52,7 +52,6 @@
 #include "JSCustomVoidCallback.cpp"
 #include "JSCustomXPathNSResolver.cpp"
 #include "JSDictionary.cpp"
-#include "JSDOMApplicationCacheCustom.cpp"
 #include "JSDOMBinding.cpp"
 #include "JSDOMFormDataCustom.cpp"
 #include "JSDOMGlobalObject.cpp"

Deleted: trunk/Source/WebCore/bindings/js/JSDOMApplicationCacheCustom.cpp (95485 => 95486)


--- trunk/Source/WebCore/bindings/js/JSDOMApplicationCacheCustom.cpp	2011-09-19 22:32:20 UTC (rev 95485)
+++ trunk/Source/WebCore/bindings/js/JSDOMApplicationCacheCustom.cpp	2011-09-19 22:53:04 UTC (rev 95486)
@@ -1,91 +0,0 @@
-/*
- * Copyright (C) 2008, 2009 Apple Inc. All Rights Reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
- */
-
-#include "config.h"
-
-#if ENABLE(OFFLINE_WEB_APPLICATIONS)
-
-#include "JSDOMApplicationCache.h"
-
-#include "DOMApplicationCache.h"
-#include "DOMWindow.h"
-#include "Event.h"
-#include "Frame.h"
-#include "FrameLoader.h"
-#include "JSDOMWindowCustom.h"
-#include "JSEvent.h"
-#include "JSEventListener.h"
-#include <wtf/text/AtomicString.h>
-
-using namespace JSC;
-
-namespace WebCore {
-
-#if ENABLE(APPLICATION_CACHE_DYNAMIC_ENTRIES)
-
-JSValue JSDOMApplicationCache::hasItem(ExecState* exec)
-{
-    Frame* frame = asJSDOMWindow(exec->dynamicGlobalObject())->impl()->frame();
-    if (!frame)
-        return jsUndefined();
-    const KURL& url = ""
-
-    ExceptionCode ec = 0;
-    bool result = impl()->hasItem(url, ec);
-    setDOMException(exec, ec);
-    return jsBoolean(result);
-}
-
-JSValue JSDOMApplicationCache::add(ExecState* exec)
-{
-    Frame* frame = asJSDOMWindow(exec->dynamicGlobalObject())->impl()->frame();
-    if (!frame)
-        return jsUndefined();
-    const KURL& url = ""
-
-    ExceptionCode ec = 0;
-    impl()->add(url, ec);
-    setDOMException(exec, ec);
-    return jsUndefined();
-}
-
-JSValue JSDOMApplicationCache::remove(ExecState* exec)
-{
-    Frame* frame = asJSDOMWindow(exec->dynamicGlobalObject())->impl()->frame();
-    if (!frame)
-        return jsUndefined();
-    const KURL& url = ""
-
-    ExceptionCode ec = 0;
-    impl()->remove(url, ec);
-    setDOMException(exec, ec);
-    return jsUndefined();
-}
-
-#endif // ENABLE(APPLICATION_CACHE_DYNAMIC_ENTRIES)
-
-} // namespace WebCore
-
-#endif // ENABLE(OFFLINE_WEB_APPLICATIONS)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to