Modified: trunk/Source/_javascript_Core/ChangeLog (95504 => 95505)
--- trunk/Source/_javascript_Core/ChangeLog 2011-09-20 01:41:42 UTC (rev 95504)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-09-20 01:44:56 UTC (rev 95505)
@@ -1,5 +1,12 @@
2011-09-19 Gavin Barraclough <[email protected]>
+ Errrk, missed stylebot comments in last commit.
+
+ * runtime/StringPrototype.cpp:
+ (JSC::stringProtoFuncSplit):
+
+2011-09-19 Gavin Barraclough <[email protected]>
+
String#split is buggy
https://bugs.webkit.org/show_bug.cgi?id=68348
Modified: trunk/Source/_javascript_Core/runtime/StringPrototype.cpp (95504 => 95505)
--- trunk/Source/_javascript_Core/runtime/StringPrototype.cpp 2011-09-20 01:41:42 UTC (rev 95504)
+++ trunk/Source/_javascript_Core/runtime/StringPrototype.cpp 2011-09-20 01:44:56 UTC (rev 95505)
@@ -830,10 +830,10 @@
// 10. If separator is undefined, then
if (separatorValue.isUndefined()) {
- // a. Call the [[DefineOwnProperty]] internal method of A with arguments "0",
- // Property Descriptor {[[Value]]: S, [[Writable]]: true, [[Enumerable]]: true, [[Configurable]]: true}, and false.
+ // a. Call the [[DefineOwnProperty]] internal method of A with arguments "0",
+ // Property Descriptor {[[Value]]: S, [[Writable]]: true, [[Enumerable]]: true, [[Configurable]]: true}, and false.
result->put(exec, 0, jsStringWithReuse(exec, thisValue, input));
- // b. Return A.
+ // b. Return A.
return JSValue::encode(result);
}
@@ -937,9 +937,9 @@
// Zero limt/input length handled in steps 9/11 respectively, above.
ASSERT(limit);
- do
+ do {
result->put(exec, position, jsSingleCharacterSubstring(exec, input, position));
- while (++position < limit);
+ } while (++position < limit);
return JSValue::encode(result);
}
