Title: [95556] trunk/Source/WebKit/efl
Revision
95556
Author
[email protected]
Date
2011-09-20 11:09:22 -0700 (Tue, 20 Sep 2011)

Log Message

[EFL] Call FrameLoader::detachFromParent() when destroying a frame.
https://bugs.webkit.org/show_bug.cgi?id=66855

Patch by Raphael Kubo da Costa <[email protected]> on 2011-09-20
Reviewed by Antonio Gomes.

Most other ports call this method somewhere when the frame is being
removed, as it performs some destruction calls which, in our case, at
least makes sure onunload events get delivered properly in
fast/frames/iframe-reparenting-adopt-node.html.

* ewk/ewk_frame.cpp:
(_ewk_frame_smart_del): Call FrameLoader::detachFromParent()

Modified Paths

Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (95555 => 95556)


--- trunk/Source/WebKit/efl/ChangeLog	2011-09-20 18:02:33 UTC (rev 95555)
+++ trunk/Source/WebKit/efl/ChangeLog	2011-09-20 18:09:22 UTC (rev 95556)
@@ -1,3 +1,18 @@
+2011-09-20  Raphael Kubo da Costa  <[email protected]>
+
+        [EFL] Call FrameLoader::detachFromParent() when destroying a frame.
+        https://bugs.webkit.org/show_bug.cgi?id=66855
+
+        Reviewed by Antonio Gomes.
+
+        Most other ports call this method somewhere when the frame is being
+        removed, as it performs some destruction calls which, in our case, at
+        least makes sure onunload events get delivered properly in
+        fast/frames/iframe-reparenting-adopt-node.html.
+
+        * ewk/ewk_frame.cpp:
+        (_ewk_frame_smart_del): Call FrameLoader::detachFromParent()
+
 2011-09-17  Mihai Parparita  <[email protected]>
 
         FrameLoaderClient BackForwardList-related methods are unsued

Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.cpp (95555 => 95556)


--- trunk/Source/WebKit/efl/ewk/ewk_frame.cpp	2011-09-20 18:02:33 UTC (rev 95555)
+++ trunk/Source/WebKit/efl/ewk/ewk_frame.cpp	2011-09-20 18:09:22 UTC (rev 95556)
@@ -242,6 +242,7 @@
         if (sd->frame) {
             WebCore::FrameLoaderClientEfl *flc = _ewk_frame_loader_efl_get(sd->frame);
             flc->setWebFrame(0);
+            sd->frame->loader()->detachFromParent();
             sd->frame->loader()->cancelAndClear();
             sd->frame = 0;
         }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to