Title: [95629] trunk/Tools
- Revision
- 95629
- Author
- [email protected]
- Date
- 2011-09-21 07:58:15 -0700 (Wed, 21 Sep 2011)
Log Message
garden-o-matic command should explain that it is starting a local server
https://bugs.webkit.org/show_bug.cgi?id=68486
Reviewed by Dimitri Glazkov.
In the user study, both participants didn't understand why the
garden-o-matic command appeared to hang. This patch adds an
explaination of what's going on. It also adds a confirmation prompt
before launching the browser to give the user a chance to read the
text. If that's too much of a speed bump, we can iterate.
* Scripts/webkitpy/tool/commands/gardenomatic.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (95628 => 95629)
--- trunk/Tools/ChangeLog 2011-09-21 14:48:34 UTC (rev 95628)
+++ trunk/Tools/ChangeLog 2011-09-21 14:58:15 UTC (rev 95629)
@@ -1,3 +1,18 @@
+2011-09-21 Adam Barth <[email protected]>
+
+ garden-o-matic command should explain that it is starting a local server
+ https://bugs.webkit.org/show_bug.cgi?id=68486
+
+ Reviewed by Dimitri Glazkov.
+
+ In the user study, both participants didn't understand why the
+ garden-o-matic command appeared to hang. This patch adds an
+ explaination of what's going on. It also adds a confirmation prompt
+ before launching the browser to give the user a chance to read the
+ text. If that's too much of a speed bump, we can iterate.
+
+ * Scripts/webkitpy/tool/commands/gardenomatic.py:
+
2011-09-21 Chang Shu <[email protected]>
[Qt] Implement KeyDown function for WebKit2 EventSender.
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py (95628 => 95629)
--- trunk/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py 2011-09-21 14:48:34 UTC (rev 95628)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py 2011-09-21 14:58:15 UTC (rev 95629)
@@ -33,6 +33,10 @@
url = ""
def execute(self, options, args, tool):
- self._tool.user.open_url(self.url)
+ print "This command runs a local HTTP server that changes your working copy"
+ print "based on the actions you take in the web-based UI."
+ if tool.user.confirm("Open the web-based UI before starting the local server?"):
+ self._tool.user.open_url(self.url)
httpd = GardeningHTTPServer(httpd_port=8127, config={'tool': tool})
+ print "Local HTTP server started."
httpd.serve_forever()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
