Title: [95656] trunk/Source/WebKit/efl
- Revision
- 95656
- Author
- [email protected]
- Date
- 2011-09-21 11:59:29 -0700 (Wed, 21 Sep 2011)
Log Message
[EFL] Don't try to free user-provided list
https://bugs.webkit.org/show_bug.cgi?id=68356
Reviewed by Antonio Gomes.
A coding-style cleanup revealed that we were using EINA_LIST_FREE in a
wrong manner. If we intended to free the data, we should call free()
(or whatever function is required to destroy it). However not only did
it use the wrong EFL api but it also introduced a change in behavior,
freeing user-provided data.
* ewk/ewk_frame.cpp:
(ewk_frame_feed_touch_event): do not free user-provided data.
Modified Paths
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (95655 => 95656)
--- trunk/Source/WebKit/efl/ChangeLog 2011-09-21 18:48:16 UTC (rev 95655)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-09-21 18:59:29 UTC (rev 95656)
@@ -1,3 +1,19 @@
+2011-09-21 Lucas De Marchi <[email protected]>
+
+ [EFL] Don't try to free user-provided list
+ https://bugs.webkit.org/show_bug.cgi?id=68356
+
+ Reviewed by Antonio Gomes.
+
+ A coding-style cleanup revealed that we were using EINA_LIST_FREE in a
+ wrong manner. If we intended to free the data, we should call free()
+ (or whatever function is required to destroy it). However not only did
+ it use the wrong EFL api but it also introduced a change in behavior,
+ freeing user-provided data.
+
+ * ewk/ewk_frame.cpp:
+ (ewk_frame_feed_touch_event): do not free user-provided data.
+
2011-09-21 Gyuyoung Kim <[email protected]>
[EFL] Fix alphabetical sorting problem
Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.cpp (95655 => 95656)
--- trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2011-09-21 18:48:16 UTC (rev 95655)
+++ trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2011-09-21 18:59:29 UTC (rev 95656)
@@ -931,11 +931,8 @@
EINA_SAFETY_ON_NULL_RETURN_VAL(points, EINA_FALSE);
EWK_FRAME_SD_GET(o, sd);
- if (!sd || !sd->frame || !ewk_view_need_touch_events_get(sd->view)) {
- void *point;
- EINA_LIST_FREE(points, point);
+ if (!sd || !sd->frame || !ewk_view_need_touch_events_get(sd->view))
return EINA_FALSE;
- }
Evas_Coord x, y;
evas_object_geometry_get(sd->view, &x, &y, 0, 0);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
