Title: [95776] trunk/Source/WebCore
- Revision
- 95776
- Author
- [email protected]
- Date
- 2011-09-22 19:41:55 -0700 (Thu, 22 Sep 2011)
Log Message
Remove unused members from LayerChromium.
These members are never set, and never used.
Other members that are set but not used have been left (we may use them
later, e.g. m_opaque).
https://bugs.webkit.org/show_bug.cgi?id=68297
Patch by Antoine Labour <[email protected]> on 2011-09-22
Reviewed by James Robinson.
No functional change, no new test needed.
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
* platform/graphics/chromium/LayerChromium.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (95775 => 95776)
--- trunk/Source/WebCore/ChangeLog 2011-09-23 02:40:16 UTC (rev 95775)
+++ trunk/Source/WebCore/ChangeLog 2011-09-23 02:41:55 UTC (rev 95776)
@@ -1,3 +1,19 @@
+2011-09-22 Antoine Labour <[email protected]>
+
+ Remove unused members from LayerChromium.
+ These members are never set, and never used.
+ Other members that are set but not used have been left (we may use them
+ later, e.g. m_opaque).
+ https://bugs.webkit.org/show_bug.cgi?id=68297
+
+ Reviewed by James Robinson.
+
+ No functional change, no new test needed.
+
+ * platform/graphics/chromium/LayerChromium.cpp:
+ (WebCore::LayerChromium::LayerChromium):
+ * platform/graphics/chromium/LayerChromium.h:
+
2011-09-22 Tom Sepez <[email protected]>
Make XSSAuditor extract meaningful snippet from script blocks for comparison
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp (95775 => 95776)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp 2011-09-23 02:40:16 UTC (rev 95775)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp 2011-09-23 02:41:55 UTC (rev 95776)
@@ -64,14 +64,9 @@
, m_backgroundColor(0, 0, 0, 0)
, m_debugBorderWidth(0)
, m_opacity(1.0)
- , m_zPosition(0.0)
, m_anchorPointZ(0)
- , m_clearsContext(false)
- , m_hidden(false)
, m_masksToBounds(false)
, m_opaque(true)
- , m_geometryFlipped(false)
- , m_needsDisplayOnBoundsChange(false)
, m_doubleSided(true)
, m_usesLayerScissor(false)
, m_isNonCompositedContent(false)
@@ -222,15 +217,6 @@
setNeedsCommit();
}
-void LayerChromium::setFrame(const FloatRect& rect)
-{
- if (rect == m_frame)
- return;
-
- m_frame = rect;
- setNeedsDisplay(FloatRect(0, 0, bounds().width(), bounds().height()));
-}
-
const LayerChromium* LayerChromium::rootLayer() const
{
const LayerChromium* layer = this;
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h (95775 => 95776)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h 2011-09-23 02:40:16 UTC (rev 95775)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h 2011-09-23 02:41:55 UTC (rev 95776)
@@ -96,15 +96,6 @@
const IntSize& bounds() const { return m_bounds; }
virtual IntSize contentBounds() const { return bounds(); }
- void setClearsContext(bool clears) { m_clearsContext = clears; setNeedsCommit(); }
- bool clearsContext() const { return m_clearsContext; }
-
- void setFrame(const FloatRect&);
- FloatRect frame() const { return m_frame; }
-
- void setHidden(bool hidden) { m_hidden = hidden; setNeedsCommit(); }
- bool isHidden() const { return m_hidden; }
-
void setMasksToBounds(bool masksToBounds) { m_masksToBounds = masksToBounds; }
bool masksToBounds() const { return m_masksToBounds; }
@@ -119,8 +110,6 @@
const FloatRect& dirtyRect() const { return m_dirtyRect; }
void resetNeedsDisplay();
- void setNeedsDisplayOnBoundsChange(bool needsDisplay) { m_needsDisplayOnBoundsChange = needsDisplay; }
-
void setOpacity(float opacity) { m_opacity = opacity; setNeedsCommit(); }
float opacity() const { return m_opacity; }
@@ -130,9 +119,6 @@
void setPosition(const FloatPoint& position) { m_position = position; setNeedsCommit(); }
FloatPoint position() const { return m_position; }
- void setZPosition(float zPosition) { m_zPosition = zPosition; setNeedsCommit(); }
- float zPosition() const { return m_zPosition; }
-
void setSublayerTransform(const TransformationMatrix& transform) { m_sublayerTransform = transform; setNeedsCommit(); }
const TransformationMatrix& sublayerTransform() const { return m_sublayerTransform; }
@@ -148,10 +134,6 @@
bool doubleSided() const { return m_doubleSided; }
void setDoubleSided(bool doubleSided) { m_doubleSided = doubleSided; setNeedsCommit(); }
- // FIXME: This setting is currently ignored.
- void setGeometryFlipped(bool flipped) { m_geometryFlipped = flipped; setNeedsCommit(); }
- bool geometryFlipped() const { return m_geometryFlipped; }
-
bool preserves3D() const { return m_delegate && m_delegate->preserves3D(); }
void setUsesLayerScissor(bool usesLayerScissor) { m_usesLayerScissor = usesLayerScissor; }
@@ -261,14 +243,9 @@
Color m_debugBorderColor;
float m_debugBorderWidth;
float m_opacity;
- float m_zPosition;
float m_anchorPointZ;
- bool m_clearsContext;
- bool m_hidden;
bool m_masksToBounds;
bool m_opaque;
- bool m_geometryFlipped;
- bool m_needsDisplayOnBoundsChange;
bool m_doubleSided;
bool m_usesLayerScissor;
bool m_isNonCompositedContent;
@@ -276,8 +253,6 @@
TransformationMatrix m_transform;
TransformationMatrix m_sublayerTransform;
- FloatRect m_frame;
-
// Replica layer used for reflections.
RefPtr<LayerChromium> m_replicaLayer;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
