Title: [95861] trunk/Source/WebKit/chromium
- Revision
- 95861
- Author
- [email protected]
- Date
- 2011-09-23 14:48:02 -0700 (Fri, 23 Sep 2011)
Log Message
occasional crash in Chromium in dispatching keyEvent
https://bugs.webkit.org/show_bug.cgi?id=67941
Patch by Scott Graham <[email protected]> on 2011-09-23
Reviewed by Darin Fisher.
Use focusedWebCoreNode() to handle null document for frame when
retrieving focused node in handling keyEvent.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::keyEvent):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (95860 => 95861)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-09-23 21:39:52 UTC (rev 95860)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-09-23 21:48:02 UTC (rev 95861)
@@ -1,3 +1,16 @@
+2011-09-23 Scott Graham <[email protected]>
+
+ occasional crash in Chromium in dispatching keyEvent
+ https://bugs.webkit.org/show_bug.cgi?id=67941
+
+ Reviewed by Darin Fisher.
+
+ Use focusedWebCoreNode() to handle null document for frame when
+ retrieving focused node in handling keyEvent.
+
+ * src/WebViewImpl.cpp:
+ (WebKit::WebViewImpl::keyEvent):
+
2011-09-23 Fady Samuel <[email protected]>
Refactor paintOverhangAreas to allow non-Mac Chromium platforms to reuse code
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (95860 => 95861)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-09-23 21:39:52 UTC (rev 95860)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-09-23 21:48:02 UTC (rev 95861)
@@ -654,7 +654,7 @@
if (WebInputEvent::RawKeyDown == event.type) {
// Suppress the next keypress event unless the focused node is a plug-in node.
// (Flash needs these keypress events to handle non-US keyboards.)
- Node* node = frame->document()->focusedNode();
+ Node* node = focusedWebCoreNode();
if (!node || !node->renderer() || !node->renderer()->isEmbeddedObject())
m_suppressNextKeypressEvent = true;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
