Title: [95982] trunk/Source/WebKit2
Revision
95982
Author
[email protected]
Date
2011-09-26 12:58:00 -0700 (Mon, 26 Sep 2011)

Log Message

Remove an old DrawingAreaProxy::paint member function
https://bugs.webkit.org/show_bug.cgi?id=68825

Reviewed by Dan Bernstein.

* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
* UIProcess/TiledDrawingAreaProxy.cpp:
* UIProcess/TiledDrawingAreaProxy.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (95981 => 95982)


--- trunk/Source/WebKit2/ChangeLog	2011-09-26 19:57:56 UTC (rev 95981)
+++ trunk/Source/WebKit2/ChangeLog	2011-09-26 19:58:00 UTC (rev 95982)
@@ -1,3 +1,16 @@
+2011-09-26  Anders Carlsson  <[email protected]>
+
+        Remove an old DrawingAreaProxy::paint member function
+        https://bugs.webkit.org/show_bug.cgi?id=68825
+
+        Reviewed by Dan Bernstein.
+
+        * UIProcess/DrawingAreaProxy.h:
+        * UIProcess/DrawingAreaProxyImpl.cpp:
+        * UIProcess/DrawingAreaProxyImpl.h:
+        * UIProcess/TiledDrawingAreaProxy.cpp:
+        * UIProcess/TiledDrawingAreaProxy.h:
+
 2011-09-26  Jer Noble  <[email protected]>
 
         White flash when entering full-screen using element.webkitRequestFullScreen()

Modified: trunk/Source/WebKit2/UIProcess/DrawingAreaProxy.h (95981 => 95982)


--- trunk/Source/WebKit2/UIProcess/DrawingAreaProxy.h	2011-09-26 19:57:56 UTC (rev 95981)
+++ trunk/Source/WebKit2/UIProcess/DrawingAreaProxy.h	2011-09-26 19:58:00 UTC (rev 95982)
@@ -54,16 +54,6 @@
 class UpdateInfo;
 class WebPageProxy;
 
-#if PLATFORM(MAC)
-typedef CGContextRef PlatformDrawingContext;
-#elif PLATFORM(WIN)
-typedef HDC PlatformDrawingContext;
-#elif PLATFORM(QT)
-typedef QPainter* PlatformDrawingContext;
-#elif PLATFORM(GTK)
-typedef cairo_t* PlatformDrawingContext;
-#endif
-
 class DrawingAreaProxy {
     WTF_MAKE_NONCOPYABLE(DrawingAreaProxy);
 
@@ -74,9 +64,6 @@
 
     void didReceiveDrawingAreaProxyMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*);
 
-    // Returns true if painting was successful, false otherwise.
-    virtual bool paint(const WebCore::IntRect&, PlatformDrawingContext) = 0;
-
     virtual void deviceScaleFactorDidChange() = 0;
 
     // FIXME: These should be pure virtual.

Modified: trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp (95981 => 95982)


--- trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp	2011-09-26 19:57:56 UTC (rev 95981)
+++ trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp	2011-09-26 19:58:00 UTC (rev 95982)
@@ -106,12 +106,6 @@
     discardBackingStoreSoon();
 }
 
-bool DrawingAreaProxyImpl::paint(const WebCore::IntRect&, PlatformDrawingContext)
-{
-    ASSERT_NOT_REACHED();
-    return false;
-}
-
 void DrawingAreaProxyImpl::sizeDidChange()
 {
     backingStoreStateDidChange(RespondImmediately);

Modified: trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h (95981 => 95982)


--- trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h	2011-09-26 19:57:56 UTC (rev 95981)
+++ trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h	2011-09-26 19:58:00 UTC (rev 95982)
@@ -50,7 +50,6 @@
     explicit DrawingAreaProxyImpl(WebPageProxy*);
 
     // DrawingAreaProxy
-    virtual bool paint(const WebCore::IntRect&, PlatformDrawingContext);
     virtual void sizeDidChange();
     virtual void deviceScaleFactorDidChange();
     virtual void visibilityDidChange();

Modified: trunk/Source/WebKit2/UIProcess/TiledDrawingAreaProxy.cpp (95981 => 95982)


--- trunk/Source/WebKit2/UIProcess/TiledDrawingAreaProxy.cpp	2011-09-26 19:57:56 UTC (rev 95981)
+++ trunk/Source/WebKit2/UIProcess/TiledDrawingAreaProxy.cpp	2011-09-26 19:58:00 UTC (rev 95982)
@@ -116,13 +116,6 @@
     // FIXME: We should request a full repaint here if needed.
 }
 
-bool TiledDrawingAreaProxy::paint(const WebCore::IntRect& rect, PlatformDrawingContext context)
-{
-    notImplemented();
-    return false;
-}
-
-
 } // namespace WebKit
 
 #endif

Modified: trunk/Source/WebKit2/UIProcess/TiledDrawingAreaProxy.h (95981 => 95982)


--- trunk/Source/WebKit2/UIProcess/TiledDrawingAreaProxy.h	2011-09-26 19:57:56 UTC (rev 95981)
+++ trunk/Source/WebKit2/UIProcess/TiledDrawingAreaProxy.h	2011-09-26 19:58:00 UTC (rev 95982)
@@ -85,7 +85,6 @@
     void updateWebView(const Vector<WebCore::IntRect>& paintedArea);
 
     // DrawingAreaProxy
-    virtual bool paint(const WebCore::IntRect&, PlatformDrawingContext);
     virtual void sizeDidChange();
     virtual void deviceScaleFactorDidChange();
     virtual void setPageIsVisible(bool isVisible);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to