Title: [96055] trunk/Tools
- Revision
- 96055
- Author
- dglaz...@chromium.org
- Date
- 2011-09-26 17:52:19 -0700 (Mon, 26 Sep 2011)
Log Message
garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
https://bugs.webkit.org/show_bug.cgi?id=68841
Reviewed by Adam Barth.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js (96054 => 96055)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2011-09-27 00:43:02 UTC (rev 96054)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2011-09-27 00:52:19 UTC (rev 96055)
@@ -103,7 +103,7 @@
equal(testFailures.tagName, 'LI');
equal(testFailures.innerHTML,
'<div class="how">' +
- '<time class="relative">Just now</time>' +
+ '<time class="relative"></time>' +
'<table class="failures">' +
'<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
'<tbody><tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr></tbody>' +
@@ -124,7 +124,7 @@
equal(testFailures.index(), 0);
equal(testFailures.innerHTML,
'<div class="how">' +
- '<time class="relative">Just now</time>' +
+ '<time class="relative"></time>' +
'<table class="failures">' +
'<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
'<tbody><tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr></tbody>' +
@@ -148,7 +148,7 @@
testFailures.addFailureAnalysis({testName: 'test'});
equal(testFailures.innerHTML,
'<div class="how">' +
- '<time class="relative">Just now</time>' +
+ '<time class="relative"></time>' +
'<table class="failures">' +
'<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
'<tbody><tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr></tbody>' +
@@ -309,7 +309,7 @@
testFailures.addFailureAnalysis({testName: 'path/another/test.html', resultNodesByBuilder: {}});
equal(testFailures.innerHTML,
'<div class="how">' +
- '<time class="relative">Just now</time>' +
+ '<time class="relative"></time>' +
'<table class="failures">' +
'<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
'<tbody><tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr></tbody>' +
@@ -337,7 +337,7 @@
builderFailing.setFailingBuilders(['WebKit Linux', 'Webkit Vista']);
equal(builderFailing.innerHTML,
'<div class="how">' +
- '<time class="relative">Just now</time>' +
+ '<time class="relative"></time>' +
'</div>' +
'<div class="what">' +
'<div class="problem">Build Failed:' +
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js (96054 => 96055)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js 2011-09-27 00:43:02 UTC (rev 96054)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js 2011-09-27 00:52:19 UTC (rev 96055)
@@ -114,7 +114,6 @@
ui.RelativeTime = base.extends('time', {
init: function()
{
- this.setDate(new Date());
this.className = 'relative';
},
date: function()
@@ -123,12 +122,12 @@
},
update: function()
{
- this.textContent = base.relativizeTime(this._date);
+ this.textContent = this._date ? base.relativizeTime(this._date) : '';
},
setDate: function(date)
{
this._date = date;
- this.textContent = base.relativizeTime(date);
+ this.update();
}
});
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js (96054 => 96055)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js 2011-09-27 00:43:02 UTC (rev 96054)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js 2011-09-27 00:52:19 UTC (rev 96055)
@@ -111,7 +111,7 @@
'setDate',
'update',
]);
- equal(time.outerHTML, '<time class="relative">Just now</time>');
+ equal(time.outerHTML, '<time class="relative"></time>');
var tenMinutesAgo = new Date();
tenMinutesAgo.setMinutes(tenMinutesAgo.getMinutes() - 10);
time.setDate(tenMinutesAgo);
Modified: trunk/Tools/ChangeLog (96054 => 96055)
--- trunk/Tools/ChangeLog 2011-09-27 00:43:02 UTC (rev 96054)
+++ trunk/Tools/ChangeLog 2011-09-27 00:52:19 UTC (rev 96055)
@@ -1,3 +1,14 @@
+2011-09-26 Dimitri Glazkov <dglaz...@chromium.org>
+
+ garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
+ https://bugs.webkit.org/show_bug.cgi?id=68841
+
+ Reviewed by Adam Barth.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
+
2011-09-26 David Levin <le...@chromium.org>
watchlist: Add parsing for definition section.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
