Title: [96079] trunk/Source/WebKit2
Revision
96079
Author
[email protected]
Date
2011-09-27 00:55:09 -0700 (Tue, 27 Sep 2011)

Log Message

[Qt][WK2] Mark FINAL properties which can't be overridden by a subclass.
https://bugs.webkit.org/show_bug.cgi?id=68848

Reviewed by Andreas Kling.

The presence of the FINAL attribute indicates that the property will not be
overridden by a derived class. This can be used for performance optimizations
by QML.

* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qtouchwebview.h:
* UIProcess/API/qt/qwebnavigationcontroller.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (96078 => 96079)


--- trunk/Source/WebKit2/ChangeLog	2011-09-27 07:34:16 UTC (rev 96078)
+++ trunk/Source/WebKit2/ChangeLog	2011-09-27 07:55:09 UTC (rev 96079)
@@ -1,3 +1,19 @@
+2011-09-27  Alexis Menard  <[email protected]>
+
+        [Qt][WK2] Mark FINAL properties which can't be overridden by a subclass.
+        https://bugs.webkit.org/show_bug.cgi?id=68848
+
+        Reviewed by Andreas Kling.
+
+        The presence of the FINAL attribute indicates that the property will not be 
+        overridden by a derived class. This can be used for performance optimizations
+        by QML.
+
+        * UIProcess/API/qt/qdesktopwebview.h:
+        * UIProcess/API/qt/qtouchwebpage.h:
+        * UIProcess/API/qt/qtouchwebview.h:
+        * UIProcess/API/qt/qwebnavigationcontroller.h:
+
 2011-09-26  Caio Marcelo de Oliveira Filho  <[email protected]>
 
         [Qt] Fix WK2 build after r96014

Modified: trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h (96078 => 96079)


--- trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h	2011-09-27 07:34:16 UTC (rev 96078)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h	2011-09-27 07:55:09 UTC (rev 96079)
@@ -52,7 +52,7 @@
     Q_PROPERTY(QString title READ title NOTIFY titleChanged)
     Q_PROPERTY(QUrl url READ url NOTIFY urlChanged)
     Q_PROPERTY(int loadProgress READ loadProgress NOTIFY loadProgressChanged)
-    Q_PROPERTY(QWebNavigationController* navigation READ navigationController CONSTANT)
+    Q_PROPERTY(QWebNavigationController* navigation READ navigationController CONSTANT FINAL)
     Q_ENUMS(NavigationPolicy)
     Q_ENUMS(ErrorType)
 public:

Modified: trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h (96078 => 96079)


--- trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h	2011-09-27 07:34:16 UTC (rev 96078)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h	2011-09-27 07:55:09 UTC (rev 96079)
@@ -40,7 +40,7 @@
     Q_PROPERTY(QString title READ title NOTIFY titleChanged)
     Q_PROPERTY(QUrl url READ url NOTIFY urlChanged)
     Q_PROPERTY(int loadProgress READ loadProgress NOTIFY loadProgressChanged)
-    Q_PROPERTY(QWebNavigationController* navigation READ navigationController CONSTANT)
+    Q_PROPERTY(QWebNavigationController* navigation READ navigationController CONSTANT FINAL)
     Q_ENUMS(ErrorType)
 public:
     enum ErrorType {

Modified: trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebview.h (96078 => 96079)


--- trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebview.h	2011-09-27 07:34:16 UTC (rev 96078)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebview.h	2011-09-27 07:55:09 UTC (rev 96079)
@@ -35,7 +35,7 @@
 class QWEBKIT_EXPORT QTouchWebView : public QSGItem
 {
     Q_OBJECT
-    Q_PROPERTY(QTouchWebPage* page READ page CONSTANT)
+    Q_PROPERTY(QTouchWebPage* page READ page CONSTANT FINAL)
 
 public:
     QTouchWebView(QSGItem* parent = 0);

Modified: trunk/Source/WebKit2/UIProcess/API/qt/qwebnavigationcontroller.h (96078 => 96079)


--- trunk/Source/WebKit2/UIProcess/API/qt/qwebnavigationcontroller.h	2011-09-27 07:34:16 UTC (rev 96078)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qwebnavigationcontroller.h	2011-09-27 07:55:09 UTC (rev 96079)
@@ -35,10 +35,10 @@
 
 class QWEBKIT_EXPORT QWebNavigationController : public QObject {
     Q_OBJECT
-    Q_PROPERTY(QAction* backAction READ backAction CONSTANT)
-    Q_PROPERTY(QAction* forwardAction READ forwardAction CONSTANT)
-    Q_PROPERTY(QAction* stopAction READ stopAction CONSTANT)
-    Q_PROPERTY(QAction* reloadAction READ reloadAction CONSTANT)
+    Q_PROPERTY(QAction* backAction READ backAction CONSTANT FINAL)
+    Q_PROPERTY(QAction* forwardAction READ forwardAction CONSTANT FINAL)
+    Q_PROPERTY(QAction* stopAction READ stopAction CONSTANT FINAL)
+    Q_PROPERTY(QAction* reloadAction READ reloadAction CONSTANT FINAL)
 public:
     QWebNavigationController(QtWebPageProxy*);
     ~QWebNavigationController();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to