Title: [96174] trunk/LayoutTests
Revision
96174
Author
[email protected]
Date
2011-09-27 18:01:59 -0700 (Tue, 27 Sep 2011)

Log Message

http/tests/navigation/anchor-basic.html is flaky on Snow Leopard Release Bot
https://bugs.webkit.org/show_bug.cgi?id=34222

Reviewed by Ryosuke Niwa.

Add waitUntilDone/notifyDone to eliminate flakiness on mac. Without it, the img onload handler
doesn't always run. Also reduce the multipart timeout (should help to unblock other http requests).

* http/tests/multipart/stop-crash-expected.txt:
* http/tests/multipart/stop-crash.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (96173 => 96174)


--- trunk/LayoutTests/ChangeLog	2011-09-28 00:25:01 UTC (rev 96173)
+++ trunk/LayoutTests/ChangeLog	2011-09-28 01:01:59 UTC (rev 96174)
@@ -1,3 +1,16 @@
+2011-09-27  Tony Chang  <[email protected]>
+
+        http/tests/navigation/anchor-basic.html is flaky on Snow Leopard Release Bot
+        https://bugs.webkit.org/show_bug.cgi?id=34222
+
+        Reviewed by Ryosuke Niwa.
+
+        Add waitUntilDone/notifyDone to eliminate flakiness on mac. Without it, the img onload handler
+        doesn't always run. Also reduce the multipart timeout (should help to unblock other http requests).
+
+        * http/tests/multipart/stop-crash-expected.txt:
+        * http/tests/multipart/stop-crash.html:
+
 2011-09-27  Mihai Parparita  <[email protected]>
 
         Chromium baselines for fast/multicol/float-paginate-empty-lines.html

Modified: trunk/LayoutTests/http/tests/multipart/stop-crash-expected.txt (96173 => 96174)


--- trunk/LayoutTests/http/tests/multipart/stop-crash-expected.txt	2011-09-28 00:25:01 UTC (rev 96173)
+++ trunk/LayoutTests/http/tests/multipart/stop-crash-expected.txt	2011-09-28 01:01:59 UTC (rev 96174)
@@ -3,3 +3,4 @@
 If WebKit does not assert or crash after the test, then it passed.
 
 
+PASS

Modified: trunk/LayoutTests/http/tests/multipart/stop-crash.html (96173 => 96174)


--- trunk/LayoutTests/http/tests/multipart/stop-crash.html	2011-09-28 00:25:01 UTC (rev 96173)
+++ trunk/LayoutTests/http/tests/multipart/stop-crash.html	2011-09-28 01:01:59 UTC (rev 96174)
@@ -1,12 +1,17 @@
 <html>
 <head>
     <script>
-        if (window.layoutTestController)
+        if (window.layoutTestController) {
             layoutTestController.dumpAsText();
+            layoutTestController.waitUntilDone();
+        }
 
         function firstPartLoaded()
         {
             window.stop();
+            document.getElementById("results").innerHTML = "PASS";
+            if (window.layoutTestController)
+                layoutTestController.notifyDone();
         }
     </script>
 </head>
@@ -18,6 +23,7 @@
     <p>
         If WebKit does not assert or crash after the test, then it passed.
     </p>
-    <img width=24 height=24 src="" _onload_="firstPartLoaded()">
+    <img width=24 height=24 src="" _onload_="firstPartLoaded()">
+    <p id="results"></p>
 </body>
 </html>
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to