Title: [96180] trunk
- Revision
- 96180
- Author
- [email protected]
- Date
- 2011-09-27 19:30:27 -0700 (Tue, 27 Sep 2011)
Log Message
Implement a PageTransitionEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=68067
Patch by Kentaro Hara <[email protected]> on 2011-09-27
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/page-transition-event-constructor.html
* bindings/v8/custom/V8EventConstructors.cpp: Added the PageTransitionEvent constructor.
* dom/PageTransitionEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled page-transition-event-constructor.html, since now V8 has a PageTransitionEvent constructor.
* platform/chromium/test_expectations.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (96179 => 96180)
--- trunk/LayoutTests/ChangeLog 2011-09-28 02:02:18 UTC (rev 96179)
+++ trunk/LayoutTests/ChangeLog 2011-09-28 02:30:27 UTC (rev 96180)
@@ -1,3 +1,14 @@
+2011-09-27 Kentaro Hara <[email protected]>
+
+ Implement a PageTransitionEvent constructor for V8
+ https://bugs.webkit.org/show_bug.cgi?id=68067
+
+ Reviewed by Adam Barth.
+
+ Enabled page-transition-event-constructor.html, since now V8 has a PageTransitionEvent constructor.
+
+ * platform/chromium/test_expectations.txt:
+
2011-09-27 Kentaro Hara <[email protected]>
Implement a MessageEvent constructor for JSC
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96179 => 96180)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-28 02:02:18 UTC (rev 96179)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-28 02:30:27 UTC (rev 96180)
@@ -74,9 +74,6 @@
// to re-enable these "in the next few weeks".
BUGPKASTING SKIP : animations/animation-api-1.html = TEXT
-// This will soon be fixed after implementing a PageTransitionEvent constructor for V8.
-BUGWK68048 : fast/events/constructors/page-transition-event-constructor.html = FAIL
-
// Unskip after implementing DRT support for setDefersLoading and goBack.
BUGWK60877 SKIP : loader/navigation-while-deferring-loads.html = FAIL
BUGWK60877 SKIP : loader/load-defer-resume-crash.html = FAIL
Modified: trunk/Source/WebCore/ChangeLog (96179 => 96180)
--- trunk/Source/WebCore/ChangeLog 2011-09-28 02:02:18 UTC (rev 96179)
+++ trunk/Source/WebCore/ChangeLog 2011-09-28 02:30:27 UTC (rev 96180)
@@ -1,3 +1,15 @@
+2011-09-27 Kentaro Hara <[email protected]>
+
+ Implement a PageTransitionEvent constructor for V8
+ https://bugs.webkit.org/show_bug.cgi?id=68067
+
+ Reviewed by Adam Barth.
+
+ Test: fast/events/constructors/page-transition-event-constructor.html
+
+ * bindings/v8/custom/V8EventConstructors.cpp: Added the PageTransitionEvent constructor.
+ * dom/PageTransitionEvent.idl: Added a 'V8CustomConstructor' attribute.
+
2011-09-27 Kentaro Hara <[email protected]>
Implement a MessageEvent constructor for JSC
Modified: trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp (96179 => 96180)
--- trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-09-28 02:02:18 UTC (rev 96179)
+++ trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-09-28 02:30:27 UTC (rev 96180)
@@ -37,6 +37,7 @@
#include "DocumentFragment.h"
#include "HashChangeEvent.h"
#include "Node.h"
+#include "PageTransitionEvent.h"
#include "ProgressEvent.h"
#include "WebKitAnimationEvent.h"
@@ -49,6 +50,7 @@
#include "V8Event.h"
#include "V8HashChangeEvent.h"
#include "V8Node.h"
+#include "V8PageTransitionEvent.h"
#include "V8ProgressEvent.h"
#include "V8Proxy.h"
#include "V8WebKitAnimationEvent.h"
@@ -111,6 +113,7 @@
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_WEBKIT_ANIMATION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_HASH_CHANGE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_CLOSE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
+INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_PAGE_TRANSITION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
} // namespace WebCore
Modified: trunk/Source/WebCore/dom/PageTransitionEvent.idl (96179 => 96180)
--- trunk/Source/WebCore/dom/PageTransitionEvent.idl 2011-09-28 02:02:18 UTC (rev 96179)
+++ trunk/Source/WebCore/dom/PageTransitionEvent.idl 2011-09-28 02:30:27 UTC (rev 96180)
@@ -27,7 +27,8 @@
interface [
CanBeConstructed,
- CustomConstructFunction
+ CustomConstructFunction,
+ V8CustomConstructor
] PageTransitionEvent : Event {
readonly attribute boolean persisted;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
