Title: [96183] trunk/Tools
- Revision
- 96183
- Author
- [email protected]
- Date
- 2011-09-27 20:37:23 -0700 (Tue, 27 Sep 2011)
Log Message
garden-o-matic should load faster and inform the user what is happening
https://bugs.webkit.org/show_bug.cgi?id=68954
Reviewed by Dimitri Glazkov.
This test disables the expected failures tab. The web inspector showed
that loading the data for this tab was slowing down the loading time
for the whole app. We need to find a way to load that data lazily.
This patch also improves the update message to better describe the
progress the app is making analyzing data from the buildbot.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js (96182 => 96183)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js 2011-09-28 02:58:50 UTC (rev 96182)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js 2011-09-28 03:37:23 UTC (rev 96183)
@@ -38,19 +38,23 @@
function update()
{
// FIXME: This should be a button with a progress element.
- var updating = new ui.notifications.Info('Updating ...');
+ var numberOfTestsAnalyzed = 0;
+ var updating = new ui.notifications.Info('Loading commit data ...');
g_info.add(updating);
builders.buildersFailingStepRequredForTestCoverage(g_failingBuilders.update.bind(g_failingBuilders));
base.callInParallel([model.updateRecentCommits, model.updateResultsByBuilder], function() {
- model.analyzeUnexpectedFailures(g_unexpectedFailuresController.update.bind(g_unexpectedFailuresController), function() {
+ updating.update('Analyzing test failures ...');
+
+ model.analyzeUnexpectedFailures(function(failureAnalysis) {
+ updating.update('Analyzing test failures ... ' + ++numberOfTestsAnalyzed + ' tests analyzed.');
+ g_unexpectedFailuresController.update(failureAnalysis);
+ }, function() {
g_unexpectedFailuresController.purge();
updating.dismiss();
});
-
- model.analyzeExpectedOrUnexpectedFailures(g_failuresController.update.bind(g_failuresController));
});
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js (96182 => 96183)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js 2011-09-28 02:58:50 UTC (rev 96182)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js 2011-09-28 03:37:23 UTC (rev 96183)
@@ -80,6 +80,10 @@
ui.notifications.Info = base.extends(ui.notifications.Notification, {
init: function(message)
{
+ this.update(message);
+ },
+ update: function(message)
+ {
this._what.textContent = message;
}
});
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js (96182 => 96183)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js 2011-09-28 02:58:50 UTC (rev 96182)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js 2011-09-28 03:37:23 UTC (rev 96183)
@@ -73,7 +73,7 @@
'failures',
]
this._tabs = $(this).tabs({
- disabled: [1, 2],
+ disabled: [1, 2, 3],
});
},
attach: function()
Modified: trunk/Tools/ChangeLog (96182 => 96183)
--- trunk/Tools/ChangeLog 2011-09-28 02:58:50 UTC (rev 96182)
+++ trunk/Tools/ChangeLog 2011-09-28 03:37:23 UTC (rev 96183)
@@ -1,5 +1,23 @@
2011-09-27 Adam Barth <[email protected]>
+ garden-o-matic should load faster and inform the user what is happening
+ https://bugs.webkit.org/show_bug.cgi?id=68954
+
+ Reviewed by Dimitri Glazkov.
+
+ This test disables the expected failures tab. The web inspector showed
+ that loading the data for this tab was slowing down the loading time
+ for the whole app. We need to find a way to load that data lazily.
+
+ This patch also improves the update message to better describe the
+ progress the app is making analyzing data from the buildbot.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
+
+2011-09-27 Adam Barth <[email protected]>
+
garden-o-matic should show the first result when examining results
https://bugs.webkit.org/show_bug.cgi?id=68960
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
