Title: [96281] trunk/Source/WebCore
- Revision
- 96281
- Author
- [email protected]
- Date
- 2011-09-28 18:01:13 -0700 (Wed, 28 Sep 2011)
Log Message
Only resolve direction aware properties when properties are direction aware.
https://bugs.webkit.org/show_bug.cgi?id=68968
Reviewed by Eric Seidel.
No new tests / no functionality changed.
Profiling showed a ~8% improvement in applyProperty by not calling resolveDirectionAwareProperty for every property.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (96280 => 96281)
--- trunk/Source/WebCore/ChangeLog 2011-09-29 00:47:07 UTC (rev 96280)
+++ trunk/Source/WebCore/ChangeLog 2011-09-29 01:01:13 UTC (rev 96281)
@@ -1,3 +1,17 @@
+2011-09-28 Luke Macpherson <[email protected]>
+
+ Only resolve direction aware properties when properties are direction aware.
+ https://bugs.webkit.org/show_bug.cgi?id=68968
+
+ Reviewed by Eric Seidel.
+
+ No new tests / no functionality changed.
+
+ Profiling showed a ~8% improvement in applyProperty by not calling resolveDirectionAwareProperty for every property.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty):
+
2011-09-28 Simon Fraser <[email protected]>
fast/dom/scroll-element-to-rect.html fails on WK1 Mac port
Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (96280 => 96281)
--- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-09-29 00:47:07 UTC (rev 96280)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-09-29 01:01:13 UTC (rev 96281)
@@ -2355,8 +2355,6 @@
bool isInherit = m_parentNode && valueType == CSSValue::CSS_INHERIT;
bool isInitial = valueType == CSSValue::CSS_INITIAL || (!m_parentNode && valueType == CSSValue::CSS_INHERIT);
- id = CSSProperty::resolveDirectionAwareProperty(id, m_style->direction(), m_style->writingMode());
-
if (m_checker.isMatchingVisitedPseudoClass() && !isValidVisitedLinkProperty(id)) {
// Limit the properties that can be applied to only the ones honored by :visited.
return;
@@ -3632,9 +3630,11 @@
case CSSPropertyWebkitMinLogicalHeight:
case CSSPropertyWebkitMaxLogicalWidth:
case CSSPropertyWebkitMaxLogicalHeight:
- ASSERT_NOT_REACHED();
- break;
-
+ {
+ int newId = CSSProperty::resolveDirectionAwareProperty(id, m_style->direction(), m_style->writingMode());
+ ASSERT(newId != id);
+ return applyProperty(newId, value);
+ }
case CSSPropertyFontStretch:
case CSSPropertyPage:
case CSSPropertyTextLineThrough:
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
