Title: [96317] trunk/Source/WebKit2
- Revision
- 96317
- Author
- [email protected]
- Date
- 2011-09-29 04:00:04 -0700 (Thu, 29 Sep 2011)
Log Message
[GTK] Explicitly call destructors for objects initialized with placement new syntax
https://bugs.webkit.org/show_bug.cgi?id=69079
Reviewed by Xan Lopez.
* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextFinalize): Call ~WebKitWebContextPrivate().
* UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(webkitWebLoaderClientFinalize): Call ~WebKitWebLoaderClient().
(webkit_web_loader_client_class_init):
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewFinalize): Call ~WebKitWebViewPrivate().
(webkit_web_view_class_init):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (96316 => 96317)
--- trunk/Source/WebKit2/ChangeLog 2011-09-29 10:33:03 UTC (rev 96316)
+++ trunk/Source/WebKit2/ChangeLog 2011-09-29 11:00:04 UTC (rev 96317)
@@ -1,3 +1,19 @@
+2011-09-29 Carlos Garcia Campos <[email protected]>
+
+ [GTK] Explicitly call destructors for objects initialized with placement new syntax
+ https://bugs.webkit.org/show_bug.cgi?id=69079
+
+ Reviewed by Xan Lopez.
+
+ * UIProcess/API/gtk/WebKitWebContext.cpp:
+ (webkitWebContextFinalize): Call ~WebKitWebContextPrivate().
+ * UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
+ (webkitWebLoaderClientFinalize): Call ~WebKitWebLoaderClient().
+ (webkit_web_loader_client_class_init):
+ * UIProcess/API/gtk/WebKitWebView.cpp:
+ (webkitWebViewFinalize): Call ~WebKitWebViewPrivate().
+ (webkit_web_view_class_init):
+
2011-09-28 Martin Robinson <[email protected]>
Fix the WebGL build on WebKit2 GTK+.
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp (96316 => 96317)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp 2011-09-29 10:33:03 UTC (rev 96316)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp 2011-09-29 11:00:04 UTC (rev 96317)
@@ -36,6 +36,10 @@
WKRelease(context->priv->context);
context->priv->context = 0;
+
+ context->priv->~WebKitWebContextPrivate();
+
+ G_OBJECT_CLASS(webkit_web_context_parent_class)->finalize(object);
}
static void webkit_web_context_init(WebKitWebContext* webContext)
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp (96316 => 96317)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp 2011-09-29 10:33:03 UTC (rev 96316)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp 2011-09-29 11:00:04 UTC (rev 96317)
@@ -182,6 +182,12 @@
}
}
+static void webkitWebLoaderClientFinalize(GObject* object)
+{
+ WEBKIT_WEB_LOADER_CLIENT(object)->priv->~WebKitWebLoaderClientPrivate();
+ G_OBJECT_CLASS(webkit_web_loader_client_parent_class)->finalize(object);
+}
+
static void webkit_web_loader_client_init(WebKitWebLoaderClient* client)
{
WebKitWebLoaderClientPrivate* priv = G_TYPE_INSTANCE_GET_PRIVATE(client, WEBKIT_TYPE_WEB_LOADER_CLIENT, WebKitWebLoaderClientPrivate);
@@ -196,6 +202,7 @@
objectClass->set_property = webkitWebLoaderClientSetProperty;
objectClass->get_property = webkitWebLoaderClientGetProperty;
objectClass->constructed = webkitWebLoaderClientConstructed;
+ objectClass->finalize = webkitWebLoaderClientFinalize;
/**
* WebKitWebView:web-view:
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (96316 => 96317)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2011-09-29 10:33:03 UTC (rev 96316)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2011-09-29 11:00:04 UTC (rev 96317)
@@ -83,6 +83,12 @@
}
}
+static void webkitWebViewFinalize(GObject* object)
+{
+ WEBKIT_WEB_VIEW(object)->priv->~WebKitWebViewPrivate();
+ G_OBJECT_CLASS(webkit_web_view_parent_class)->finalize(object);
+}
+
static void webkit_web_view_init(WebKitWebView* webView)
{
WebKitWebViewPrivate* priv = G_TYPE_INSTANCE_GET_PRIVATE(webView, WEBKIT_TYPE_WEB_VIEW, WebKitWebViewPrivate);
@@ -97,6 +103,7 @@
gObjectClass->constructed = webkitWebViewConstructed;
gObjectClass->set_property = webkitWebViewSetProperty;
gObjectClass->get_property = webkitWebViewGetProperty;
+ gObjectClass->finalize = webkitWebViewFinalize;
g_type_class_add_private(webViewClass, sizeof(WebKitWebViewPrivate));
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
