Title: [96401] trunk/LayoutTests
- Revision
- 96401
- Author
- commit-qu...@webkit.org
- Date
- 2011-09-30 07:44:02 -0700 (Fri, 30 Sep 2011)
Log Message
Replace textInputController.doCommand with eventSender.keyDown in password-echo tests
https://bugs.webkit.org/show_bug.cgi?id=69143
textInputController.doCommand is not supported very well across the platforms. Replace it
with eventSender.keyDown would make the tests pass on more platforms and potentially WK2.
Patch by Chang Shu <c...@webkit.org> on 2011-09-30
Reviewed by Antonio Gomes.
* editing/input/resources/password-echo.js:
(init):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (96400 => 96401)
--- trunk/LayoutTests/ChangeLog 2011-09-30 14:23:43 UTC (rev 96400)
+++ trunk/LayoutTests/ChangeLog 2011-09-30 14:44:02 UTC (rev 96401)
@@ -1,3 +1,16 @@
+2011-09-30 Chang Shu <c...@webkit.org>
+
+ Replace textInputController.doCommand with eventSender.keyDown in password-echo tests
+ https://bugs.webkit.org/show_bug.cgi?id=69143
+
+ textInputController.doCommand is not supported very well across the platforms. Replace it
+ with eventSender.keyDown would make the tests pass on more platforms and potentially WK2.
+
+ Reviewed by Antonio Gomes.
+
+ * editing/input/resources/password-echo.js:
+ (init):
+
2011-09-30 Shinichiro Hamaji <ham...@chromium.org>
[Chromium] Layout test failures under Snow Leopard
Modified: trunk/LayoutTests/editing/input/resources/password-echo.js (96400 => 96401)
--- trunk/LayoutTests/editing/input/resources/password-echo.js 2011-09-30 14:23:43 UTC (rev 96400)
+++ trunk/LayoutTests/editing/input/resources/password-echo.js 2011-09-30 14:44:02 UTC (rev 96401)
@@ -42,7 +42,7 @@
{
var expectedSecureTextLen;
if (testIdx >= 0) {
- textInputController.doCommand("moveForward:");
+ eventSender.keyDown("rightArrow");
if(tests[testIdx][3])
assert(tests[testIdx][2], window.find(secureText(testnode.value.length), false, true), "secured after delay.");
}
@@ -53,15 +53,16 @@
}
testnode.focus();
- textInputController.doCommand("moveForward:");
+ eventSender.keyDown("rightArrow");
var charSequence = tests[testIdx][0];
for (var i = 0; i < charSequence.length - 1; i++) {
textInputController.setMarkedText(charSequence[i], testnode.value.length, testnode.value.length);
}
- if (charSequence[charSequence.length - 1] == "backspace")
- textInputController.doCommand("deleteBackward:");
- else
+ if (charSequence[charSequence.length - 1] == "backspace") {
+ eventSender.keyDown("leftArrow");
+ eventSender.keyDown("delete");
+ } else
textInputController.insertText(charSequence[charSequence.length - 1]);
if(tests[testIdx][3])
@@ -75,7 +76,7 @@
function init(tests)
{
- if (window.layoutTestController && window.textInputController) {
+ if (window.layoutTestController && window.textInputController && window.eventSender) {
layoutTestController.dumpAsText();
layoutTestController.waitUntilDone();
if (window.internals) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
