Title: [96428] trunk/Tools
Revision
96428
Author
[email protected]
Date
2011-09-30 14:38:26 -0700 (Fri, 30 Sep 2011)

Log Message

Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest on Windows..
https://bugs.webkit.org/show_bug.cgi?id=69039

Reviewed by Adam Barth.

* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
Actually skip only one specific test that is failing on Windows.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (96427 => 96428)


--- trunk/Tools/ChangeLog	2011-09-30 21:36:57 UTC (rev 96427)
+++ trunk/Tools/ChangeLog	2011-09-30 21:38:26 UTC (rev 96428)
@@ -1,3 +1,13 @@
+2011-09-30  David Levin  <[email protected]>
+
+        Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest on Windows..
+        https://bugs.webkit.org/show_bug.cgi?id=69039
+
+        Reviewed by Adam Barth.
+
+        * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
+        Actually skip only one specific test that is failing on Windows.
+
 2011-09-30  Tor Arne Vestbø  <[email protected]>
 
         [Qt] Prevent qDebug() output from DRT and WTR unless --verbose

Modified: trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py (96427 => 96428)


--- trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py	2011-09-30 21:36:57 UTC (rev 96427)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py	2011-09-30 21:38:26 UTC (rev 96428)
@@ -26,6 +26,7 @@
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
+import sys
 import unittest
 
 from webkitpy.common.checkout.baselineoptimizer import BaselineOptimizer
@@ -130,6 +131,9 @@
         })
 
     def test_complex_shadowing(self):
+        # This test relies on OS specific functionality, so it doesn't work on Windows.
+        if sys.platform == 'win32':
+            return
         self._assertOptimization({
             'LayoutTests/platform/chromium-win': '462d03b9c025db1b0392d7453310dbee5f9a9e74',
             'LayoutTests/platform/mac': '5daa78e55f05d9f0d1bb1f32b0cd1bc3a01e9364',
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to