Title: [96664] trunk/Tools
Revision
96664
Author
[email protected]
Date
2011-10-04 16:53:27 -0700 (Tue, 04 Oct 2011)

Log Message

Fix Perl undefined variable warning when using run-safari after
<http://trac.webkit.org/changeset/96448> (https://bugs.webkit.org/show_bug.cgi?id=68662)

Rubber-stamped by Alexey Proskuryakov.

* Scripts/webkitdirs.pm:
(runMacWebKitApp): Check that the optional function argument $useOpenCommand
is defined before using it in a comparison operation.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (96663 => 96664)


--- trunk/Tools/ChangeLog	2011-10-04 23:48:39 UTC (rev 96663)
+++ trunk/Tools/ChangeLog	2011-10-04 23:53:27 UTC (rev 96664)
@@ -1,3 +1,14 @@
+2011-10-04  Daniel Bates  <[email protected]>
+
+        Fix Perl undefined variable warning when using run-safari after
+        <http://trac.webkit.org/changeset/96448> (https://bugs.webkit.org/show_bug.cgi?id=68662)
+
+        Rubber-stamped by Alexey Proskuryakov.
+
+        * Scripts/webkitdirs.pm:
+        (runMacWebKitApp): Check that the optional function argument $useOpenCommand
+        is defined before using it in a comparison operation.
+
 2011-10-04  Scott Graham  <[email protected]>
 
         Add GAMEPAD feature flag

Modified: trunk/Tools/Scripts/webkitdirs.pm (96663 => 96664)


--- trunk/Tools/Scripts/webkitdirs.pm	2011-10-04 23:48:39 UTC (rev 96663)
+++ trunk/Tools/Scripts/webkitdirs.pm	2011-10-04 23:53:27 UTC (rev 96664)
@@ -2023,7 +2023,7 @@
     print "Starting @{[basename($appPath)]} with DYLD_FRAMEWORK_PATH set to point to built WebKit in $productDir.\n";
     $ENV{DYLD_FRAMEWORK_PATH} = $productDir;
     $ENV{WEBKIT_UNSET_DYLD_FRAMEWORK_PATH} = "YES";
-    if ($useOpenCommand == USE_OPEN_COMMAND) {
+    if (defined($useOpenCommand) && $useOpenCommand == USE_OPEN_COMMAND) {
         return system("open", "-W", "-a", $appPath, "--args", @ARGV);
     }
     if (architecture()) {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to