Title: [96682] trunk/Source/WebKit/chromium
- Revision
- 96682
- Author
- [email protected]
- Date
- 2011-10-05 01:21:59 -0700 (Wed, 05 Oct 2011)
Log Message
[Chromium] Web Inspector: save inspector state into single string instead of string map
https://bugs.webkit.org/show_bug.cgi?id=69335
Now that Chromium side is updated, remove unused methods from the DevToolsAgent API.
Reviewed by Pavel Feldman.
* public/WebDevToolsAgent.h:
* public/WebDevToolsAgentClient.h:
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie):
* src/WebDevToolsAgentImpl.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (96681 => 96682)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-05 08:09:16 UTC (rev 96681)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-05 08:21:59 UTC (rev 96682)
@@ -1,3 +1,18 @@
+2011-10-04 Yury Semikhatsky <[email protected]>
+
+ [Chromium] Web Inspector: save inspector state into single string instead of string map
+ https://bugs.webkit.org/show_bug.cgi?id=69335
+
+ Now that Chromium side is updated, remove unused methods from the DevToolsAgent API.
+
+ Reviewed by Pavel Feldman.
+
+ * public/WebDevToolsAgent.h:
+ * public/WebDevToolsAgentClient.h:
+ * src/WebDevToolsAgentImpl.cpp:
+ (WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie):
+ * src/WebDevToolsAgentImpl.h:
+
2011-10-04 Kent Tamura <[email protected]>
Introduce feature flags for incomplete input types
Modified: trunk/Source/WebKit/chromium/public/WebDevToolsAgent.h (96681 => 96682)
--- trunk/Source/WebKit/chromium/public/WebDevToolsAgent.h 2011-10-05 08:09:16 UTC (rev 96681)
+++ trunk/Source/WebKit/chromium/public/WebDevToolsAgent.h 2011-10-05 08:21:59 UTC (rev 96682)
@@ -65,8 +65,6 @@
virtual void dispatchOnInspectorBackend(const WebString& message) = 0;
virtual void inspectElementAt(const WebPoint&) = 0;
- // Deprecated. Will be removed shortly.
- virtual void setRuntimeProperty(const WebString& name, const WebString& value) = 0;
virtual void setProcessId(long) = 0;
// Exposed for LayoutTestController.
Modified: trunk/Source/WebKit/chromium/public/WebDevToolsAgentClient.h (96681 => 96682)
--- trunk/Source/WebKit/chromium/public/WebDevToolsAgentClient.h 2011-10-05 08:09:16 UTC (rev 96681)
+++ trunk/Source/WebKit/chromium/public/WebDevToolsAgentClient.h 2011-10-05 08:21:59 UTC (rev 96682)
@@ -46,8 +46,6 @@
// Returns the identifier of the entity hosting this agent.
virtual int hostIdentifier() { return -1; }
- // Notifies host upon runtime feature being enabled/disabled.
- virtual void runtimePropertyChanged(const WebString& name, const WebString& value) { }
// Save the agent state in order to pass it later into WebDevToolsAgent::reattach
// if the same client is reattached to another agent.
virtual void saveAgentRuntimeState(const WebString&) { }
Modified: trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp (96681 => 96682)
--- trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp 2011-10-05 08:09:16 UTC (rev 96681)
+++ trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp 2011-10-05 08:21:59 UTC (rev 96682)
@@ -71,9 +71,6 @@
namespace WebKit {
-static const char kFrontendConnectedFeatureName[] = "frontend-connected";
-static const char kInspectorStateFeatureName[] = "inspector-state";
-
class ClientMessageLoopAdapter : public PageScriptDebugServer::ClientMessageLoop {
public:
static void ensureClientMessageLoopCreated(WebDevToolsAgentClient* client)
@@ -250,14 +247,6 @@
m_webViewImpl->inspectElementAt(point);
}
-void WebDevToolsAgentImpl::setRuntimeProperty(const WebString& name, const WebString& value)
-{
- if (name == kInspectorStateFeatureName) {
- InspectorController* ic = inspectorController();
- ic->restoreInspectorStateFromCookie(value);
- }
-}
-
InspectorController* WebDevToolsAgentImpl::inspectorController()
{
if (Page* page = m_webViewImpl->page())
@@ -311,7 +300,6 @@
void WebDevToolsAgentImpl::updateInspectorStateCookie(const String& state)
{
- m_client->runtimePropertyChanged(kInspectorStateFeatureName, state);
m_client->saveAgentRuntimeState(state);
}
Modified: trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h (96681 => 96682)
--- trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h 2011-10-05 08:09:16 UTC (rev 96681)
+++ trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h 2011-10-05 08:21:59 UTC (rev 96682)
@@ -81,7 +81,6 @@
virtual void inspectElementAt(const WebPoint& point);
virtual void evaluateInWebInspector(long callId, const WebString& script);
virtual void setJavaScriptProfilingEnabled(bool);
- virtual void setRuntimeProperty(const WebString& name, const WebString& value);
virtual void setProcessId(long);
// InspectorClient implementation.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
