Title: [96686] trunk
- Revision
- 96686
- Author
- [email protected]
- Date
- 2011-10-05 02:25:32 -0700 (Wed, 05 Oct 2011)
Log Message
Input styles are unexpectedly shared regardless of required status difference.
https://bugs.webkit.org/show_bug.cgi?id=69402
Reviewed by Daniel Bates.
Source/WebCore:
Tests: fast/css/pseudo-required-shared.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithControl): Check the difference of required().
LayoutTests:
* fast/css/pseudo-required-shared-expected.html: Added.
* fast/css/pseudo-required-shared.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (96685 => 96686)
--- trunk/LayoutTests/ChangeLog 2011-10-05 09:21:54 UTC (rev 96685)
+++ trunk/LayoutTests/ChangeLog 2011-10-05 09:25:32 UTC (rev 96686)
@@ -1,3 +1,13 @@
+2011-10-05 Kent Tamura <[email protected]>
+
+ Input styles are unexpectedly shared regardless of required status difference.
+ https://bugs.webkit.org/show_bug.cgi?id=69402
+
+ Reviewed by Daniel Bates.
+
+ * fast/css/pseudo-required-shared-expected.html: Added.
+ * fast/css/pseudo-required-shared.html: Added.
+
2011-10-05 Gabor Rapcsanyi <[email protected]>
[Qt] Unreviewed gardening, update expected file after r96509.
Added: trunk/LayoutTests/fast/css/pseudo-required-shared-expected.html (0 => 96686)
--- trunk/LayoutTests/fast/css/pseudo-required-shared-expected.html (rev 0)
+++ trunk/LayoutTests/fast/css/pseudo-required-shared-expected.html 2011-10-05 09:25:32 UTC (rev 96686)
@@ -0,0 +1,7 @@
+<!DOCTYPE html>
+<html>
+<body>
+<input value="required" style="color:red;">
+<input value="optional">
+</body>
+</html>
Added: trunk/LayoutTests/fast/css/pseudo-required-shared.html (0 => 96686)
--- trunk/LayoutTests/fast/css/pseudo-required-shared.html (rev 0)
+++ trunk/LayoutTests/fast/css/pseudo-required-shared.html 2011-10-05 09:25:32 UTC (rev 96686)
@@ -0,0 +1,15 @@
+<!DOCTYPE html>
+<html>
+<!-- There was a bug that styles are unexpectedly shared regardless of required status difference. -->
+<head>
+<style>
+:required:valid {
+ color: red;
+}
+</style>
+</head>
+<body>
+<input required value="required">
+<input value="optional">
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (96685 => 96686)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 09:21:54 UTC (rev 96685)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 09:25:32 UTC (rev 96686)
@@ -1,3 +1,15 @@
+2011-10-05 Kent Tamura <[email protected]>
+
+ Input styles are unexpectedly shared regardless of required status difference.
+ https://bugs.webkit.org/show_bug.cgi?id=69402
+
+ Reviewed by Daniel Bates.
+
+ Tests: fast/css/pseudo-required-shared.html
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::canShareStyleWithControl): Check the difference of required().
+
2011-10-04 Kent Tamura <[email protected]>
Remove Node::willBlur()
Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (96685 => 96686)
--- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-10-05 09:21:54 UTC (rev 96685)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-10-05 09:25:32 UTC (rev 96686)
@@ -790,13 +790,15 @@
return false;
if (thisInputElement->isIndeterminate() != otherInputElement->isIndeterminate())
return false;
+ if (thisInputElement->required() != otherInputElement->required())
+ return false;
if (element->isEnabledFormControl() != m_element->isEnabledFormControl())
return false;
if (element->isDefaultButtonForForm() != m_element->isDefaultButtonForForm())
return false;
-
+
if (!m_element->document()->containsValidityStyleRules())
return false;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
