Title: [96873] trunk/Source/WebCore
- Revision
- 96873
- Author
- m...@apple.com
- Date
- 2011-10-06 16:40:22 -0700 (Thu, 06 Oct 2011)
Log Message
Added a comment explaining code added in r96834.
Suggested by Darin Adler.
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::updateAppearance):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (96872 => 96873)
--- trunk/Source/WebCore/ChangeLog 2011-10-06 23:39:25 UTC (rev 96872)
+++ trunk/Source/WebCore/ChangeLog 2011-10-06 23:40:22 UTC (rev 96873)
@@ -1,3 +1,12 @@
+2011-10-06 Dan Bernstein <m...@apple.com>
+
+ Added a comment explaining code added in r96834.
+
+ Suggested by Darin Adler.
+
+ * editing/FrameSelection.cpp:
+ (WebCore::FrameSelection::updateAppearance):
+
2011-10-05 Ryosuke Niwa <rn...@webkit.org>
Deleting line break before h1 converts h1 to span
Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (96872 => 96873)
--- trunk/Source/WebCore/editing/FrameSelection.cpp 2011-10-06 23:39:25 UTC (rev 96872)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp 2011-10-06 23:40:22 UTC (rev 96873)
@@ -1680,6 +1680,8 @@
if (!view)
return;
+ // Construct a new VisibleSolution, since m_selection is not necessarily valid, and the following steps
+ // assume a valid selection. See <https://bugs.webkit.org/show_bug.cgi?id=69563> and <rdar://problem/10232866>.
VisibleSelection selection(m_selection.visibleStart(), m_selection.visibleEnd());
if (!selection.isRange()) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
