Diff
Modified: trunk/LayoutTests/ChangeLog (96910 => 96911)
--- trunk/LayoutTests/ChangeLog 2011-10-07 07:04:45 UTC (rev 96910)
+++ trunk/LayoutTests/ChangeLog 2011-10-07 07:06:09 UTC (rev 96911)
@@ -1,3 +1,18 @@
+2011-10-07 Kent Tamura <[email protected]>
+
+ Test update for r96893.
+ https://bugs.webkit.org/show_bug.cgi?id=53752
+
+ r96893 changed the behavior of dataset-gc.html and
+ dataset-xhtml.xhtml. We update these tests because the new
+ behavior matches to Firefox and Opera.
+
+ * fast/dom/dataset-gc-expected.txt:
+ * fast/dom/dataset-xhtml-expected.txt:
+ * fast/dom/script-tests/dataset-gc.js:
+ * fast/dom/script-tests/dataset-xhtml.js:
+ * platform/chromium/test_expectations.txt:
+
2011-10-06 Adam Barth <[email protected]>
Port PixelZoomer to work in garden-o-matic
Modified: trunk/LayoutTests/fast/dom/dataset-gc-expected.txt (96910 => 96911)
--- trunk/LayoutTests/fast/dom/dataset-gc-expected.txt 2011-10-07 07:04:45 UTC (rev 96910)
+++ trunk/LayoutTests/fast/dom/dataset-gc-expected.txt 2011-10-07 07:06:09 UTC (rev 96911)
@@ -3,9 +3,9 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS d.getAttribute('data-custom-property') is null
-PASS d.dataset.customProperty is 1
-PASS d.dataset.customProperty is 1
+PASS d.getAttribute('data-custom-property') is '1'
+PASS d.dataset.customProperty is '1'
+PASS d.dataset.customProperty is '1'
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/dom/dataset-xhtml-expected.txt (96910 => 96911)
--- trunk/LayoutTests/fast/dom/dataset-xhtml-expected.txt 2011-10-07 07:04:45 UTC (rev 96910)
+++ trunk/LayoutTests/fast/dom/dataset-xhtml-expected.txt 2011-10-07 07:06:09 UTC (rev 96911)
@@ -34,7 +34,7 @@
PASS testDelete('data-', '') is true
PASS testDelete('data-à', 'à') is true
-PASS testDelete('dummy', '-foo') threw exception Error: SYNTAX_ERR: DOM Exception 12.
+PASS testDelete('dummy', '-foo') is false
PASS testForIn(['data-foo', 'data-bar', 'data-baz']) is 3
PASS testForIn(['data-foo', 'data-bar', 'dataFoo']) is 2
Modified: trunk/LayoutTests/fast/dom/script-tests/dataset-gc.js (96910 => 96911)
--- trunk/LayoutTests/fast/dom/script-tests/dataset-gc.js 2011-10-07 07:04:45 UTC (rev 96910)
+++ trunk/LayoutTests/fast/dom/script-tests/dataset-gc.js 2011-10-07 07:06:09 UTC (rev 96911)
@@ -14,16 +14,17 @@
var d = document.createElement("div");
var dataset = d.dataset;
-dataset.__proto__.customProperty = 1; // Add a property to our prototype, so it won't forward to our element.
+// Add a property to our prototype. It will be hidden by the corresponding data- attribute.
+dataset.__proto__.customProperty = 1;
dataset.customProperty = 1; // Now set a property on ourselves.
-shouldBe("d.getAttribute('data-custom-property')", "null");
-shouldBe("d.dataset.customProperty", "1");
+shouldBe("d.getAttribute('data-custom-property')", "'1'");
+shouldBe("d.dataset.customProperty", "'1'");
dataset = null;
gc();
// Test that the custom property persisted the GC.
-shouldBe("d.dataset.customProperty", "1");
+shouldBe("d.dataset.customProperty", "'1'");
var successfullyParsed = true;
Modified: trunk/LayoutTests/fast/dom/script-tests/dataset-xhtml.js (96910 => 96911)
--- trunk/LayoutTests/fast/dom/script-tests/dataset-xhtml.js 2011-10-07 07:04:45 UTC (rev 96910)
+++ trunk/LayoutTests/fast/dom/script-tests/dataset-xhtml.js 2011-10-07 07:06:09 UTC (rev 96911)
@@ -69,7 +69,7 @@
shouldBeTrue("testDelete('data-\xE0', '\xE0')");
debug("");
-shouldThrow("testDelete('dummy', '-foo')", "'Error: SYNTAX_ERR: DOM Exception 12'");
+shouldBeFalse("testDelete('dummy', '-foo')");
debug("");
function testForIn(array)
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96910 => 96911)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-07 07:04:45 UTC (rev 96910)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-07 07:06:09 UTC (rev 96911)
@@ -3747,6 +3747,7 @@
// Need to follow a JSC binding change. See webkit.org/b/53752.
BUGWK53578 : fast/dom/dataset.html = TEXT
+BUGWK53578 : fast/dom/dataset-xhtml.xhtml = TEXT
// Need rebaselines after r96257
BUGWK62092 MAC : editing/pasteboard/paste-xml.xhtml = TEXT
