Log Message
Web Inspector: add ResourcesPanel to the compilation. https://bugs.webkit.org/show_bug.cgi?id=69612
Reviewed by Yury Semikhatsky. * inspector/compile-front-end.sh: * inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid): * inspector/front-end/NetworkPanel.js: * inspector/front-end/ResourceView.js: * inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.showAnchorLocation): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.BaseStorageTreeElement.prototype.isEventWithinDisclosureTriangle): (WebInspector.FrameTreeElement.prototype.frameNavigated): (WebInspector.StorageCategoryView): (WebInspector.SearchResultsTreeElementsTraverser.prototype.last): * inspector/front-end/externs.js: (WebInspector.openRequestInNetworkPanel):
Modified Paths
- trunk/Source/WebCore/ChangeLog
- trunk/Source/WebCore/inspector/compile-front-end.sh
- trunk/Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js
- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js
- trunk/Source/WebCore/inspector/front-end/ResourceView.js
- trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js
- trunk/Source/WebCore/inspector/front-end/externs.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (96928 => 96929)
--- trunk/Source/WebCore/ChangeLog 2011-10-07 11:11:41 UTC (rev 96928)
+++ trunk/Source/WebCore/ChangeLog 2011-10-07 11:35:25 UTC (rev 96929)
@@ -1,3 +1,25 @@
+2011-10-07 Pavel Feldman <pfeld...@google.com>
+
+ Web Inspector: add ResourcesPanel to the compilation.
+ https://bugs.webkit.org/show_bug.cgi?id=69612
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/compile-front-end.sh:
+ * inspector/front-end/ApplicationCacheItemsView.js:
+ (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
+ * inspector/front-end/NetworkPanel.js:
+ * inspector/front-end/ResourceView.js:
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel.prototype.showAnchorLocation):
+ (WebInspector.ResourcesPanel.prototype.showResource):
+ (WebInspector.BaseStorageTreeElement.prototype.isEventWithinDisclosureTriangle):
+ (WebInspector.FrameTreeElement.prototype.frameNavigated):
+ (WebInspector.StorageCategoryView):
+ (WebInspector.SearchResultsTreeElementsTraverser.prototype.last):
+ * inspector/front-end/externs.js:
+ (WebInspector.openRequestInNetworkPanel):
+
2011-10-07 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r96909.
Modified: trunk/Source/WebCore/inspector/compile-front-end.sh (96928 => 96929)
--- trunk/Source/WebCore/inspector/compile-front-end.sh 2011-10-07 11:11:41 UTC (rev 96928)
+++ trunk/Source/WebCore/inspector/compile-front-end.sh 2011-10-07 11:35:25 UTC (rev 96929)
@@ -108,7 +108,8 @@
--js Source/WebCore/inspector/front-end/UIUtils.js \
--js Source/WebCore/inspector/front-end/View.js \
--js Source/WebCore/inspector/front-end/WelcomeView.js \
- --module jsmodule_inspector_views:30:jsmodule_sdk,jsmodule_ui \
+ --module jsmodule_inspector_views:31:jsmodule_sdk,jsmodule_ui \
+ --js Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js \
--js Source/WebCore/inspector/front-end/ConsoleMessage.js \
--js Source/WebCore/inspector/front-end/ConsoleView.js \
--js Source/WebCore/inspector/front-end/CookieItemsView.js \
@@ -141,14 +142,12 @@
--js Source/WebCore/inspector/front-end/TimelineAgent.js \
--js Source/WebCore/inspector/front-end/TimelineGrid.js \
--js Source/WebCore/inspector/front-end/TimelineManager.js \
- --module jsmodule_inspector_panels:2:jsmodule_inspector_views \
+ --module jsmodule_inspector_panels:3:jsmodule_inspector_views \
--js Source/WebCore/inspector/front-end/ElementsPanel.js \
- --js Source/WebCore/inspector/front-end/NetworkPanel.js
+ --js Source/WebCore/inspector/front-end/NetworkPanel.js \
+ --js Source/WebCore/inspector/front-end/ResourcesPanel.js
# To be compiled...
-# [Resources]
-# ResourcesPanel
-#
# [Scripts]
# _javascript_Formatter
# _javascript_SourceFrame
@@ -159,7 +158,6 @@
# CallStackSidebarPane
#
# [Timeline]
-# TimelineGrid
# TimelineOverviewPane
# TimelinePanel
#
@@ -195,15 +193,12 @@
# ExtensionServer
#
# [Misc]
-# GoToLineDialog
-# TestController
-#
-# [Misc]
# inspector
# SettingsScreen
# SourceCSSTokenizer
# SourceHTMLTokenizer
# SourceJavaScriptTokenizer
+# TestController
#
# [Workers]
# InjectedFakeWorker
Modified: trunk/Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js (96928 => 96929)
--- trunk/Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js 2011-10-07 11:11:41 UTC (rev 96928)
+++ trunk/Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js 2011-10-07 11:35:25 UTC (rev 96929)
@@ -23,6 +23,10 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
+/**
+ * @constructor
+ * @extends {WebInspector.View}
+ */
WebInspector.ApplicationCacheItemsView = function(treeElement, appcacheDomain)
{
WebInspector.View.call(this);
@@ -218,7 +222,7 @@
}
var comparator;
- switch (parseInt(this._dataGrid.sortColumnIdentifier)) {
+ switch (parseInt(this._dataGrid.sortColumnIdentifier, 10)) {
case 0: comparator = localeCompare.bind(this, "name"); break;
case 1: comparator = localeCompare.bind(this, "type"); break;
case 2: comparator = numberCompare.bind(this, "size"); break;
@@ -280,6 +284,10 @@
WebInspector.ApplicationCacheItemsView.prototype.__proto__ = WebInspector.View.prototype;
+/**
+ * @constructor
+ * @implements {ApplicationCacheAgent.Dispatcher}
+ */
WebInspector.ApplicationCacheDispatcher = function()
{
}
Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (96928 => 96929)
--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2011-10-07 11:11:41 UTC (rev 96928)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2011-10-07 11:35:25 UTC (rev 96929)
@@ -28,10 +28,10 @@
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
- /**
- * @constructor
- * @extends {WebInspector.IFrameView}
- */
+/**
+ * @constructor
+ * @extends {WebInspector.IFrameView}
+ */
WebInspector.NetworkLogView = function(parentElement)
{
// FIXME: some of the styles should be loaded on demand by components that need them.
Modified: trunk/Source/WebCore/inspector/front-end/ResourceView.js (96928 => 96929)
--- trunk/Source/WebCore/inspector/front-end/ResourceView.js 2011-10-07 11:11:41 UTC (rev 96928)
+++ trunk/Source/WebCore/inspector/front-end/ResourceView.js 2011-10-07 11:35:25 UTC (rev 96929)
@@ -121,15 +121,15 @@
WebInspector.ResourceSourceFrame.prototype.__proto__ = WebInspector.SourceFrame.prototype;
+/**
+ * @constructor
+ * @extends {WebInspector.ResourceSourceFrame}
+ */
WebInspector.EditableResourceSourceFrame = function(resource)
{
WebInspector.ResourceSourceFrame.call(this, resource);
}
-/**
- * @extends {WebInspector.ResourceSourceFrame}
- * @constructor
- */
WebInspector.EditableResourceSourceFrame.prototype = {
canEditSource: function()
{
Modified: trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js (96928 => 96929)
--- trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js 2011-10-07 11:11:41 UTC (rev 96928)
+++ trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js 2011-10-07 11:35:25 UTC (rev 96929)
@@ -27,6 +27,10 @@
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+/**
+ * @constructor
+ * @extends {WebInspector.Panel}
+ */
WebInspector.ResourcesPanel = function(database)
{
WebInspector.Panel.call(this, "resources");
@@ -333,17 +337,20 @@
showAnchorLocation: function(anchor)
{
var resource = WebInspector.resourceForURL(anchor.href);
- var lineNumber = anchor.hasAttribute("line_number") ? parseInt(anchor.getAttribute("line_number")) : undefined;
+ var lineNumber = anchor.hasAttribute("line_number") ? parseInt(anchor.getAttribute("line_number"), 10) : undefined;
this.showResource(resource, lineNumber);
},
+ /**
+ * @param {number=} line
+ */
showResource: function(resource, line)
{
var resourceTreeElement = this._findTreeElementForResource(resource);
if (resourceTreeElement)
resourceTreeElement.revealAndSelect();
- if (line !== undefined) {
+ if (typeof line === "number") {
var view = this._resourceViewForResource(resource);
if (view.canHighlightLine())
view.highlightLine(line);
@@ -388,6 +395,9 @@
return treeElement.sourceView();
},
+ /**
+ * @param {WebInspector.ResourceRevision=} revision
+ */
_fetchAndApplyDiffMarkup: function(view, resource, revision)
{
var baseRevision = resource.history[0];
@@ -415,6 +425,9 @@
view.markDiff(diffData);
},
+ /**
+ * @param {string=} tableName
+ */
showDatabase: function(database, tableName)
{
if (!database)
@@ -815,6 +828,12 @@
WebInspector.ResourcesPanel.prototype.__proto__ = WebInspector.Panel.prototype;
+/**
+ * @constructor
+ * @extends {TreeElement}
+ * @param {boolean=} hasChildren
+ * @param {boolean=} noIcon
+ */
WebInspector.BaseStorageTreeElement = function(storagePanel, representedObject, title, iconClasses, hasChildren, noIcon)
{
TreeElement.call(this, "", representedObject, hasChildren);
@@ -874,7 +893,7 @@
this.titleElement.textContent = this._titleText;
},
- isEventWithinDisclosureTriangle: function()
+ isEventWithinDisclosureTriangle: function(event)
{
// Override it since we use margin-left in place of treeoutline's text-indent.
// Hence we need to take padding into consideration. This all is needed for leading
@@ -887,6 +906,11 @@
WebInspector.BaseStorageTreeElement.prototype.__proto__ = TreeElement.prototype;
+/**
+ * @constructor
+ * @extends {WebInspector.BaseStorageTreeElement}
+ * @param {boolean=} noIcon
+ */
WebInspector.StorageCategoryTreeElement = function(storagePanel, categoryName, settingsKey, iconClasses, noIcon)
{
WebInspector.BaseStorageTreeElement.call(this, storagePanel, null, categoryName, iconClasses, true, noIcon);
@@ -927,6 +951,10 @@
WebInspector.StorageCategoryTreeElement.prototype.__proto__ = WebInspector.BaseStorageTreeElement.prototype;
+/**
+ * @constructor
+ * @extends {WebInspector.BaseStorageTreeElement}
+ */
WebInspector.FrameTreeElement = function(storagePanel, frame)
{
WebInspector.BaseStorageTreeElement.call(this, storagePanel, null, "", ["frame-storage-tree-item"]);
@@ -941,7 +969,7 @@
this._frameId = frame.id;
var title = frame.name;
- var subtitle = new WebInspector.Resource(null, frame.url).displayName;
+ var subtitle = WebInspector.Resource.displayName(frame.url);
this.setTitles(title, subtitle);
this._categoryElements = {};
@@ -1079,6 +1107,10 @@
WebInspector.FrameTreeElement.prototype.__proto__ = WebInspector.BaseStorageTreeElement.prototype;
+/**
+ * @constructor
+ * @extends {WebInspector.BaseStorageTreeElement}
+ */
WebInspector.FrameResourceTreeElement = function(storagePanel, resource)
{
WebInspector.BaseStorageTreeElement.call(this, storagePanel, resource, resource.displayName, ["resource-sidebar-tree-item", "resources-category-" + resource.category.name]);
@@ -1320,6 +1352,10 @@
WebInspector.FrameResourceTreeElement.prototype.__proto__ = WebInspector.BaseStorageTreeElement.prototype;
+/**
+ * @constructor
+ * @extends {WebInspector.BaseStorageTreeElement}
+ */
WebInspector.DatabaseTreeElement = function(storagePanel, database)
{
WebInspector.BaseStorageTreeElement.call(this, storagePanel, null, database.name, ["database-storage-tree-item"], true);
@@ -1361,6 +1397,10 @@
WebInspector.DatabaseTreeElement.prototype.__proto__ = WebInspector.BaseStorageTreeElement.prototype;
+/**
+ * @constructor
+ * @extends {WebInspector.BaseStorageTreeElement}
+ */
WebInspector.DatabaseTableTreeElement = function(storagePanel, database, tableName)
{
WebInspector.BaseStorageTreeElement.call(this, storagePanel, null, tableName, ["database-storage-tree-item"]);
@@ -1382,6 +1422,10 @@
}
WebInspector.DatabaseTableTreeElement.prototype.__proto__ = WebInspector.BaseStorageTreeElement.prototype;
+/**
+ * @constructor
+ * @extends {WebInspector.BaseStorageTreeElement}
+ */
WebInspector.DOMStorageTreeElement = function(storagePanel, domStorage, className)
{
WebInspector.BaseStorageTreeElement.call(this, storagePanel, null, domStorage.domain ? domStorage.domain : WebInspector.UIString("Local Files"), ["domstorage-storage-tree-item", className]);
@@ -1402,6 +1446,10 @@
}
WebInspector.DOMStorageTreeElement.prototype.__proto__ = WebInspector.BaseStorageTreeElement.prototype;
+/**
+ * @constructor
+ * @extends {WebInspector.BaseStorageTreeElement}
+ */
WebInspector.CookieTreeElement = function(storagePanel, cookieDomain)
{
WebInspector.BaseStorageTreeElement.call(this, storagePanel, null, cookieDomain ? cookieDomain : WebInspector.UIString("Local Files"), ["cookie-storage-tree-item"]);
@@ -1422,6 +1470,10 @@
}
WebInspector.CookieTreeElement.prototype.__proto__ = WebInspector.BaseStorageTreeElement.prototype;
+/**
+ * @constructor
+ * @extends {WebInspector.BaseStorageTreeElement}
+ */
WebInspector.ApplicationCacheTreeElement = function(storagePanel, appcacheDomain)
{
WebInspector.BaseStorageTreeElement.call(this, storagePanel, null, appcacheDomain ? appcacheDomain : WebInspector.UIString("Local Files"), ["application-cache-storage-tree-item"]);
@@ -1442,6 +1494,10 @@
}
WebInspector.ApplicationCacheTreeElement.prototype.__proto__ = WebInspector.BaseStorageTreeElement.prototype;
+/**
+ * @constructor
+ * @extends {WebInspector.BaseStorageTreeElement}
+ */
WebInspector.ResourceRevisionTreeElement = function(storagePanel, revision)
{
var title = revision.timestamp ? revision.timestamp.toLocaleTimeString() : WebInspector.UIString("(original)");
@@ -1508,12 +1564,16 @@
WebInspector.ResourceRevisionTreeElement.prototype.__proto__ = WebInspector.BaseStorageTreeElement.prototype;
+/**
+ * @constructor
+ * @extends {WebInspector.View}
+ */
WebInspector.StorageCategoryView = function()
{
WebInspector.View.call(this);
this.element.addStyleClass("storage-view");
- this._emptyView = new WebInspector.EmptyView();
+ this._emptyView = new WebInspector.EmptyView("");
this._emptyView.show(this.element);
}
@@ -1526,6 +1586,9 @@
WebInspector.StorageCategoryView.prototype.__proto__ = WebInspector.View.prototype;
+/**
+ * @constructor
+ */
WebInspector.ResourcesSearchController = function(rootElement)
{
this._root = rootElement;
@@ -1574,6 +1637,9 @@
}
}
+/**
+ * @constructor
+ */
WebInspector.SearchResultsTreeElementsTraverser = function(rootElement)
{
this._root = rootElement;
@@ -1585,7 +1651,7 @@
return this.next(this._root);
},
- last: function(startTreeElement)
+ last: function()
{
return this.previous(this._root);
},
Modified: trunk/Source/WebCore/inspector/front-end/externs.js (96928 => 96929)
--- trunk/Source/WebCore/inspector/front-end/externs.js 2011-10-07 11:11:41 UTC (rev 96928)
+++ trunk/Source/WebCore/inspector/front-end/externs.js 2011-10-07 11:35:25 UTC (rev 96929)
@@ -213,3 +213,12 @@
WebInspector.addMainEventListeners = function(doc) {}
WebInspector.openResource = function(url, external) {}
+
+DOMApplicationCache.prototype.UNCACHED = 0;
+DOMApplicationCache.prototype.IDLE = 1;
+DOMApplicationCache.prototype.CHECKING = 2;
+DOMApplicationCache.prototype.DOWNLOADING = 3;
+DOMApplicationCache.prototype.UPDATEREADY = 4;
+DOMApplicationCache.prototype.OBSOLETE = 5;
+
+WebInspector.openRequestInNetworkPanel = function(request) {}
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
