Title: [96974] trunk
- Revision
- 96974
- Author
- [email protected]
- Date
- 2011-10-07 13:05:34 -0700 (Fri, 07 Oct 2011)
Log Message
Remove compile time flag ENABLE_PASSWORD_ECHO
https://bugs.webkit.org/show_bug.cgi?id=69647
Source/WebCore:
As we have runtime flag in the page/Settings, we should remove this redundant compile time flag.
Patch by Chang Shu <[email protected]> on 2011-10-07
Reviewed by Andreas Kling.
* config.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):
Source/WebKit/qt:
As we have runtime flag in the page/Settings, we should remove this redundant compile time flag.
Patch by Chang Shu <[email protected]> on 2011-10-07
Reviewed by Andreas Kling.
* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
LayoutTests:
WK2 tests are passing after r96740 (bug 68924).
Patch by Chang Shu <[email protected]> on 2011-10-07
Reviewed by Andreas Kling.
* platform/wk2/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (96973 => 96974)
--- trunk/LayoutTests/ChangeLog 2011-10-07 19:45:14 UTC (rev 96973)
+++ trunk/LayoutTests/ChangeLog 2011-10-07 20:05:34 UTC (rev 96974)
@@ -1,3 +1,14 @@
+2011-10-07 Chang Shu <[email protected]>
+
+ Remove compile time flag ENABLE_PASSWORD_ECHO
+ https://bugs.webkit.org/show_bug.cgi?id=69647
+
+ WK2 tests are passing after r96740 (bug 68924).
+
+ Reviewed by Andreas Kling.
+
+ * platform/wk2/Skipped:
+
2011-10-07 Chris Fleizach <[email protected]>
Bug 69562 - AccessibilityImageMapLink holds onto it's parent even after it's been freed
Modified: trunk/LayoutTests/platform/wk2/Skipped (96973 => 96974)
--- trunk/LayoutTests/platform/wk2/Skipped 2011-10-07 19:45:14 UTC (rev 96973)
+++ trunk/LayoutTests/platform/wk2/Skipped 2011-10-07 20:05:34 UTC (rev 96974)
@@ -1102,13 +1102,6 @@
# missing window.internals.createShadowContentElement
fast/dom/shadow/create-content-element.html
-# WebKitTestRunner needs layoutTestController.setPasswordEchoEnabled
-# WebKitTestRunner needs layoutTestController.setPasswordEchoDuration
-editing/input/password-echo-passnode.html
-editing/input/password-echo-passnode2.html
-editing/input/password-echo-passnode3.html
-editing/input/password-echo-textnode.html
-
# WTR needs an implementation for eventSender.continuousMouseScrollBy
# https://bugs.webkit.org/show_bug.cgi?id=69417
fast/events/wheelevent-direction-inverted-from-device.html
Modified: trunk/Source/WebCore/ChangeLog (96973 => 96974)
--- trunk/Source/WebCore/ChangeLog 2011-10-07 19:45:14 UTC (rev 96973)
+++ trunk/Source/WebCore/ChangeLog 2011-10-07 20:05:34 UTC (rev 96974)
@@ -1,3 +1,16 @@
+2011-10-07 Chang Shu <[email protected]>
+
+ Remove compile time flag ENABLE_PASSWORD_ECHO
+ https://bugs.webkit.org/show_bug.cgi?id=69647
+
+ As we have runtime flag in the page/Settings, we should remove this redundant compile time flag.
+
+ Reviewed by Andreas Kling.
+
+ * config.h:
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+
2011-10-07 Chris Fleizach <[email protected]>
Bug 69562 - AccessibilityImageMapLink holds onto it's parent even after it's been freed
Modified: trunk/Source/WebCore/config.h (96973 => 96974)
--- trunk/Source/WebCore/config.h 2011-10-07 19:45:14 UTC (rev 96973)
+++ trunk/Source/WebCore/config.h 2011-10-07 20:05:34 UTC (rev 96974)
@@ -166,7 +166,6 @@
#if OS(SYMBIAN)
#define USE_SYSTEM_MALLOC 1
-#define ENABLE_PASSWORD_ECHO 1
#endif
#if OS(UNIX) || OS(WINDOWS)
Modified: trunk/Source/WebCore/page/Settings.cpp (96973 => 96974)
--- trunk/Source/WebCore/page/Settings.cpp 2011-10-07 19:45:14 UTC (rev 96973)
+++ trunk/Source/WebCore/page/Settings.cpp 2011-10-07 20:05:34 UTC (rev 96974)
@@ -215,7 +215,11 @@
#endif
, m_mediaPlaybackRequiresUserGesture(false)
, m_mediaPlaybackAllowsInline(true)
+#if OS(SYMBIAN)
+ , m_passwordEchoEnabled(true)
+#else
, m_passwordEchoEnabled(false)
+#endif
, m_suppressIncrementalRendering(false)
, m_loadsImagesAutomaticallyTimer(this, &Settings::loadsImagesAutomaticallyTimerFired)
, m_zoomAnimatorScale(1)
Modified: trunk/Source/WebKit/qt/Api/qwebsettings.cpp (96973 => 96974)
--- trunk/Source/WebKit/qt/Api/qwebsettings.cpp 2011-10-07 19:45:14 UTC (rev 96973)
+++ trunk/Source/WebKit/qt/Api/qwebsettings.cpp 2011-10-07 20:05:34 UTC (rev 96974)
@@ -284,11 +284,6 @@
settings->setNeedsSiteSpecificQuirks(value);
settings->setUsesPageCache(WebCore::pageCache()->capacity());
-
-#if ENABLE(PASSWORD_ECHO)
- settings->setPasswordEchoEnabled(true);
- settings->setPasswordEchoDurationInSeconds(1);
-#endif
} else {
QList<QWebSettingsPrivate*> settings = *::allSettings();
for (int i = 0; i < settings.count(); ++i)
Modified: trunk/Source/WebKit/qt/ChangeLog (96973 => 96974)
--- trunk/Source/WebKit/qt/ChangeLog 2011-10-07 19:45:14 UTC (rev 96973)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-10-07 20:05:34 UTC (rev 96974)
@@ -1,3 +1,15 @@
+2011-10-07 Chang Shu <[email protected]>
+
+ Remove compile time flag ENABLE_PASSWORD_ECHO
+ https://bugs.webkit.org/show_bug.cgi?id=69647
+
+ As we have runtime flag in the page/Settings, we should remove this redundant compile time flag.
+
+ Reviewed by Andreas Kling.
+
+ * Api/qwebsettings.cpp:
+ (QWebSettingsPrivate::apply):
+
2011-10-06 Fady Samuel <[email protected]>
Code clean-up: Make RenderObject::absoluteBoundingBoxRect and associated methods const and make its parameter useTransforms no longer default to false
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
