Title: [97032] trunk/Source/WebCore
- Revision
- 97032
- Author
- m...@apple.com
- Date
- 2011-10-09 13:15:47 -0700 (Sun, 09 Oct 2011)
Log Message
<rdar://problem/9484496> REGRESSION (WebKit2): Checkboxes and radio buttons are drawn 1 pixel too high, not repainted properly
https://bugs.webkit.org/show_bug.cgi?id=69727
Reviewed by Anders Carlsson.
* platform/mac/ThemeMac.mm: Made WebCoreFlippedView an NSControl subclass so that the NSButtonCell
used to draw checkboxes and radio buttons can make it its controlView, and consequently check and
obey its flippedness.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (97031 => 97032)
--- trunk/Source/WebCore/ChangeLog 2011-10-09 20:14:47 UTC (rev 97031)
+++ trunk/Source/WebCore/ChangeLog 2011-10-09 20:15:47 UTC (rev 97032)
@@ -1,3 +1,14 @@
+2011-10-09 Dan Bernstein <m...@apple.com>
+
+ <rdar://problem/9484496> REGRESSION (WebKit2): Checkboxes and radio buttons are drawn 1 pixel too high, not repainted properly
+ https://bugs.webkit.org/show_bug.cgi?id=69727
+
+ Reviewed by Anders Carlsson.
+
+ * platform/mac/ThemeMac.mm: Made WebCoreFlippedView an NSControl subclass so that the NSButtonCell
+ used to draw checkboxes and radio buttons can make it its controlView, and consequently check and
+ obey its flippedness.
+
2011-10-09 Benjamin Poulain <benja...@webkit.org>
Do not compare the first glyph to itself in Font::drawGlyphBuffer()
Modified: trunk/Source/WebCore/platform/mac/ThemeMac.mm (97031 => 97032)
--- trunk/Source/WebCore/platform/mac/ThemeMac.mm 2011-10-09 20:14:47 UTC (rev 97031)
+++ trunk/Source/WebCore/platform/mac/ThemeMac.mm 2011-10-09 20:15:47 UTC (rev 97032)
@@ -37,7 +37,7 @@
using namespace std;
// This is a view whose sole purpose is to tell AppKit that it's flipped.
-@interface WebCoreFlippedView : NSView
+@interface WebCoreFlippedView : NSControl
@end
@implementation WebCoreFlippedView
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
