Title: [97058] trunk/Source/WebCore
- Revision
- 97058
- Author
- [email protected]
- Date
- 2011-10-10 06:07:53 -0700 (Mon, 10 Oct 2011)
Log Message
[Skia on Chromium Mac] Set canExpandAroundIdeographsInComplexText to true
https://bugs.webkit.org/show_bug.cgi?id=69656
https://bugs.webkit.org/show_bug.cgi?id=62987
https://bugs.webkit.org/show_bug.cgi?id=62889
Reviewed by Stephen White.
Skia on Linux and Windows uses different font engines from
Skia on Mac. After determining that the underlying CoreText
can handle it, enabling this allows justification to work
correctly.
Tests: fast/text/justify-ideograph-complex.html
* platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::canExpandAroundIdeographsInComplexText):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (97057 => 97058)
--- trunk/Source/WebCore/ChangeLog 2011-10-10 13:04:00 UTC (rev 97057)
+++ trunk/Source/WebCore/ChangeLog 2011-10-10 13:07:53 UTC (rev 97058)
@@ -1,3 +1,22 @@
+2011-10-10 Cary Clark <[email protected]>
+
+ [Skia on Chromium Mac] Set canExpandAroundIdeographsInComplexText to true
+ https://bugs.webkit.org/show_bug.cgi?id=69656
+ https://bugs.webkit.org/show_bug.cgi?id=62987
+ https://bugs.webkit.org/show_bug.cgi?id=62889
+
+ Reviewed by Stephen White.
+
+ Skia on Linux and Windows uses different font engines from
+ Skia on Mac. After determining that the underlying CoreText
+ can handle it, enabling this allows justification to work
+ correctly.
+
+ Tests: fast/text/justify-ideograph-complex.html
+
+ * platform/graphics/skia/FontSkia.cpp:
+ (WebCore::Font::canExpandAroundIdeographsInComplexText):
+
2011-10-10 Ilya Tikhonovsky <[email protected]>
Web Inspector: memory leak in Resource panel.
Modified: trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp (97057 => 97058)
--- trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-10-10 13:04:00 UTC (rev 97057)
+++ trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-10-10 13:07:53 UTC (rev 97058)
@@ -49,12 +49,9 @@
return true;
}
-// FIXME: Determine if the Mac port of Chromium using Skia can expand around
-// ideographs in complex text. (The Windows and Linux ports for Chromium can't.)
-// This issue is tracked in https://bugs.webkit.org/show_bug.cgi?id=62987
bool Font::canExpandAroundIdeographsInComplexText()
{
- return false;
+ return true;
}
static bool isCanvasMultiLayered(SkCanvas* canvas)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
