Title: [97077] trunk/Tools
- Revision
- 97077
- Author
- commit-qu...@webkit.org
- Date
- 2011-10-10 12:52:06 -0700 (Mon, 10 Oct 2011)
Log Message
check-webkit-style: Add readability exception for Ewk_* data types.
https://bugs.webkit.org/show_bug.cgi?id=69763
Patch by Raphael Kubo da Costa <k...@profusion.mobi> on 2011-10-10
Reviewed by David Levin.
Many EFL-related files (such as EditorClientEfl.h or
DumpRenderTreeSupportEfl.h) need to have declarations such as "typedef
struct _Ewk_Foo Ewk_Foo", which currently produce false positives in
check-webkit-style.
Add an exception for them, just like there are exceptions for
Evas_*, Ecore_* and others.
* Scripts/webkitpy/style/checkers/cpp.py:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (97076 => 97077)
--- trunk/Tools/ChangeLog 2011-10-10 19:47:26 UTC (rev 97076)
+++ trunk/Tools/ChangeLog 2011-10-10 19:52:06 UTC (rev 97077)
@@ -1,3 +1,21 @@
+2011-10-10 Raphael Kubo da Costa <k...@profusion.mobi>
+
+ check-webkit-style: Add readability exception for Ewk_* data types.
+ https://bugs.webkit.org/show_bug.cgi?id=69763
+
+ Reviewed by David Levin.
+
+ Many EFL-related files (such as EditorClientEfl.h or
+ DumpRenderTreeSupportEfl.h) need to have declarations such as "typedef
+ struct _Ewk_Foo Ewk_Foo", which currently produce false positives in
+ check-webkit-style.
+
+ Add an exception for them, just like there are exceptions for
+ Evas_*, Ecore_* and others.
+
+ * Scripts/webkitpy/style/checkers/cpp.py:
+ * Scripts/webkitpy/style/checkers/cpp_unittest.py:
+
2011-10-10 Dominic Mazzoni <dmazz...@google.com>
[Chromium] Get rid of WebAccessibilityCache.
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (97076 => 97077)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-10-10 19:47:26 UTC (rev 97076)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-10-10 19:52:06 UTC (rev 97077)
@@ -3067,6 +3067,7 @@
and not modified_identifier.startswith('Ecore_')
and not modified_identifier.startswith('Eina_')
and not modified_identifier.startswith('Evas_')
+ and not modified_identifier.startswith('Ewk_')
and not modified_identifier.find('::qt_') >= 0
and not modified_identifier == "const_iterator"
and not modified_identifier == "vm_throw"):
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (97076 => 97077)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-10-10 19:47:26 UTC (rev 97076)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-10-10 19:52:06 UTC (rev 97077)
@@ -4429,6 +4429,7 @@
self.assert_lint('typedef struct _Ecore_Pipe Ecore_Pipe;', '')
self.assert_lint('typedef struct _Eina_Rectangle Eina_Rectangle;', '')
self.assert_lint('typedef struct _Evas_Object Evas_Object;', '')
+ self.assert_lint('typedef struct _Ewk_History_Item Ewk_History_Item;', '')
# NPAPI functions that start with NPN_, NPP_ or NP_ are allowed.
self.assert_lint('void NPN_Status(NPP, const char*)', '')
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
