[webkit-changes] [97281] trunk/Tools

Wed, 12 Oct 2011 11:45:34 -0700

Title: [97281] trunk/Tools
Revision
97281
Author
[email protected]
Date
2011-10-12 11:46:09 -0700 (Wed, 12 Oct 2011)

Log Message

garden-o-matic should color-code test failure types.
https://bugs.webkit.org/show_bug.cgi?id=69945

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added an extra span for styling.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Ditto.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added color-coding.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js (97280 => 97281)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js	2011-10-12 18:45:47 UTC (rev 97280)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js	2011-10-12 18:46:09 UTC (rev 97281)
@@ -91,7 +91,8 @@
         row.className = result;
         row.insertCell();
         row.insertCell();
-        row.insertCell().textContent = result;
+        var titleCell = row.insertCell();
+        titleCell.appendChild(document.createElement('span')).textContent = result;
         return row;
     },
     update: function(resultsByBuilder)

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js (97280 => 97281)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js	2011-10-12 18:45:47 UTC (rev 97280)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js	2011-10-12 18:46:09 UTC (rev 97281)
@@ -59,27 +59,27 @@
     ]);
     equal(grid.outerHTML, '<table class="failures">' +
         '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
-        '<tbody><tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr></tbody>' +
+        '<tbody><tr class="BUILDING" style="display: none; "><td><span>BUILDING</span></td><td></td><td></td></tr></tbody>' +
     '</table>');
     var row = grid._rowByResult('TEXT');
     equal(grid.outerHTML, '<table class="failures">' +
         '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
         '<tbody>' +
             '<tr class="TEXT">' +
-                '<td>TEXT</td><td></td><td></td>' +
+                '<td><span>TEXT</span></td><td></td><td></td>' +
             '</tr>' +
-            '<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +
+            '<tr class="BUILDING" style="display: none; "><td><span>BUILDING</span></td><td></td><td></td></tr>' +
         '</tbody>' +
     '</table>');
-    equal(row.outerHTML, '<tr class="TEXT"><td>TEXT</td><td></td><td></td></tr>');
+    equal(row.outerHTML, '<tr class="TEXT"><td><span>TEXT</span></td><td></td><td></td></tr>');
     grid.update({});
     equal(grid.outerHTML, '<table class="failures">' +
         '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
         '<tbody>' +
             '<tr class="TEXT">' +
-                '<td>TEXT</td><td></td><td></td>' +
+                '<td><span>TEXT</span></td><td></td><td></td>' +
             '</tr>' +
-            '<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +
+            '<tr class="BUILDING" style="display: none; "><td><span>BUILDING</span></td><td></td><td></td></tr>' +
         '</tbody>' +
     '</table>');
     raises(function() {
@@ -90,11 +90,11 @@
         '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
         '<tbody>' +
             '<tr class="TEXT">' +
-                '<td>TEXT</td>' +
+                '<td><span>TEXT</span></td>' +
                 '<td></td>' +
                 '<td><a class="failing-builder" target="_blank" href="" class="version">lucid</span><span class="architecture">64-bit</span></a></td>' +
             '</tr>' +
-            '<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +
+            '<tr class="BUILDING" style="display: none; "><td><span>BUILDING</span></td><td></td><td></td></tr>' +
         '</tbody>' +
     '</table>');
     grid.update({'Webkit Mac10.5 (CG)': { actual: 'IMAGE+TEXT'}});
@@ -102,16 +102,16 @@
         '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
         '<tbody>' +
             '<tr class="IMAGE+TEXT">' +
-                '<td>IMAGE+TEXT</td>' +
+                '<td><span>IMAGE+TEXT</span></td>' +
                 '<td><a class="failing-builder" target="_blank" href="" class="version">leopard</span><span class="graphics">CG</span></a></td>' +
                 '<td></td>' +
             '</tr>' +
             '<tr class="TEXT">' +
-                '<td>TEXT</td>' +
+                '<td><span>TEXT</span></td>' +
                 '<td></td>' +
                 '<td><a class="failing-builder" target="_blank" href="" class="version">lucid</span><span class="architecture">64-bit</span></a></td>' +
             '</tr>' +
-            '<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +
+            '<tr class="BUILDING" style="display: none; "><td><span>BUILDING</span></td><td></td><td></td></tr>' +
         '</tbody>' +
     '</table>');
     grid.update({'Webkit Mac10.5 (CG)': { actual: 'IMAGE+TEXT'}});
@@ -119,16 +119,16 @@
         '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
         '<tbody>' +
             '<tr class="IMAGE+TEXT">' +
-                '<td>IMAGE+TEXT</td>' +
+                '<td><span>IMAGE+TEXT</span></td>' +
                 '<td><a class="failing-builder" target="_blank" href="" class="version">leopard</span><span class="graphics">CG</span></a></td>' +
                 '<td></td>' +
             '</tr>' +
             '<tr class="TEXT">' +
-                '<td>TEXT</td>' +
+                '<td><span>TEXT</span></td>' +
                 '<td></td>' +
                 '<td><a class="failing-builder" target="_blank" href="" class="version">lucid</span><span class="architecture">64-bit</span></a></td>' +
             '</tr>' +
-            '<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +
+            '<tr class="BUILDING" style="display: none; "><td><span>BUILDING</span></td><td></td><td></td></tr>' +
         '</tbody>' +
     '</table>');
     grid.purge();
@@ -137,11 +137,11 @@
         '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
         '<tbody>' +
             '<tr class="TEXT">' +
-                '<td>TEXT</td>' +
+                '<td><span>TEXT</span></td>' +
                 '<td></td>' +
                 '<td><a class="failing-builder" target="_blank" href="" class="version">lucid</span><span class="architecture">64-bit</span></a></td>' +
             '</tr>' +
-            '<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +
+            '<tr class="BUILDING" style="display: none; "><td><span>BUILDING</span></td><td></td><td></td></tr>' +
         '</tbody>' +
     '</table>');
 });

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js (97280 => 97281)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js	2011-10-12 18:45:47 UTC (rev 97280)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js	2011-10-12 18:46:09 UTC (rev 97281)
@@ -104,7 +104,7 @@
             '<time class="relative"></time>' +
             '<table class="failures">' +
                 '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
-                '<tbody><tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr></tbody>' +
+                '<tbody><tr class="BUILDING" style="display: none; "><td><span>BUILDING</span></td><td></td><td></td></tr></tbody>' +
             '</table>' +
         '</div>' +
         '<div class="what">' +
@@ -124,7 +124,7 @@
             '<time class="relative"></time>' +
             '<table class="failures">' +
                 '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
-                '<tbody><tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr></tbody>' +
+                '<tbody><tr class="BUILDING" style="display: none; "><td><span>BUILDING</span></td><td></td><td></td></tr></tbody>' +
             '</table>' +
         '</div>' +
         '<div class="what">' +
@@ -147,7 +147,7 @@
             '<time class="relative"></time>' +
             '<table class="failures">' +
                 '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
-                '<tbody><tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr></tbody>' +
+                '<tbody><tr class="BUILDING" style="display: none; "><td><span>BUILDING</span></td><td></td><td></td></tr></tbody>' +
             '</table>' +
         '</div>' +
         '<div class="what">' +
@@ -172,7 +172,7 @@
             '<time class="relative">10 minutes ago</time>' +
             '<table class="failures">' +
                 '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
-                '<tbody><tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr></tbody>' +
+                '<tbody><tr class="BUILDING" style="display: none; "><td><span>BUILDING</span></td><td></td><td></td></tr></tbody>' +
             '</table>' +
         '</div>' +
         '<div class="what">' +
@@ -207,11 +207,11 @@
                 '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
                 '<tbody>' +
                     '<tr class="TEXT">' +
-                        '<td>TEXT</td>' +
+                        '<td><span>TEXT</span></td>' +
                         '<td></td>' +
                         '<td><a class="failing-builder" target="_blank" href="" class="version">lucid</span><span class="architecture">64-bit</span></a></td>' +
                     '</tr>' +
-                    '<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +
+                    '<tr class="BUILDING" style="display: none; "><td><span>BUILDING</span></td><td></td><td></td></tr>' +
                 '</tbody>' +
             '</table>' +
         '</div>' +
@@ -248,12 +248,12 @@
                 '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
                 '<tbody>' +
                     '<tr class="TEXT">' +
-                        '<td>TEXT</td>' +
+                        '<td><span>TEXT</span></td>' +
                         '<td></td>' +
                         '<td><a class="failing-builder" target="_blank" href="" class="version">lucid</span><span class="architecture">64-bit</span></a></td>' +
                     '</tr>' +
                     '<tr class="BUILDING" style="">' +
-                        '<td>BUILDING</td>' +
+                        '<td><span>BUILDING</span></td>' +
                         '<td><a class="failing-builder" target="_blank" href="" class="version">leopard</span><span class="graphics">CG</span></a></td>' +
                         '<td></td>' +
                     '</tr>' +
@@ -298,7 +298,7 @@
             '<time class="relative"></time>' +
             '<table class="failures">' +
                 '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
-                '<tbody><tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr></tbody>' +
+                '<tbody><tr class="BUILDING" style="display: none; "><td><span>BUILDING</span></td><td></td><td></td></tr></tbody>' +
             '</table>' +
         '</div>' +
         '<div class="what">' +

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css (97280 => 97281)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css	2011-10-12 18:45:47 UTC (rev 97280)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css	2011-10-12 18:46:09 UTC (rev 97281)
@@ -193,3 +193,27 @@
     ol.notifications table.failures tbody tr td:first-child {
         vertical-align: top;
     }
+
+    ol.notifications table.failures tbody tr td:first-child span {
+        padding: 0 2px;
+    }
+
+    ol.notifications table.failures tbody tr.TIMEOUT td:first-child span {
+        background-color: #fffc6c;
+    }
+
+    ol.notifications table.failures tbody tr.TEXT td:first-child span {
+        background-color: #e98080;
+    }
+
+    ol.notifications table.failures tbody tr.CRASH td:first-child span {
+        background-color: #ffc343;
+    }
+
+    ol.notifications table.failures tbody tr.IMAGE td:first-child span {
+        background-color: #69f;
+    }
+
+    ol.notifications table.failures tbody tr.IMAGE\+TEXT td:first-child span {
+        background-color: #96f;
+    }

Modified: trunk/Tools/ChangeLog (97280 => 97281)


--- trunk/Tools/ChangeLog	2011-10-12 18:45:47 UTC (rev 97280)
+++ trunk/Tools/ChangeLog	2011-10-12 18:46:09 UTC (rev 97281)
@@ -1,3 +1,15 @@
+2011-10-12  Dimitri Glazkov  <[email protected]>
+
+        garden-o-matic should color-code test failure types.
+        https://bugs.webkit.org/show_bug.cgi?id=69945
+
+        Reviewed by Adam Barth.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added an extra span for styling.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Ditto.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added color-coding.
+
 2011-10-12  Adam Barth  <[email protected]>
 
         webkitpy tests are failing on Mac bots

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to