Title: [97302] trunk/Tools
- Revision
- 97302
- Author
- [email protected]
- Date
- 2011-10-12 14:21:51 -0700 (Wed, 12 Oct 2011)
Log Message
garden-o-matic's "Expect Failure" button does not work correctly, so we should remove it until the plumbing is fixed to avoid landmines.
https://bugs.webkit.org/show_bug.cgi?id=69954
Also renamed the action and associated event name to address an FIXME.
Reviewed by Adam Barth.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed event name.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Renamed the action.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Removed action temporarily.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js (97301 => 97302)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js 2011-10-12 21:10:15 UTC (rev 97301)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js 2011-10-12 21:21:51 UTC (rev 97302)
@@ -67,7 +67,7 @@
$(this._view).bind('next', this.onNext.bind(this));
$(this._view).bind('previous', this.onPrevious.bind(this));
$(this._view).bind('rebaseline', this.onRebaseline.bind(this));
- $(this._view).bind('updateexpectations', this.onUpdateExpectations.bind(this));
+ $(this._view).bind('expectfailure', this.onUpdateExpectations.bind(this));
},
onNext: function()
{
@@ -119,7 +119,7 @@
$(failure).bind('rebaseline', function() {
this.onRebaseline(failure);
}.bind(this));
- $(failure).bind('updateexpectations', function() {
+ $(failure).bind('expectfailure', function() {
this.onUpdateExpectations(failure);
}.bind(this));
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js (97301 => 97302)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js 2011-10-12 21:10:15 UTC (rev 97301)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js 2011-10-12 21:21:51 UTC (rev 97302)
@@ -83,11 +83,10 @@
}
});
-// FIXME: Rename all the code to match the user-visible name.
-ui.actions.UpdateExpectations = base.extends(Action, {
+ui.actions.ExpectFailure = base.extends(Action, {
init: function() {
this.textContent = 'Expect Failure';
- this._eventName = 'updateexpectations';
+ this._eventName = 'expectfailure';
}
});
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js (97301 => 97302)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2011-10-12 21:10:15 UTC (rev 97301)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2011-10-12 21:21:51 UTC (rev 97302)
@@ -176,7 +176,6 @@
var header = document.createElement('h3');
$(header).append(new ui.actions.List([
new ui.actions.Rebaseline().makeDefault(),
- new ui.actions.UpdateExpectations(),
])).append(link);
this.appendChild(header);
this.appendChild(this._delegate.contentForTest(testName));
Modified: trunk/Tools/ChangeLog (97301 => 97302)
--- trunk/Tools/ChangeLog 2011-10-12 21:10:15 UTC (rev 97301)
+++ trunk/Tools/ChangeLog 2011-10-12 21:21:51 UTC (rev 97302)
@@ -1,3 +1,16 @@
+2011-10-12 Dimitri Glazkov <[email protected]>
+
+ garden-o-matic's "Expect Failure" button does not work correctly, so we should remove it until the plumbing is fixed to avoid landmines.
+ https://bugs.webkit.org/show_bug.cgi?id=69954
+
+ Also renamed the action and associated event name to address an FIXME.
+
+ Reviewed by Adam Barth.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed event name.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Renamed the action.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Removed action temporarily.
+
2011-10-12 Tony Chang <[email protected]>
stop spamming 'stopping test driver timed out, killing it' when running rwt
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
