Title: [97304] trunk/Source/WebKit2
- Revision
- 97304
- Author
- m...@apple.com
- Date
- 2011-10-12 14:34:38 -0700 (Wed, 12 Oct 2011)
Log Message
Hang beneath PluginProcessProxy::createPropertyListFile() when using a thin build
https://bugs.webkit.org/show_bug.cgi?id=69960
Reviewed by Adam Roben.
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::createPropertyListFile): Check for any non-zero return value
from posix_spawn() rather than for a negative return value. The old, incorrect check, caused
this function to hang in waitpid() after failing to spawn a plug-in process for a 32-bit plug-in
when WebKit2 was built for 64-bit only.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (97303 => 97304)
--- trunk/Source/WebKit2/ChangeLog 2011-10-12 21:25:34 UTC (rev 97303)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-12 21:34:38 UTC (rev 97304)
@@ -1,3 +1,16 @@
+2011-10-12 Dan Bernstein <m...@apple.com>
+
+ Hang beneath PluginProcessProxy::createPropertyListFile() when using a thin build
+ https://bugs.webkit.org/show_bug.cgi?id=69960
+
+ Reviewed by Adam Roben.
+
+ * UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
+ (WebKit::PluginProcessProxy::createPropertyListFile): Check for any non-zero return value
+ from posix_spawn() rather than for a negative return value. The old, incorrect check, caused
+ this function to hang in waitpid() after failing to spawn a plug-in process for a 32-bit plug-in
+ when WebKit2 was built for 64-bit only.
+
2011-10-12 Jesus Sanchez-Palencia <jesus.palen...@openbossa.org>
[Qt][WK2] Move qweberror* out of API/qt
Modified: trunk/Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm (97303 => 97304)
--- trunk/Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm 2011-10-12 21:25:34 UTC (rev 97303)
+++ trunk/Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm 2011-10-12 21:34:38 UTC (rev 97304)
@@ -97,7 +97,7 @@
int result = posix_spawn(&pid, args[0], 0, &attr, const_cast<char* const*>(args), environmentVariables.environmentPointer());
posix_spawnattr_destroy(&attr);
- if (result < 0)
+ if (result)
return false;
int status;
if (waitpid(pid, &status, 0) < 0)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
