Title: [97326] trunk
- Revision
- 97326
- Author
- [email protected]
- Date
- 2011-10-12 17:50:54 -0700 (Wed, 12 Oct 2011)
Log Message
Implement a WebKitTransitionEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=69911
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/webkit-transition-event-constructor.html
* bindings/v8/custom/V8EventConstructors.cpp: Added a WebKitTransitionEvent constructor.
* dom/WebKitTransitionEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.
LayoutTests:
Enabled webkit-transition-event-constructor.html, since now V8 has the WebKitTransitionEvent constructor.
* platform/chromium/test_expectations.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (97325 => 97326)
--- trunk/LayoutTests/ChangeLog 2011-10-13 00:37:40 UTC (rev 97325)
+++ trunk/LayoutTests/ChangeLog 2011-10-13 00:50:54 UTC (rev 97326)
@@ -1,3 +1,14 @@
+2011-10-12 Kentaro Hara <[email protected]>
+
+ Implement a WebKitTransitionEvent constructor for V8
+ https://bugs.webkit.org/show_bug.cgi?id=69911
+
+ Reviewed by Adam Barth.
+
+ Enabled webkit-transition-event-constructor.html, since now V8 has the WebKitTransitionEvent constructor.
+
+ * platform/chromium/test_expectations.txt:
+
2011-10-12 Ojan Vafai <[email protected]>
make fast/writing-mode/margins.html a reftest to avoid cross-platform differences
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97325 => 97326)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 00:37:40 UTC (rev 97325)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 00:50:54 UTC (rev 97326)
@@ -83,9 +83,6 @@
// Tests for WebVTT parser for <track>. Feature is not yet functional.
BUGWK43668 SKIP : media/track/ = TIMEOUT
-// This will soon be fixed after implementing a WebKitTransitionEvent constructor for V8.
-BUGWK69829 : fast/events/constructors/webkit-transition-event-constructor.html = FAIL
-
// Tests for MediaSource API. Feature is not yet functional.
BUGWK64731 SKIP : http/tests/media/media-source/ = TIMEOUT
Modified: trunk/Source/WebCore/ChangeLog (97325 => 97326)
--- trunk/Source/WebCore/ChangeLog 2011-10-13 00:37:40 UTC (rev 97325)
+++ trunk/Source/WebCore/ChangeLog 2011-10-13 00:50:54 UTC (rev 97326)
@@ -1,5 +1,17 @@
2011-10-12 Kentaro Hara <[email protected]>
+ Implement a WebKitTransitionEvent constructor for V8
+ https://bugs.webkit.org/show_bug.cgi?id=69911
+
+ Reviewed by Adam Barth.
+
+ Test: fast/events/constructors/webkit-transition-event-constructor.html
+
+ * bindings/v8/custom/V8EventConstructors.cpp: Added a WebKitTransitionEvent constructor.
+ * dom/WebKitTransitionEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.
+
+2011-10-12 Kentaro Hara <[email protected]>
+
Implement a BeforeLoadEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=69893
Modified: trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp (97325 => 97326)
--- trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-10-13 00:37:40 UTC (rev 97325)
+++ trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-10-13 00:50:54 UTC (rev 97326)
@@ -42,6 +42,7 @@
#include "PopStateEvent.h"
#include "ProgressEvent.h"
#include "WebKitAnimationEvent.h"
+#include "WebKitTransitionEvent.h"
#include "OptionsObject.h"
#include "V8Binding.h"
@@ -58,6 +59,7 @@
#include "V8ProgressEvent.h"
#include "V8Proxy.h"
#include "V8WebKitAnimationEvent.h"
+#include "V8WebKitTransitionEvent.h"
#include <wtf/RefPtr.h>
@@ -120,6 +122,7 @@
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_PAGE_TRANSITION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_ERROR_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_POP_STATE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
+INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_WEBKIT_TRANSITION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
} // namespace WebCore
Modified: trunk/Source/WebCore/dom/WebKitTransitionEvent.idl (97325 => 97326)
--- trunk/Source/WebCore/dom/WebKitTransitionEvent.idl 2011-10-13 00:37:40 UTC (rev 97325)
+++ trunk/Source/WebCore/dom/WebKitTransitionEvent.idl 2011-10-13 00:50:54 UTC (rev 97326)
@@ -27,7 +27,7 @@
interface [
CanBeConstructed,
- JSCustomConstructor
+ CustomConstructor
] WebKitTransitionEvent : Event {
readonly attribute DOMString propertyName;
readonly attribute double elapsedTime;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
