Title: [97445] trunk/Source/WebCore
- Revision
- 97445
- Author
- [email protected]
- Date
- 2011-10-13 23:57:10 -0700 (Thu, 13 Oct 2011)
Log Message
[Chromium] Uninitialized read in WebCore::*Font* / HB_GSUB_Select_Feature
https://bugs.webkit.org/show_bug.cgi?id=70087
Reviewed by Kent Tamura.
Initialize local variables in ComplexTextControllerLinux::setupfontFeatures.
No new tests because there is no behavior change. Manually tested with valgrind.
* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::setupFontFeatures):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (97444 => 97445)
--- trunk/Source/WebCore/ChangeLog 2011-10-14 06:24:10 UTC (rev 97444)
+++ trunk/Source/WebCore/ChangeLog 2011-10-14 06:57:10 UTC (rev 97445)
@@ -1,3 +1,17 @@
+2011-10-13 Kenichi Ishibashi <[email protected]>
+
+ [Chromium] Uninitialized read in WebCore::*Font* / HB_GSUB_Select_Feature
+ https://bugs.webkit.org/show_bug.cgi?id=70087
+
+ Reviewed by Kent Tamura.
+
+ Initialize local variables in ComplexTextControllerLinux::setupfontFeatures.
+
+ No new tests because there is no behavior change. Manually tested with valgrind.
+
+ * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
+ (WebCore::setupFontFeatures):
+
2011-10-13 Csaba Osztrogonác <[email protected]>
[Qt][Win] Unreviewed buildfix after r97433.
Modified: trunk/Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp (97444 => 97445)
--- trunk/Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp 2011-10-14 06:24:10 UTC (rev 97444)
+++ trunk/Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp 2011-10-14 06:57:10 UTC (rev 97445)
@@ -220,13 +220,13 @@
if (hbFace->gpos)
HB_GPOS_Clear_Features(hbFace->gpos);
- HB_UShort scriptIndex;
+ HB_UShort scriptIndex = 0;
HB_GSUB_Select_Script(hbFace->gsub, HB_MAKE_TAG('D', 'F', 'L', 'T'), &scriptIndex);
size_t numFeatures = settings->size();
for (size_t i = 0; i < numFeatures; ++i) {
if (!settings->at(i).value())
continue;
- HB_UShort featureIndex;
+ HB_UShort featureIndex = 0;
const UChar* tag = settings->at(i).tag().characters();
HB_UInt feature = HB_MAKE_TAG(tag[0], tag[1], tag[2], tag[3]);
if (hbFace->gsub && HB_GSUB_Select_Feature(hbFace->gsub, feature, scriptIndex, 0xffff, &featureIndex) == HB_Err_Ok)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
