Title: [97531] trunk/Source/WebCore
Revision
97531
Author
[email protected]
Date
2011-10-14 16:42:04 -0700 (Fri, 14 Oct 2011)

Log Message

Unreviewed, rolling out r97519.
http://trac.webkit.org/changeset/97519
https://bugs.webkit.org/show_bug.cgi?id=70156

Broke 79+ tests on bots (Requested by dglazkov on #webkit).

Patch by Sheriff Bot <[email protected]> on 2011-10-14

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (97530 => 97531)


--- trunk/Source/WebCore/ChangeLog	2011-10-14 23:13:28 UTC (rev 97530)
+++ trunk/Source/WebCore/ChangeLog	2011-10-14 23:42:04 UTC (rev 97531)
@@ -1,3 +1,15 @@
+2011-10-14  Sheriff Bot  <[email protected]>
+
+        Unreviewed, rolling out r97519.
+        http://trac.webkit.org/changeset/97519
+        https://bugs.webkit.org/show_bug.cgi?id=70156
+
+        Broke 79+ tests on bots (Requested by dglazkov on #webkit).
+
+        * platform/graphics/skia/GraphicsContextSkia.cpp:
+        (WebCore::getFocusRingOutset):
+        (WebCore::GraphicsContext::drawFocusRing):
+
 2011-09-28  Robert Hogan  <[email protected]>
 
         Replaced elements squeezed when width is specified as percentage inside a table with Auto layout

Modified: trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp (97530 => 97531)


--- trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp	2011-10-14 23:13:28 UTC (rev 97530)
+++ trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp	2011-10-14 23:42:04 UTC (rev 97531)
@@ -538,16 +538,16 @@
 #endif
 }
 
-static inline int getFocusRingOutset(int offset)
+static inline SkScalar getFocusRingOutset()
 {
 #if PLATFORM(CHROMIUM) && OS(DARWIN)
-    return offset + 2;
+    return 0.75f;
 #else
-    return 0;
+    return 0.5f;
 #endif
 }
 
-void GraphicsContext::drawFocusRing(const Vector<IntRect>& rects, int width, int offset, const Color& color)
+void GraphicsContext::drawFocusRing(const Vector<IntRect>& rects, int width, int /* offset */, const Color& color)
 {
     if (paintingDisabled())
         return;
@@ -557,7 +557,7 @@
         return;
 
     SkRegion focusRingRegion;
-    const int focusRingOutset = getFocusRingOutset(offset);
+    const SkScalar focusRingOutset = getFocusRingOutset();
     for (unsigned i = 0; i < rectCount; i++) {
         SkIRect r = rects[i];
         r.inset(-focusRingOutset, -focusRingOutset);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to