Title: [97572] trunk/Source/WebCore
- Revision
- 97572
- Author
- [email protected]
- Date
- 2011-10-15 22:00:15 -0700 (Sat, 15 Oct 2011)
Log Message
2011-10-15 Eric Carlson <[email protected]>
Make VIDEO_TRACK compile with warnings as errors enabled
https://bugs.webkit.org/show_bug.cgi?id=70188
Reviewed by Filip Pizlo.
No new tests, no functionality changed.
* html/TextTrackCueList.h: Fix an include.
* html/track/CueParser.cpp:
(WebCore::CueParser::supportsType): Remove unused param.
* html/track/CueParser.h:
(WebCore::CueParserClient::~CueParserClient): Add virtual destructor.
* html/track/CueParserPrivate.h:
(WebCore::CueParserPrivateClient::~CueParserPrivateClient): Ditto.
* loader/CueLoader.h:
(WebCore::CueLoaderClient::~CueLoaderClient): Ditto.
(WebCore::CueLoader::~CueLoader): Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (97571 => 97572)
--- trunk/Source/WebCore/ChangeLog 2011-10-16 04:35:21 UTC (rev 97571)
+++ trunk/Source/WebCore/ChangeLog 2011-10-16 05:00:15 UTC (rev 97572)
@@ -1,3 +1,23 @@
+2011-10-15 Eric Carlson <[email protected]>
+
+ Make VIDEO_TRACK compile with warnings as errors enabled
+ https://bugs.webkit.org/show_bug.cgi?id=70188
+
+ Reviewed by Filip Pizlo.
+
+ No new tests, no functionality changed.
+
+ * html/TextTrackCueList.h: Fix an include.
+ * html/track/CueParser.cpp:
+ (WebCore::CueParser::supportsType): Remove unused param.
+ * html/track/CueParser.h:
+ (WebCore::CueParserClient::~CueParserClient): Add virtual destructor.
+ * html/track/CueParserPrivate.h:
+ (WebCore::CueParserPrivateClient::~CueParserPrivateClient): Ditto.
+ * loader/CueLoader.h:
+ (WebCore::CueLoaderClient::~CueLoaderClient): Ditto.
+ (WebCore::CueLoader::~CueLoader): Ditto.
+
2011-10-15 Adam Barth <[email protected]>
Rename ENABLE(TILED_BACKING_STORE) to USE(TILED_BACKING_STORE)
Modified: trunk/Source/WebCore/html/TextTrackCueList.h (97571 => 97572)
--- trunk/Source/WebCore/html/TextTrackCueList.h 2011-10-16 04:35:21 UTC (rev 97571)
+++ trunk/Source/WebCore/html/TextTrackCueList.h 2011-10-16 05:00:15 UTC (rev 97572)
@@ -28,8 +28,8 @@
#if ENABLE(VIDEO_TRACK)
-#include "PassRefPtr.h"
#include "TextTrackCue.h"
+#include <wtf/PassRefPtr.h>
#include <wtf/RefCounted.h>
#include <wtf/Vector.h>
Modified: trunk/Source/WebCore/html/track/CueParser.cpp (97571 => 97572)
--- trunk/Source/WebCore/html/track/CueParser.cpp 2011-10-16 04:35:21 UTC (rev 97571)
+++ trunk/Source/WebCore/html/track/CueParser.cpp 2011-10-16 05:00:15 UTC (rev 97572)
@@ -66,7 +66,7 @@
m_loader = ThreadableLoader::create(context, this, request, options);
}
-bool CueParser::supportsType(const String& url)
+bool CueParser::supportsType(const String&)
{
// FIXME(62893): check against a list of supported types
return false;
Modified: trunk/Source/WebCore/html/track/CueParser.h (97571 => 97572)
--- trunk/Source/WebCore/html/track/CueParser.h 2011-10-16 04:35:21 UTC (rev 97571)
+++ trunk/Source/WebCore/html/track/CueParser.h 2011-10-16 05:00:15 UTC (rev 97572)
@@ -47,6 +47,8 @@
class CueParserClient {
public:
+ virtual ~CueParserClient() { }
+
virtual void newCuesParsed() = 0;
virtual void trackLoadStarted() = 0;
virtual void trackLoadError() = 0;
Modified: trunk/Source/WebCore/html/track/CueParserPrivate.h (97571 => 97572)
--- trunk/Source/WebCore/html/track/CueParserPrivate.h 2011-10-16 04:35:21 UTC (rev 97571)
+++ trunk/Source/WebCore/html/track/CueParserPrivate.h 2011-10-16 05:00:15 UTC (rev 97572)
@@ -42,6 +42,8 @@
class CueParserPrivateClient {
public:
+ virtual ~CueParserPrivateClient() { }
+
virtual void newCuesParsed() = 0;
};
Modified: trunk/Source/WebCore/loader/CueLoader.h (97571 => 97572)
--- trunk/Source/WebCore/loader/CueLoader.h 2011-10-16 04:35:21 UTC (rev 97571)
+++ trunk/Source/WebCore/loader/CueLoader.h 2011-10-16 05:00:15 UTC (rev 97572)
@@ -39,6 +39,8 @@
// Listener to CueLoader.
class CueLoaderClient {
public:
+ virtual ~CueLoaderClient() { }
+
// Queries CueLoader for newest cues.
virtual void fetchNewCuesFromLoader(CueLoader*) = 0;
virtual void removeCuesFromIndex(const TextTrackCueList*) = 0;
@@ -46,6 +48,8 @@
class CueLoader {
public:
+ virtual ~CueLoader() { }
+
void setCueLoaderClient(CueLoaderClient*);
// Informs client that new cues have been loaded.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
