Title: [97589] trunk/Source
- Revision
- 97589
- Author
- [email protected]
- Date
- 2011-10-16 23:32:16 -0700 (Sun, 16 Oct 2011)
Log Message
Always disable ENABLE(ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL) and delete associated code
https://bugs.webkit.org/show_bug.cgi?id=70216
Reviewed by Eric Seidel.
Source/_javascript_Core:
* wtf/Platform.h:
Source/WebCore:
No port enables this feature. It was added for the previous Android
port (and should have been an editing behavior in any case).
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updateFocusAppearance):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (97588 => 97589)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-17 06:29:29 UTC (rev 97588)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-17 06:32:16 UTC (rev 97589)
@@ -1,3 +1,12 @@
+2011-10-16 Adam Barth <[email protected]>
+
+ Always disable ENABLE(ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL) and delete associated code
+ https://bugs.webkit.org/show_bug.cgi?id=70216
+
+ Reviewed by Eric Seidel.
+
+ * wtf/Platform.h:
+
2011-10-16 Noel Gordon <[email protected]>
[chromium] Remove PageAllocatorSymbian.h, OSAllocatorSymbian.cpp, gtk/ThreadingGtk.cpp from gyp project files
Modified: trunk/Source/_javascript_Core/wtf/Platform.h (97588 => 97589)
--- trunk/Source/_javascript_Core/wtf/Platform.h 2011-10-17 06:29:29 UTC (rev 97588)
+++ trunk/Source/_javascript_Core/wtf/Platform.h 2011-10-17 06:32:16 UTC (rev 97589)
@@ -837,10 +837,6 @@
#define ENABLE_TEXT_CARET 1
#endif
-#if !defined(ENABLE_ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL)
-#define ENABLE_ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL 0
-#endif
-
#if !defined(ENABLE_FULLSCREEN_API)
#define ENABLE_FULLSCREEN_API 0
#endif
Modified: trunk/Source/WebCore/ChangeLog (97588 => 97589)
--- trunk/Source/WebCore/ChangeLog 2011-10-17 06:29:29 UTC (rev 97588)
+++ trunk/Source/WebCore/ChangeLog 2011-10-17 06:32:16 UTC (rev 97589)
@@ -1,3 +1,16 @@
+2011-10-16 Adam Barth <[email protected]>
+
+ Always disable ENABLE(ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL) and delete associated code
+ https://bugs.webkit.org/show_bug.cgi?id=70216
+
+ Reviewed by Eric Seidel.
+
+ No port enables this feature. It was added for the previous Android
+ port (and should have been an editing behavior in any case).
+
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::updateFocusAppearance):
+
2011-10-16 Ryosuke Niwa <[email protected]>
Expose rangeFromLocationAndLength and locationAndLengthFromRange via internals object
Modified: trunk/Source/WebCore/html/HTMLTextAreaElement.cpp (97588 => 97589)
--- trunk/Source/WebCore/html/HTMLTextAreaElement.cpp 2011-10-17 06:29:29 UTC (rev 97588)
+++ trunk/Source/WebCore/html/HTMLTextAreaElement.cpp 2011-10-17 06:32:16 UTC (rev 97589)
@@ -198,17 +198,10 @@
ASSERT(!document()->childNeedsAndNotInStyleRecalc());
if (!restorePreviousSelection || !hasCachedSelection()) {
-#if ENABLE(ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL)
- // Devices with trackballs or d-pads may focus on a textarea in route
- // to another focusable node. By selecting all text, the next movement
- // can more readily be interpreted as moving to the next node.
- select();
-#else
// If this is the first focus, set a caret at the beginning of the text.
// This matches some browsers' behavior; see bug 11746 Comment #15.
// http://bugs.webkit.org/show_bug.cgi?id=11746#c15
setSelectionRange(0, 0);
-#endif
} else
restoreCachedSelection();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
