Title: [97682] trunk/Source/WebKit/efl
Revision
97682
Author
[email protected]
Date
2011-10-17 17:44:33 -0700 (Mon, 17 Oct 2011)

Log Message

[EFL] Do not check for Frame::contentRenderer() in ewk_view_repaint.
https://bugs.webkit.org/show_bug.cgi?id=70118

Patch by Raphael Kubo da Costa <[email protected]> on 2011-10-17
Reviewed by Kenneth Rohde Christiansen.

When we have a scrollbar with an actual width, there might be a call
to ChromeClientEfl::invalidateContentsAndWindow() after
Document::detach() was called, making the call to contentRenderer()
return 0 even though everything is fine.

Example test case: animations/animation-shorthand.html.

* ewk/ewk_view.cpp:
(ewk_view_repaint):

Modified Paths

Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (97681 => 97682)


--- trunk/Source/WebKit/efl/ChangeLog	2011-10-18 00:41:29 UTC (rev 97681)
+++ trunk/Source/WebKit/efl/ChangeLog	2011-10-18 00:44:33 UTC (rev 97682)
@@ -1,5 +1,22 @@
 2011-10-17  Raphael Kubo da Costa  <[email protected]>
 
+        [EFL] Do not check for Frame::contentRenderer() in ewk_view_repaint.
+        https://bugs.webkit.org/show_bug.cgi?id=70118
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        When we have a scrollbar with an actual width, there might be a call
+        to ChromeClientEfl::invalidateContentsAndWindow() after
+        Document::detach() was called, making the call to contentRenderer()
+        return 0 even though everything is fine.
+
+        Example test case: animations/animation-shorthand.html.
+
+        * ewk/ewk_view.cpp:
+        (ewk_view_repaint):
+
+2011-10-17  Raphael Kubo da Costa  <[email protected]>
+
         [EFL] Set a default charset when creating a view.
         https://bugs.webkit.org/show_bug.cgi?id=69771
 

Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (97681 => 97682)


--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2011-10-18 00:41:29 UTC (rev 97681)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2011-10-18 00:44:33 UTC (rev 97682)
@@ -3294,11 +3294,6 @@
     EWK_VIEW_SD_GET_OR_RETURN(ewkView, sd);
     EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv);
 
-    if (!priv->main_frame->contentRenderer()) {
-        ERR("no main frame content renderer.");
-        return;
-    }
-
     _ewk_view_repaint_add(priv, x, y, width, height);
     _ewk_view_smart_changed(sd);
 }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to