Title: [97778] trunk/Source/WebCore
- Revision
- 97778
- Author
- [email protected]
- Date
- 2011-10-18 11:18:36 -0700 (Tue, 18 Oct 2011)
Log Message
Change CodeGeneratorGObject.pm to use g_value_get_uint() instead of g_value_get_ushort()
for IDL attributes of type unsigned short.
https://bugs.webkit.org/show_bug.cgi?id=70267
Reviewed by Xan Lopez.
Tests: small change to WebKitDOMTestObj.cpp
* bindings/scripts/CodeGeneratorGObject.pm:
(GetGValueTypeName): convert unsigned short to uint instead of ushort
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_set_property): expect g_value_get_uint instead of g_value_get_ushort
(webkit_dom_test_obj_class_init): expect G_MAXUSHORT instead of G_MAXUINT16
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (97777 => 97778)
--- trunk/Source/WebCore/ChangeLog 2011-10-18 18:06:01 UTC (rev 97777)
+++ trunk/Source/WebCore/ChangeLog 2011-10-18 18:18:36 UTC (rev 97778)
@@ -1,3 +1,19 @@
+2011-10-18 Anna Cavender <[email protected]>
+
+ Change CodeGeneratorGObject.pm to use g_value_get_uint() instead of g_value_get_ushort()
+ for IDL attributes of type unsigned short.
+ https://bugs.webkit.org/show_bug.cgi?id=70267
+
+ Reviewed by Xan Lopez.
+
+ Tests: small change to WebKitDOMTestObj.cpp
+
+ * bindings/scripts/CodeGeneratorGObject.pm:
+ (GetGValueTypeName): convert unsigned short to uint instead of ushort
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
+ (webkit_dom_test_obj_set_property): expect g_value_get_uint instead of g_value_get_ushort
+ (webkit_dom_test_obj_class_init): expect G_MAXUSHORT instead of G_MAXUINT16
+
2011-10-18 Vsevolod Vlasov <[email protected]>
Web Inspector: ScriptsPanel's should use similar logic to decide whether it could show an anchor location and actually showing it.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (97777 => 97778)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2011-10-18 18:06:01 UTC (rev 97777)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2011-10-18 18:18:36 UTC (rev 97778)
@@ -242,7 +242,7 @@
"unsigned int", "uint",
"unsigned long long", "uint64",
"unsigned long", "ulong",
- "unsigned short", "ushort");
+ "unsigned short", "uint");
return $types{$type} ? $types{$type} : "object";
}
Modified: trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp (97777 => 97778)
--- trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp 2011-10-18 18:06:01 UTC (rev 97777)
+++ trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp 2011-10-18 18:18:36 UTC (rev 97778)
@@ -1198,7 +1198,7 @@
switch (prop_id) {
case PROP_UNSIGNED_SHORT_ATTR:
{
- coreSelf->setUnsignedShortAttr((g_value_get_ushort(value)));
+ coreSelf->setUnsignedShortAttr((g_value_get_uint(value)));
break;
}
case PROP_INT_ATTR:
@@ -1580,7 +1580,7 @@
"test_obj_unsigned-short-attr", /* short description */
"read-write gushort TestObj.unsigned-short-attr", /* longer - could do with some extra doc stuff here */
0, /* min */
-G_MAXUINT16, /* max */
+G_MAXUSHORT, /* max */
0, /* default */
WEBKIT_PARAM_READWRITE));
g_object_class_install_property(gobjectClass,
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
