Title: [97796] trunk/Source/WebCore
- Revision
- 97796
- Author
- [email protected]
- Date
- 2011-10-18 15:38:29 -0700 (Tue, 18 Oct 2011)
Log Message
fix unused-but-set-variable warnings in WebCore
https://bugs.webkit.org/show_bug.cgi?id=70344
Reviewed by Adam Barth.
This is a new compiler warning in gcc 4.6.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::isWrapperOfType):
* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::ComplexTextController::normalizeSpacesAndMirrorChars):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (97795 => 97796)
--- trunk/Source/WebCore/ChangeLog 2011-10-18 22:37:40 UTC (rev 97795)
+++ trunk/Source/WebCore/ChangeLog 2011-10-18 22:38:29 UTC (rev 97796)
@@ -1,3 +1,17 @@
+2011-10-18 Tony Chang <[email protected]>
+
+ fix unused-but-set-variable warnings in WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=70344
+
+ Reviewed by Adam Barth.
+
+ This is a new compiler warning in gcc 4.6.
+
+ * bindings/v8/V8DOMWrapper.cpp:
+ (WebCore::V8DOMWrapper::isWrapperOfType):
+ * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
+ (WebCore::ComplexTextController::normalizeSpacesAndMirrorChars):
+
2011-10-18 Dan Bernstein <[email protected]>
Certain column-rule styles render incorrectly in vertical writing modes
Modified: trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp (97795 => 97796)
--- trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp 2011-10-18 22:37:40 UTC (rev 97795)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp 2011-10-18 22:38:29 UTC (rev 97796)
@@ -312,7 +312,7 @@
ASSERT(object->InternalFieldCount() >= v8DefaultWrapperInternalFieldCount);
v8::Handle<v8::Value> wrapper = object->GetInternalField(v8DOMWrapperObjectIndex);
- ASSERT(wrapper->IsNumber() || wrapper->IsExternal());
+ ASSERT_UNUSED(wrapper, wrapper->IsNumber() || wrapper->IsExternal());
WrapperTypeInfo* typeInfo = static_cast<WrapperTypeInfo*>(object->GetPointerFromInternalField(v8DOMWrapperTypeIndex));
return typeInfo == type;
Modified: trunk/Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp (97795 => 97796)
--- trunk/Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp 2011-10-18 22:37:40 UTC (rev 97795)
+++ trunk/Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp 2011-10-18 22:38:29 UTC (rev 97796)
@@ -396,7 +396,7 @@
else if (rtl)
character = u_charMirror(character);
U16_APPEND(destination, position, length, character, error);
- ASSERT(!error);
+ ASSERT_UNUSED(error, !error);
position = nextPosition;
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
