Modified: trunk/Source/WebCore/ChangeLog (200196 => 200197)
--- trunk/Source/WebCore/ChangeLog 2016-04-28 17:34:24 UTC (rev 200196)
+++ trunk/Source/WebCore/ChangeLog 2016-04-28 17:35:45 UTC (rev 200197)
@@ -1,3 +1,14 @@
+2016-04-28 Youenn Fablet <[email protected]>
+
+ Drop [UsePointersEvenForNonNullableObjectArguments] from Node
+ https://bugs.webkit.org/show_bug.cgi?id=156978
+
+ Reviewed by Chris Dumez.
+
+ No change of behavior.
+
+ * dom/Node.idl: Marking some parameters nullable.
+
2016-04-27 Ada Chan <[email protected]>
Set overflow: hidden on ::-webkit-media-controls in mediaControlsApple.css
Modified: trunk/Source/WebCore/dom/Node.idl (200196 => 200197)
--- trunk/Source/WebCore/dom/Node.idl 2016-04-28 17:34:24 UTC (rev 200196)
+++ trunk/Source/WebCore/dom/Node.idl 2016-04-28 17:35:45 UTC (rev 200197)
@@ -19,14 +19,13 @@
*/
[
+ CustomIsReachable,
+ CustomToJSObject,
+ ExportMacro=WEBCORE_EXPORT,
JSCustomHeader,
JSCustomMarkFunction,
JSCustomPushEventHandlerScope,
- CustomIsReachable,
- CustomToJSObject,
- UsePointersEvenForNonNullableObjectArguments,
ObjCPolymorphic,
- ExportMacro=WEBCORE_EXPORT,
] interface Node
#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
: Object, EventTarget
@@ -64,12 +63,16 @@
readonly attribute Node rootNode;
- [ObjCLegacyUnnamedParameters, Custom, RaisesException] Node insertBefore([CustomReturn] Node newChild,
- Node refChild);
- [ObjCLegacyUnnamedParameters, Custom, RaisesException] Node replaceChild(Node newChild,
- [CustomReturn] Node oldChild);
- [Custom, RaisesException] Node removeChild([CustomReturn] Node oldChild);
- [Custom, RaisesException] Node appendChild([CustomReturn] Node newChild);
+ // FIXME: newChild should not be nullable.
+ [ObjCLegacyUnnamedParameters, Custom, RaisesException] Node insertBefore([CustomReturn] Node? newChild,
+ Node? refChild);
+ // FIXME: newChild and oldChild should not be nullable.
+ [ObjCLegacyUnnamedParameters, Custom, RaisesException] Node replaceChild(Node? newChild,
+ [CustomReturn] Node? oldChild);
+ // FIXME: oldChild should not be nullable.
+ [Custom, RaisesException] Node removeChild([CustomReturn] Node? oldChild);
+ // FIXME: newChild should not be nullable.
+ [Custom, RaisesException] Node appendChild([CustomReturn] Node? newChild);
boolean hasChildNodes();
@@ -101,8 +104,10 @@
// FIXME: the spec says this can also raise on retrieval.
[SetterRaisesException] attribute DOMString? textContent;
- boolean isSameNode(optional Node other = null);
- boolean isEqualNode(optional Node other = null);
+ // FIXME: other should not be optional.
+ boolean isSameNode(optional Node? other = null);
+ // FIXME: other should not be optional.
+ boolean isEqualNode(optional Node? other = null);
DOMString? lookupPrefix(optional DOMString? namespaceURI = null);
boolean isDefaultNamespace(optional DOMString? namespaceURI = null);
@@ -116,10 +121,12 @@
const unsigned short DOCUMENT_POSITION_CONTAINED_BY = 0x10;
const unsigned short DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC = 0x20;
- unsigned short compareDocumentPosition(optional Node other = null);
+ // FIXME: other should be neither optional nor nullable.
+ unsigned short compareDocumentPosition(optional Node? other = null);
// Introduced in DOM4
- boolean contains(optional Node other = null);
+ // FIXME: other should not be optional.
+ boolean contains(optional Node? other = null);
// IE extensions
readonly attribute Element parentElement;
