Title: [200201] trunk/Source
Revision
200201
Author
[email protected]
Date
2016-04-28 11:41:50 -0700 (Thu, 28 Apr 2016)

Log Message

Fix the Apple Internal OS X build

Source/WebCore:

* platform/graphics/mac/PDFDocumentImageMac.mm:
(WebCore::PDFDocumentImage::drawPDFPage): Ignore deprecation warning for -[PDFPage drawWithBox:].

Source/WebKit/mac:

* WebView/WebPDFView.h: Import PDFKit for definition of protocol PDFViewDelegate.
Forward declare protocol PDFViewDelegate as appropriate. Mark WebPDFView as implementing
protocol PDFViewDelegate.
* WebView/WebPDFView.mm: Move import of PDFKit from here to the header.

Source/WebKit2:

* UIProcess/mac/WKPrintingView.mm:
(-[WKPrintingView _drawPDFDocument:page:atPoint:]): Ignore deprecation warning for -[PDFPage drawWithBox:].
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::drawPDFPage): Ditto.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (200200 => 200201)


--- trunk/Source/WebCore/ChangeLog	2016-04-28 18:18:58 UTC (rev 200200)
+++ trunk/Source/WebCore/ChangeLog	2016-04-28 18:41:50 UTC (rev 200201)
@@ -1,3 +1,10 @@
+2016-04-28  Daniel Bates  <[email protected]>
+
+        Fix the Apple Internal OS X build
+
+        * platform/graphics/mac/PDFDocumentImageMac.mm:
+        (WebCore::PDFDocumentImage::drawPDFPage): Ignore deprecation warning for -[PDFPage drawWithBox:].
+
 2016-04-28  Youenn Fablet  <[email protected]>
 
         Drop [UsePointersEvenForNonNullableObjectArguments] from MediaSource interfaces

Modified: trunk/Source/WebCore/platform/graphics/mac/PDFDocumentImageMac.mm (200200 => 200201)


--- trunk/Source/WebCore/platform/graphics/mac/PDFDocumentImageMac.mm	2016-04-28 18:18:58 UTC (rev 200200)
+++ trunk/Source/WebCore/platform/graphics/mac/PDFDocumentImageMac.mm	2016-04-28 18:41:50 UTC (rev 200201)
@@ -76,7 +76,10 @@
     bool allowsSmoothing = CGContextGetAllowsFontSmoothing(context.platformContext());
     bool allowsSubpixelQuantization = CGContextGetAllowsFontSubpixelQuantization(context.platformContext());
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
     [[m_document pageAtIndex:0] drawWithBox:kPDFDisplayBoxCropBox];
+#pragma clang diagnostic pop
 
     CGContextSetAllowsFontSmoothing(context.platformContext(), allowsSmoothing);
     CGContextSetAllowsFontSubpixelQuantization(context.platformContext(), allowsSubpixelQuantization);

Modified: trunk/Source/WebKit/mac/ChangeLog (200200 => 200201)


--- trunk/Source/WebKit/mac/ChangeLog	2016-04-28 18:18:58 UTC (rev 200200)
+++ trunk/Source/WebKit/mac/ChangeLog	2016-04-28 18:41:50 UTC (rev 200201)
@@ -1,3 +1,12 @@
+2016-04-28  Daniel Bates  <[email protected]>
+
+        Fix the Apple Internal OS X build
+
+        * WebView/WebPDFView.h: Import PDFKit for definition of protocol PDFViewDelegate.
+        Forward declare protocol PDFViewDelegate as appropriate. Mark WebPDFView as implementing
+        protocol PDFViewDelegate.
+        * WebView/WebPDFView.mm: Move import of PDFKit from here to the header.
+
 2016-04-27  Daniel Bates  <[email protected]>
 
         CSP: Add app-specific workaround for Ecobee and Quora

Modified: trunk/Source/WebKit/mac/WebView/WebPDFView.h (200200 => 200201)


--- trunk/Source/WebKit/mac/WebView/WebPDFView.h	2016-04-28 18:18:58 UTC (rev 200200)
+++ trunk/Source/WebKit/mac/WebView/WebPDFView.h	2016-04-28 18:41:50 UTC (rev 200201)
@@ -28,13 +28,17 @@
 
 #if !PLATFORM(IOS)
 
+#import <PDFKit/PDFKit.h>
 #import <WebKitLegacy/WebDocumentInternal.h>
 
-@class PDFDocument;
-@class PDFView;
 @class WebDataSource;
 
-@interface WebPDFView : NSView <WebDocumentView, WebDocumentSearching, WebDocumentIncrementalSearching, WebMultipleTextMatches, WebDocumentSelection, WebDocumentElement, WebDocumentPDF, _WebDocumentViewState, _WebDocumentZooming>
+#if __MAC_OS_X_VERSION_MAX_ALLOWED < 101200
+@protocol PDFViewDelegate <NSObject>
+@end
+#endif
+
+@interface WebPDFView : NSView <PDFViewDelegate, WebDocumentView, WebDocumentSearching, WebDocumentIncrementalSearching, WebMultipleTextMatches, WebDocumentSelection, WebDocumentElement, WebDocumentPDF, _WebDocumentViewState, _WebDocumentZooming>
 {
     NSView *previewView;
     PDFView *PDFSubview;

Modified: trunk/Source/WebKit/mac/WebView/WebPDFView.mm (200200 => 200201)


--- trunk/Source/WebKit/mac/WebView/WebPDFView.mm	2016-04-28 18:18:58 UTC (rev 200200)
+++ trunk/Source/WebKit/mac/WebView/WebPDFView.mm	2016-04-28 18:41:50 UTC (rev 200201)
@@ -65,8 +65,6 @@
 #import <wtf/Assertions.h>
 #import <wtf/CurrentTime.h>
 
-#import <PDFKit/PDFKit.h>
-
 #if USE(APPLE_INTERNAL_SDK)
 #import <ApplicationServices/ApplicationServicesPriv.h>
 #endif

Modified: trunk/Source/WebKit2/ChangeLog (200200 => 200201)


--- trunk/Source/WebKit2/ChangeLog	2016-04-28 18:18:58 UTC (rev 200200)
+++ trunk/Source/WebKit2/ChangeLog	2016-04-28 18:41:50 UTC (rev 200201)
@@ -1,3 +1,12 @@
+2016-04-28  Daniel Bates  <[email protected]>
+
+        Fix the Apple Internal OS X build
+
+        * UIProcess/mac/WKPrintingView.mm:
+        (-[WKPrintingView _drawPDFDocument:page:atPoint:]): Ignore deprecation warning for -[PDFPage drawWithBox:].
+        * WebProcess/WebPage/mac/WebPageMac.mm:
+        (WebKit::drawPDFPage): Ditto.
+
 2016-04-28  Manuel Rego Casasnovas  <[email protected]>
 
         Fix mistake in custom elements runtime flag

Modified: trunk/Source/WebKit2/UIProcess/mac/WKPrintingView.mm (200200 => 200201)


--- trunk/Source/WebKit2/UIProcess/mac/WKPrintingView.mm	2016-04-28 18:18:58 UTC (rev 200200)
+++ trunk/Source/WebKit2/UIProcess/mac/WKPrintingView.mm	2016-04-28 18:41:50 UTC (rev 200201)
@@ -449,7 +449,10 @@
     CGContextTranslateCTM(context, point.x, point.y);
     CGContextScaleCTM(context, _totalScaleFactorForPrinting, -_totalScaleFactorForPrinting);
     CGContextTranslateCTM(context, 0, -[pdfPage boundsForBox:kPDFDisplayBoxMediaBox].size.height);
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
     [pdfPage drawWithBox:kPDFDisplayBoxMediaBox];
+#pragma clang diagnostic pop
 
     CGAffineTransform transform = CGContextGetCTM(context);
 

Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm (200200 => 200201)


--- trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm	2016-04-28 18:18:58 UTC (rev 200200)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm	2016-04-28 18:41:50 UTC (rev 200201)
@@ -832,7 +832,10 @@
 
     [NSGraphicsContext saveGraphicsState];
     [NSGraphicsContext setCurrentContext:[NSGraphicsContext graphicsContextWithGraphicsPort:context flipped:NO]];
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
     [pdfPage drawWithBox:kPDFDisplayBoxCropBox];
+#pragma clang diagnostic pop
     [NSGraphicsContext restoreGraphicsState];
 
     CGAffineTransform transform = CGContextGetCTM(context);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to