Title: [200212] trunk
- Revision
- 200212
- Author
- [email protected]
- Date
- 2016-04-28 15:10:59 -0700 (Thu, 28 Apr 2016)
Log Message
inspector/indexeddb/requestDatabaseNames.html is flaky on Mac.
https://bugs.webkit.org/show_bug.cgi?id=157141
Reviewed by Alex Christensen.
Source/WebCore:
Test: inspector/indexeddb/deleteDatabaseNamesWithSpace.html
* platform/FileSystem.cpp:
(WebCore::decodeFromFilename): Advance iterator after decoding.
LayoutTests:
* inspector/indexeddb/deleteDatabaseNamesWithSpace-expected.txt: Added.
* inspector/indexeddb/deleteDatabaseNamesWithSpace.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (200211 => 200212)
--- trunk/LayoutTests/ChangeLog 2016-04-28 21:41:19 UTC (rev 200211)
+++ trunk/LayoutTests/ChangeLog 2016-04-28 22:10:59 UTC (rev 200212)
@@ -1,3 +1,13 @@
+2016-04-28 Brady Eidson <[email protected]>
+
+ inspector/indexeddb/requestDatabaseNames.html is flaky on Mac.
+ https://bugs.webkit.org/show_bug.cgi?id=157141
+
+ Reviewed by Alex Christensen.
+
+ * inspector/indexeddb/deleteDatabaseNamesWithSpace-expected.txt: Added.
+ * inspector/indexeddb/deleteDatabaseNamesWithSpace.html: Added.
+
2016-04-28 Ryan Haddad <[email protected]>
Add ios-simulator baseline for fast/forms/select-non-native-rendering-direction.html
Added: trunk/LayoutTests/inspector/indexeddb/deleteDatabaseNamesWithSpace-expected.txt (0 => 200212)
--- trunk/LayoutTests/inspector/indexeddb/deleteDatabaseNamesWithSpace-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/indexeddb/deleteDatabaseNamesWithSpace-expected.txt 2016-04-28 22:10:59 UTC (rev 200212)
@@ -0,0 +1,10 @@
+CONSOLE MESSAGE: line 11: Created Database 'Database With Space'
+
+PASS: No IndexedDB databases should exist initially
+[]
+Created Database 'Database With Space'
+PASS: A single IndexedDB database should exist
+["Database With Space"]
+PASS: No IndexedDB databases should exist at the end because we just deleted them
+[]
+
Added: trunk/LayoutTests/inspector/indexeddb/deleteDatabaseNamesWithSpace.html (0 => 200212)
--- trunk/LayoutTests/inspector/indexeddb/deleteDatabaseNamesWithSpace.html (rev 0)
+++ trunk/LayoutTests/inspector/indexeddb/deleteDatabaseNamesWithSpace.html 2016-04-28 22:10:59 UTC (rev 200212)
@@ -0,0 +1,88 @@
+<!DOCTYPE html>
+<html>
+<head>
+<script src=""
+<script>
+function createDatabase(name)
+{
+ let request = window.indexedDB.open(name, 1);
+ request.addEventListener('success', function(event) {
+ event.target.result.close();
+ console.log(`Created Database '${name}'`);
+ });
+}
+
+function deleteDatabaseNames(names)
+{
+ for (let name of names)
+ var request = window.indexedDB.deleteDatabase(name);
+}
+
+function test()
+{
+ var steps = [
+ {
+ action: function() {
+ // FIXME: Remove any existing IndexedDB databases that might exist to workaround:
+ // <https://webkit.org/b/148006> Each test should run with its own clean data store
+ IndexedDBAgent.requestDatabaseNames(WebInspector.frameResourceManager.mainFrame.securityOrigin, function(error, names) {
+ InspectorTest.evaluateInPage("deleteDatabaseNames(" + JSON.stringify(names) + ")");
+ next();
+ });
+ }
+ },
+ {
+ action: function() {
+ IndexedDBAgent.requestDatabaseNames(WebInspector.frameResourceManager.mainFrame.securityOrigin, function(error, names) {
+ InspectorTest.expectNoError(error);
+ InspectorTest.expectThat(names.length === 0, "No IndexedDB databases should exist initially");
+ InspectorTest.log(JSON.stringify(names));
+ InspectorTest.evaluateInPage("createDatabase('Database With Space')");
+ });
+ }
+ },
+ {
+ action: function() {
+ IndexedDBAgent.requestDatabaseNames(WebInspector.frameResourceManager.mainFrame.securityOrigin, function(error, names) {
+ InspectorTest.expectNoError(error);
+ InspectorTest.expectThat(names.length === 1, "A single IndexedDB database should exist");
+ InspectorTest.log(JSON.stringify(names));
+ InspectorTest.evaluateInPage("deleteDatabaseNames(['Database With Space'])");
+ next();
+ });
+ }
+ },
+ {
+ action: function() {
+ IndexedDBAgent.requestDatabaseNames(WebInspector.frameResourceManager.mainFrame.securityOrigin, function(error, names) {
+ InspectorTest.expectNoError(error);
+ InspectorTest.expectThat(names.length === 0, "No IndexedDB databases should exist at the end because we just deleted them");
+ InspectorTest.log(JSON.stringify(names));
+ next();
+ });
+ }
+ },
+ ];
+
+ function next() {
+ let step = steps.shift();
+ if (!step) {
+ InspectorTest.completeTest();
+ return;
+ }
+ step.action();
+ }
+
+ WebInspector.logManager.addEventListener(WebInspector.LogManager.Event.MessageAdded, function(event) {
+ InspectorTest.log(event.data.message.messageText);
+ next();
+ });
+
+ InspectorTest.log("");
+ next();
+}
+</script>
+</head>
+<body _onload_="runTest()">
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (200211 => 200212)
--- trunk/Source/WebCore/ChangeLog 2016-04-28 21:41:19 UTC (rev 200211)
+++ trunk/Source/WebCore/ChangeLog 2016-04-28 22:10:59 UTC (rev 200212)
@@ -1,3 +1,15 @@
+2016-04-28 Brady Eidson <[email protected]>
+
+ inspector/indexeddb/requestDatabaseNames.html is flaky on Mac.
+ https://bugs.webkit.org/show_bug.cgi?id=157141
+
+ Reviewed by Alex Christensen.
+
+ Test: inspector/indexeddb/deleteDatabaseNamesWithSpace.html
+
+ * platform/FileSystem.cpp:
+ (WebCore::decodeFromFilename): Advance iterator after decoding.
+
2016-04-28 Dan Bernstein <[email protected]>
<rdar://problem/25986324> WebKit build broken with error: undeclared selector 'childViewControllerForWhitePointAdaptivityStyle'
Modified: trunk/Source/WebCore/platform/FileSystem.cpp (200211 => 200212)
--- trunk/Source/WebCore/platform/FileSystem.cpp 2016-04-28 21:41:19 UTC (rev 200211)
+++ trunk/Source/WebCore/platform/FileSystem.cpp 2016-04-28 22:10:59 UTC (rev 200212)
@@ -160,6 +160,8 @@
return { };
result.append(character | value);
+ i += 2;
+
continue;
}
@@ -185,6 +187,7 @@
return { };
result.append(character | value);
+ i += 5;
}
return result.toString();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
