Diff
Modified: trunk/LayoutTests/ChangeLog (200213 => 200214)
--- trunk/LayoutTests/ChangeLog 2016-04-28 22:55:27 UTC (rev 200213)
+++ trunk/LayoutTests/ChangeLog 2016-04-28 23:12:37 UTC (rev 200214)
@@ -1,3 +1,16 @@
+2016-04-28 Chris Fleizach <[email protected]>
+
+ AX: superscript content exposed as plain text; VoiceOver does not speak or pause to make this understandable
+ https://bugs.webkit.org/show_bug.cgi?id=157122
+ <rdar://problem/21231487>
+
+ Reviewed by Daniel Bates.
+
+ * accessibility/mac/subroles-for-formatted-groups-expected.txt:
+ * accessibility/mac/subroles-for-formatted-groups.html:
+ * platform/mac/accessibility/accessibility/roles-exposed-expected.txt:
+ * accessibility/roles-computedRoleString-expected.txt:
+
2016-04-28 Simon Fraser <[email protected]>
https://bugs.webkit.org/show_bug.cgi?id=157140
Modified: trunk/LayoutTests/accessibility/mac/subroles-for-formatted-groups-expected.txt (200213 => 200214)
--- trunk/LayoutTests/accessibility/mac/subroles-for-formatted-groups-expected.txt 2016-04-28 22:55:27 UTC (rev 200213)
+++ trunk/LayoutTests/accessibility/mac/subroles-for-formatted-groups-expected.txt 2016-04-28 23:12:37 UTC (rev 200214)
@@ -2,7 +2,7 @@
kbd
sample
pre
-var insert delete cite
+var insert delete cite sub sup
This test makes sure that formatting style groups.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
@@ -16,6 +16,8 @@
ins: AXSubrole: AXInsertStyleGroup
del: AXSubrole: AXDeleteStyleGroup
cite: AXSubrole: AXCiteStyleGroup
+sub: AXSubrole: AXSubscriptStyleGroup
+sup: AXSubrole: AXSuperscriptStyleGroup
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/accessibility/mac/subroles-for-formatted-groups.html (200213 => 200214)
--- trunk/LayoutTests/accessibility/mac/subroles-for-formatted-groups.html 2016-04-28 22:55:27 UTC (rev 200213)
+++ trunk/LayoutTests/accessibility/mac/subroles-for-formatted-groups.html 2016-04-28 23:12:37 UTC (rev 200214)
@@ -13,6 +13,8 @@
<ins id="ins">insert</ins>
<del id="del">delete</del>
<cite id="cite">cite</cite>
+<sub id="sub">sub</sub>
+<sup id="sup">sup</sup>
<p id="description"></p>
<div id="console"></div>
@@ -30,6 +32,8 @@
debug("ins: " + accessibilityController.accessibleElementById('ins').subrole);
debug("del: " + accessibilityController.accessibleElementById('del').subrole);
debug("cite: " + accessibilityController.accessibleElementById('cite').subrole);
+ debug("sub: " + accessibilityController.accessibleElementById('sub').subrole);
+ debug("sup: " + accessibilityController.accessibleElementById('sup').subrole);
}
</script>
Modified: trunk/LayoutTests/accessibility/roles-computedRoleString-expected.txt (200213 => 200214)
--- trunk/LayoutTests/accessibility/roles-computedRoleString-expected.txt 2016-04-28 22:55:27 UTC (rev 200213)
+++ trunk/LayoutTests/accessibility/roles-computedRoleString-expected.txt 2016-04-28 23:12:37 UTC (rev 200214)
@@ -59,6 +59,8 @@
PASS: optgroup -> option.
PASS: option -> option.
PASS: option -> option.
+PASS: sub -> .
+PASS: sup -> .
PASS: table -> table.
PASS: tr -> row.
PASS: th -> columnheader.
Modified: trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt (200213 => 200214)
--- trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt 2016-04-28 22:55:27 UTC (rev 200213)
+++ trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt 2016-04-28 23:12:37 UTC (rev 200214)
@@ -635,14 +635,14 @@
AXRoleDescription:
sub
- AXRole:
- AXSubrole:
- AXRoleDescription:
+ AXRole: AXGroup
+ AXSubrole: AXSubscriptStyleGroup
+ AXRoleDescription: group
sup
- AXRole:
- AXSubrole:
- AXRoleDescription:
+ AXRole: AXGroup
+ AXSubrole: AXSuperscriptStyleGroup
+ AXRoleDescription: group
svg
AXRole:
Modified: trunk/Source/WebCore/ChangeLog (200213 => 200214)
--- trunk/Source/WebCore/ChangeLog 2016-04-28 22:55:27 UTC (rev 200213)
+++ trunk/Source/WebCore/ChangeLog 2016-04-28 23:12:37 UTC (rev 200214)
@@ -1,3 +1,20 @@
+2016-04-28 Chris Fleizach <[email protected]>
+
+ AX: superscript content exposed as plain text; VoiceOver does not speak or pause to make this understandable
+ https://bugs.webkit.org/show_bug.cgi?id=157122
+ <rdar://problem/21231487>
+
+ Reviewed by Daniel Bates.
+
+ Expose role types for subscript and superscript.
+
+ Modified: accessibility/mac/subroles-for-formatted-groups.html
+
+ * accessibility/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::isStyleFormatGroup):
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper subrole]):
+
2016-04-28 Brady Eidson <[email protected]>
inspector/indexeddb/requestDatabaseNames.html is flaky on Mac.
Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (200213 => 200214)
--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2016-04-28 22:55:27 UTC (rev 200213)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2016-04-28 23:12:37 UTC (rev 200214)
@@ -3024,7 +3024,8 @@
return node->hasTagName(kbdTag) || node->hasTagName(codeTag)
|| node->hasTagName(preTag) || node->hasTagName(sampTag)
|| node->hasTagName(varTag) || node->hasTagName(citeTag)
- || node->hasTagName(insTag) || node->hasTagName(delTag);
+ || node->hasTagName(insTag) || node->hasTagName(delTag)
+ || node->hasTagName(supTag) || node->hasTagName(subTag);
}
bool AccessibilityObject::isContainedByPasswordField() const
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (200213 => 200214)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2016-04-28 22:55:27 UTC (rev 200213)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2016-04-28 23:12:37 UTC (rev 200214)
@@ -2413,6 +2413,10 @@
return @"AXInsertStyleGroup";
if (node->hasTagName(delTag))
return @"AXDeleteStyleGroup";
+ if (node->hasTagName(supTag))
+ return @"AXSuperscriptStyleGroup";
+ if (node->hasTagName(subTag))
+ return @"AXSubscriptStyleGroup";
}
}
